From: kernel test robot <lkp@intel.com>
To: Jocelyn Falempe <jfalempe@redhat.com>,
dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
airlied@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, daniel@ffwll.ch, javierm@redhat.com,
bluescreen_avenger@verizon.net, noralf@tronnes.org
Cc: oe-kbuild-all@lists.linux.dev, gpiccoli@igalia.com,
Jocelyn Falempe <jfalempe@redhat.com>
Subject: Re: [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill
Date: Sat, 4 Nov 2023 02:34:38 +0800 [thread overview]
Message-ID: <202311040208.JqcG6ZbK-lkp@intel.com> (raw)
In-Reply-To: <20231103145526.628138-2-jfalempe@redhat.com>
Hi Jocelyn,
kernel test robot noticed the following build warnings:
[auto build test WARNING on ffc253263a1375a65fa6c9f62a893e9767fbebfa]
url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Add-drm_fb_blit_from_r1-and-drm_fb_fill/20231103-225824
base: ffc253263a1375a65fa6c9f62a893e9767fbebfa
patch link: https://lore.kernel.org/r/20231103145526.628138-2-jfalempe%40redhat.com
patch subject: [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill
config: csky-randconfig-002-20231104 (https://download.01.org/0day-ci/archive/20231104/202311040208.JqcG6ZbK-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040208.JqcG6ZbK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040208.JqcG6ZbK-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_format_helper.c:491: warning: Function parameter or member 'dpitch' not described in 'drm_fb_blit_from_r1'
>> drivers/gpu/drm/drm_format_helper.c:491: warning: Excess function parameter 'dpich' description in 'drm_fb_blit_from_r1'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Function parameter or member 'dpitch' not described in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Function parameter or member 'color' not described in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'dpich' description in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'fg_color' description in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'bg_color' description in 'drm_fb_fill'
vim +491 drivers/gpu/drm/drm_format_helper.c
470
471 /**
472 * drm_fb_blit_from_r1 - convert a monochrome image to a linear framebuffer
473 * @dmap: destination iosys_map
474 * @dpich: destination pitch in bytes
475 * @sbuf8: source buffer, in monochrome format, 8 pixels per byte.
476 * @spitch: source pitch in bytes
477 * @height: height of the image to copy, in pixels
478 * @width: width of the image to copy, in pixels
479 * @fg_color: foreground color, in destination format
480 * @bg_color: background color, in destination format
481 * @pixel_width: pixel width in bytes.
482 *
483 * This can be used to draw font which are monochrome images, to a framebuffer
484 * in other supported format.
485 */
486 void drm_fb_blit_from_r1(struct iosys_map *dmap, unsigned int dpitch,
487 const u8 *sbuf8, unsigned int spitch,
488 unsigned int height, unsigned int width,
489 u32 fg_color, u32 bg_color,
490 unsigned int pixel_width)
> 491 {
492 switch (pixel_width) {
493 case 2:
494 drm_fb_r1_to_16bit(dmap, dpitch, sbuf8, spitch,
495 height, width, fg_color, bg_color);
496 break;
497 case 3:
498 drm_fb_r1_to_24bit(dmap, dpitch, sbuf8, spitch,
499 height, width, fg_color, bg_color);
500 break;
501 case 4:
502 drm_fb_r1_to_32bit(dmap, dpitch, sbuf8, spitch,
503 height, width, fg_color, bg_color);
504 break;
505 default:
506 WARN_ONCE(1, "Can't blit with pixel width %d\n", pixel_width);
507 }
508 }
509 EXPORT_SYMBOL(drm_fb_blit_from_r1);
510
511 static void drm_fb_fill8(struct iosys_map *dmap, unsigned int dpitch,
512 unsigned int height, unsigned int width,
513 u8 color)
514 {
515 unsigned int l, x;
516
517 for (l = 0; l < height; l++)
518 for (x = 0; x < width; x++)
519 iosys_map_wr(dmap, l * dpitch + x * sizeof(u8), u8, color);
520 }
521
522 static void drm_fb_fill16(struct iosys_map *dmap, unsigned int dpitch,
523 unsigned int height, unsigned int width,
524 u16 color)
525 {
526 unsigned int l, x;
527
528 for (l = 0; l < height; l++)
529 for (x = 0; x < width; x++)
530 iosys_map_wr(dmap, l * dpitch + x * sizeof(u16), u16, color);
531 }
532
533 static void drm_fb_fill24(struct iosys_map *dmap, unsigned int dpitch,
534 unsigned int height, unsigned int width,
535 u32 color)
536 {
537 unsigned int l, x;
538
539 for (l = 0; l < height; l++) {
540 for (x = 0; x < width; x++) {
541 unsigned int off = l * dpitch + x * 3;
542 u32 val32 = le32_to_cpu(color);
543
544 /* write blue-green-red to output in little endianness */
545 iosys_map_wr(dmap, off, u8, (val32 & 0x000000FF) >> 0);
546 iosys_map_wr(dmap, off + 1, u8, (val32 & 0x0000FF00) >> 8);
547 iosys_map_wr(dmap, off + 2, u8, (val32 & 0x00FF0000) >> 16);
548 }
549 }
550 }
551
552 static void drm_fb_fill32(struct iosys_map *dmap, unsigned int dpitch,
553 unsigned int height, unsigned int width,
554 u32 color)
555 {
556 unsigned int l, x;
557
558 for (l = 0; l < height; l++)
559 for (x = 0; x < width; x++)
560 iosys_map_wr(dmap, l * dpitch + x * sizeof(u32), u32, color);
561 }
562
563 /**
564 * drm_fb_fill - Fill a rectangle with a color
565 * @dmap: destination iosys_map, pointing to the top left corner of the rectangle
566 * @dpich: destination pitch in bytes
567 * @height: height of the rectangle, in pixels
568 * @width: width of the rectangle, in pixels
569 * @fg_color: foreground color, in destination format
570 * @bg_color: background color, in destination format
571 * @pixel_width: pixel width in bytes
572 *
573 * Fill a rectangle with a color, in a linear framebuffer.
574 */
575 void drm_fb_fill(struct iosys_map *dmap, unsigned int dpitch,
576 unsigned int height, unsigned int width,
577 u32 color, unsigned int pixel_width)
> 578 {
579 switch (pixel_width) {
580 case 1:
581 drm_fb_fill8(dmap, dpitch, height, width, color);
582 break;
583 case 2:
584 drm_fb_fill16(dmap, dpitch, height, width, color);
585 break;
586 case 3:
587 drm_fb_fill24(dmap, dpitch, height, width, color);
588 break;
589 case 4:
590 drm_fb_fill32(dmap, dpitch, height, width, color);
591 break;
592 default:
593 WARN_ONCE(1, "Can't fill with pixel width %d\n", pixel_width);
594 }
595 }
596 EXPORT_SYMBOL(drm_fb_fill);
597
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Jocelyn Falempe <jfalempe@redhat.com>,
dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
airlied@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, daniel@ffwll.ch, javierm@redhat.com,
bluescreen_avenger@verizon.net, noralf@tronnes.org
Cc: gpiccoli@igalia.com, Jocelyn Falempe <jfalempe@redhat.com>,
oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill
Date: Sat, 4 Nov 2023 02:34:38 +0800 [thread overview]
Message-ID: <202311040208.JqcG6ZbK-lkp@intel.com> (raw)
In-Reply-To: <20231103145526.628138-2-jfalempe@redhat.com>
Hi Jocelyn,
kernel test robot noticed the following build warnings:
[auto build test WARNING on ffc253263a1375a65fa6c9f62a893e9767fbebfa]
url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Add-drm_fb_blit_from_r1-and-drm_fb_fill/20231103-225824
base: ffc253263a1375a65fa6c9f62a893e9767fbebfa
patch link: https://lore.kernel.org/r/20231103145526.628138-2-jfalempe%40redhat.com
patch subject: [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill
config: csky-randconfig-002-20231104 (https://download.01.org/0day-ci/archive/20231104/202311040208.JqcG6ZbK-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040208.JqcG6ZbK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040208.JqcG6ZbK-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_format_helper.c:491: warning: Function parameter or member 'dpitch' not described in 'drm_fb_blit_from_r1'
>> drivers/gpu/drm/drm_format_helper.c:491: warning: Excess function parameter 'dpich' description in 'drm_fb_blit_from_r1'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Function parameter or member 'dpitch' not described in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Function parameter or member 'color' not described in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'dpich' description in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'fg_color' description in 'drm_fb_fill'
>> drivers/gpu/drm/drm_format_helper.c:578: warning: Excess function parameter 'bg_color' description in 'drm_fb_fill'
vim +491 drivers/gpu/drm/drm_format_helper.c
470
471 /**
472 * drm_fb_blit_from_r1 - convert a monochrome image to a linear framebuffer
473 * @dmap: destination iosys_map
474 * @dpich: destination pitch in bytes
475 * @sbuf8: source buffer, in monochrome format, 8 pixels per byte.
476 * @spitch: source pitch in bytes
477 * @height: height of the image to copy, in pixels
478 * @width: width of the image to copy, in pixels
479 * @fg_color: foreground color, in destination format
480 * @bg_color: background color, in destination format
481 * @pixel_width: pixel width in bytes.
482 *
483 * This can be used to draw font which are monochrome images, to a framebuffer
484 * in other supported format.
485 */
486 void drm_fb_blit_from_r1(struct iosys_map *dmap, unsigned int dpitch,
487 const u8 *sbuf8, unsigned int spitch,
488 unsigned int height, unsigned int width,
489 u32 fg_color, u32 bg_color,
490 unsigned int pixel_width)
> 491 {
492 switch (pixel_width) {
493 case 2:
494 drm_fb_r1_to_16bit(dmap, dpitch, sbuf8, spitch,
495 height, width, fg_color, bg_color);
496 break;
497 case 3:
498 drm_fb_r1_to_24bit(dmap, dpitch, sbuf8, spitch,
499 height, width, fg_color, bg_color);
500 break;
501 case 4:
502 drm_fb_r1_to_32bit(dmap, dpitch, sbuf8, spitch,
503 height, width, fg_color, bg_color);
504 break;
505 default:
506 WARN_ONCE(1, "Can't blit with pixel width %d\n", pixel_width);
507 }
508 }
509 EXPORT_SYMBOL(drm_fb_blit_from_r1);
510
511 static void drm_fb_fill8(struct iosys_map *dmap, unsigned int dpitch,
512 unsigned int height, unsigned int width,
513 u8 color)
514 {
515 unsigned int l, x;
516
517 for (l = 0; l < height; l++)
518 for (x = 0; x < width; x++)
519 iosys_map_wr(dmap, l * dpitch + x * sizeof(u8), u8, color);
520 }
521
522 static void drm_fb_fill16(struct iosys_map *dmap, unsigned int dpitch,
523 unsigned int height, unsigned int width,
524 u16 color)
525 {
526 unsigned int l, x;
527
528 for (l = 0; l < height; l++)
529 for (x = 0; x < width; x++)
530 iosys_map_wr(dmap, l * dpitch + x * sizeof(u16), u16, color);
531 }
532
533 static void drm_fb_fill24(struct iosys_map *dmap, unsigned int dpitch,
534 unsigned int height, unsigned int width,
535 u32 color)
536 {
537 unsigned int l, x;
538
539 for (l = 0; l < height; l++) {
540 for (x = 0; x < width; x++) {
541 unsigned int off = l * dpitch + x * 3;
542 u32 val32 = le32_to_cpu(color);
543
544 /* write blue-green-red to output in little endianness */
545 iosys_map_wr(dmap, off, u8, (val32 & 0x000000FF) >> 0);
546 iosys_map_wr(dmap, off + 1, u8, (val32 & 0x0000FF00) >> 8);
547 iosys_map_wr(dmap, off + 2, u8, (val32 & 0x00FF0000) >> 16);
548 }
549 }
550 }
551
552 static void drm_fb_fill32(struct iosys_map *dmap, unsigned int dpitch,
553 unsigned int height, unsigned int width,
554 u32 color)
555 {
556 unsigned int l, x;
557
558 for (l = 0; l < height; l++)
559 for (x = 0; x < width; x++)
560 iosys_map_wr(dmap, l * dpitch + x * sizeof(u32), u32, color);
561 }
562
563 /**
564 * drm_fb_fill - Fill a rectangle with a color
565 * @dmap: destination iosys_map, pointing to the top left corner of the rectangle
566 * @dpich: destination pitch in bytes
567 * @height: height of the rectangle, in pixels
568 * @width: width of the rectangle, in pixels
569 * @fg_color: foreground color, in destination format
570 * @bg_color: background color, in destination format
571 * @pixel_width: pixel width in bytes
572 *
573 * Fill a rectangle with a color, in a linear framebuffer.
574 */
575 void drm_fb_fill(struct iosys_map *dmap, unsigned int dpitch,
576 unsigned int height, unsigned int width,
577 u32 color, unsigned int pixel_width)
> 578 {
579 switch (pixel_width) {
580 case 1:
581 drm_fb_fill8(dmap, dpitch, height, width, color);
582 break;
583 case 2:
584 drm_fb_fill16(dmap, dpitch, height, width, color);
585 break;
586 case 3:
587 drm_fb_fill24(dmap, dpitch, height, width, color);
588 break;
589 case 4:
590 drm_fb_fill32(dmap, dpitch, height, width, color);
591 break;
592 default:
593 WARN_ONCE(1, "Can't fill with pixel width %d\n", pixel_width);
594 }
595 }
596 EXPORT_SYMBOL(drm_fb_fill);
597
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-03 18:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 14:53 [RFC][PATCH v5 0/6] drm/panic: Add a drm panic handler Jocelyn Falempe
2023-11-03 14:53 ` [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill Jocelyn Falempe
2023-11-03 18:34 ` kernel test robot [this message]
2023-11-03 18:34 ` kernel test robot
2023-11-04 6:04 ` kernel test robot
2023-11-04 6:04 ` kernel test robot
2023-11-03 14:53 ` [PATCH v5 2/6] drm/panic: Add a drm panic handler Jocelyn Falempe
2023-11-03 14:53 ` [PATCH v5 3/6] drm/simpledrm: Add drm_panic support Jocelyn Falempe
2023-11-03 14:53 ` [PATCH v5 4/6] drm/mgag200: " Jocelyn Falempe
2023-11-03 14:53 ` [PATCH v5 5/6] drm/ast: " Jocelyn Falempe
2023-11-03 18:52 ` kernel test robot
2023-11-03 18:52 ` kernel test robot
2023-11-04 3:57 ` kernel test robot
2023-11-04 3:57 ` kernel test robot
2023-11-03 14:53 ` [PATCH v5 6/6] drm/imx: " Jocelyn Falempe
2023-12-14 13:48 ` Maxime Ripard
2023-12-14 14:36 ` Maxime Ripard
2023-12-14 15:03 ` Jocelyn Falempe
2023-12-14 18:37 ` Maxime Ripard
2023-11-13 13:59 ` [RFC][PATCH v5 0/6] drm/panic: Add a drm panic handler nerdopolis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311040208.JqcG6ZbK-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@redhat.com \
--cc=bluescreen_avenger@verizon.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpiccoli@igalia.com \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.