From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andyshrk@163.com>,
heiko@sntech.de, hjc@rock-chips.com,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, kever.yang@rock-chips.com,
chris.obbard@collabora.com
Subject: Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588
Date: Thu, 16 Nov 2023 14:47:57 +0100 [thread overview]
Message-ID: <20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org> (raw)
In-Reply-To: <8f2ebc81-51c5-44d5-b27b-633a6cc85d0d@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
Hi,
On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote:
> > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
> > This already lacks an error check, shame on me...
> >
> > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
> > > + vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
> > > + vop2->sys_pmu = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,pmu");
> > ... but please don't duplicate that.
>
> It a little difficult to find a proper way to do the check, as not every soc need all these phandles.
>
> Do i need check it per soc?
I suggest adding a u32 flags to struct vop2_data and then have
something like this:
if (vop2_data->flags & VOP2_HAS_VOP_GRF) {
vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
if (IS_ERR(vop2->vop_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vop_grf) "cannot get vop-grf");
}
if (vop2_data->flags & VOP2_HAS_VO1_GRF) {
vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
if (IS_ERR(vop2->vo1_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vo1_grf) "cannot get vo1-grf");
}
...
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Andy Yan <andyshrk@163.com>,
heiko@sntech.de, hjc@rock-chips.com,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, kever.yang@rock-chips.com,
chris.obbard@collabora.com
Subject: Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588
Date: Thu, 16 Nov 2023 14:47:57 +0100 [thread overview]
Message-ID: <20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org> (raw)
In-Reply-To: <8f2ebc81-51c5-44d5-b27b-633a6cc85d0d@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 1299 bytes --]
Hi,
On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote:
> > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
> > This already lacks an error check, shame on me...
> >
> > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
> > > + vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
> > > + vop2->sys_pmu = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,pmu");
> > ... but please don't duplicate that.
>
> It a little difficult to find a proper way to do the check, as not every soc need all these phandles.
>
> Do i need check it per soc?
I suggest adding a u32 flags to struct vop2_data and then have
something like this:
if (vop2_data->flags & VOP2_HAS_VOP_GRF) {
vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
if (IS_ERR(vop2->vop_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vop_grf) "cannot get vop-grf");
}
if (vop2_data->flags & VOP2_HAS_VO1_GRF) {
vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
if (IS_ERR(vop2->vo1_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vo1_grf) "cannot get vo1-grf");
}
...
Greetings,
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
chris.obbard@collabora.com
Subject: Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588
Date: Thu, 16 Nov 2023 14:47:57 +0100 [thread overview]
Message-ID: <20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org> (raw)
In-Reply-To: <8f2ebc81-51c5-44d5-b27b-633a6cc85d0d@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
Hi,
On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote:
> > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
> > This already lacks an error check, shame on me...
> >
> > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
> > > + vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
> > > + vop2->sys_pmu = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,pmu");
> > ... but please don't duplicate that.
>
> It a little difficult to find a proper way to do the check, as not every soc need all these phandles.
>
> Do i need check it per soc?
I suggest adding a u32 flags to struct vop2_data and then have
something like this:
if (vop2_data->flags & VOP2_HAS_VOP_GRF) {
vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf");
if (IS_ERR(vop2->vop_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vop_grf) "cannot get vop-grf");
}
if (vop2_data->flags & VOP2_HAS_VO1_GRF) {
vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf");
if (IS_ERR(vop2->vo1_grf))
return dev_err_probe(dev, PTR_ERR(vop2->vo1_grf) "cannot get vo1-grf");
}
...
Greetings,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-16 13:48 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 11:25 [PATCH 00/11] Add VOP2 support on rk3588 Andy Yan
2023-11-14 11:25 ` Andy Yan
2023-11-14 11:25 ` Andy Yan
2023-11-14 11:27 ` [PATCH 01/11] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` [PATCH 02/11] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` [PATCH 03/11] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` [PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` [PATCH 05/11] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:27 ` Andy Yan
2023-11-14 11:28 ` [PATCH 06/11] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 11:28 ` [PATCH 07/11] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-16 19:26 ` Rob Herring
2023-11-16 19:26 ` Rob Herring
2023-11-16 19:26 ` Rob Herring
2023-11-14 11:28 ` [PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 13:44 ` Rob Herring
2023-11-14 13:44 ` Rob Herring
2023-11-14 13:44 ` Rob Herring
2023-11-14 21:54 ` Heiko Stübner
2023-11-14 21:54 ` Heiko Stübner
2023-11-14 21:54 ` Heiko Stübner
2023-11-15 2:45 ` Andy Yan
2023-11-15 2:45 ` Andy Yan
2023-11-15 2:45 ` Andy Yan
2023-11-14 11:28 ` [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 11:28 ` Andy Yan
2023-11-14 23:34 ` Heiko Stübner
2023-11-14 23:34 ` Heiko Stübner
2023-11-14 23:34 ` Heiko Stübner
2023-11-15 2:02 ` Andy Yan
2023-11-15 2:02 ` Andy Yan
2023-11-15 2:02 ` Andy Yan
2023-11-15 8:24 ` Heiko Stübner
2023-11-15 8:24 ` Heiko Stübner
2023-11-15 8:24 ` Heiko Stübner
2023-11-15 9:08 ` Sascha Hauer
2023-11-15 9:08 ` Sascha Hauer
2023-11-15 9:08 ` Sascha Hauer
2023-11-16 7:24 ` Andy Yan
2023-11-16 7:24 ` Andy Yan
2023-11-16 7:24 ` Andy Yan
2023-11-16 7:50 ` Sascha Hauer
2023-11-16 7:50 ` Sascha Hauer
2023-11-16 7:50 ` Sascha Hauer
2023-11-16 8:00 ` Andy Yan
2023-11-16 8:00 ` Andy Yan
2023-11-16 8:00 ` Andy Yan
2023-11-16 10:39 ` Andy Yan
2023-11-16 10:39 ` Andy Yan
2023-11-16 10:39 ` Andy Yan
2023-11-16 13:47 ` Sebastian Reichel [this message]
2023-11-16 13:47 ` Sebastian Reichel
2023-11-16 13:47 ` Sebastian Reichel
2023-11-17 7:06 ` Andy Yan
2023-11-17 7:06 ` Andy Yan
2023-11-17 7:06 ` Andy Yan
2023-11-17 9:39 ` Sascha Hauer
2023-11-17 9:39 ` Sascha Hauer
2023-11-17 9:39 ` Sascha Hauer
2023-11-16 19:27 ` Rob Herring
2023-11-16 19:27 ` Rob Herring
2023-11-16 19:27 ` Rob Herring
2023-11-17 23:46 ` Jonas Karlman
2023-11-17 23:46 ` Jonas Karlman
2023-11-17 23:46 ` Jonas Karlman
2023-11-18 0:31 ` Andy Yan
2023-11-18 0:31 ` Andy Yan
2023-11-18 0:31 ` Andy Yan
2023-11-14 11:29 ` [PATCH 10/11] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-11-14 11:29 ` Andy Yan
2023-11-14 11:29 ` Andy Yan
2023-11-14 11:29 ` [PATCH 11/11] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
2023-11-14 11:29 ` Andy Yan
2023-11-14 11:29 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.