All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: linux-spi@vger.kernel.org, devicetree@vger.kernel.org
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 08/14] spi: axi-spi-engine: check for valid clock rate
Date: Fri, 17 Nov 2023 14:12:59 -0600	[thread overview]
Message-ID: <20231117-axi-spi-engine-series-1-v1-8-cc59db999b87@baylibre.com> (raw)
In-Reply-To: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com>

This adds a check for a valid SCLK rate in the axi-spi-engine driver
during probe. A valid rate is required to get accurate timing for delays
and by not allowing 0 we can avoid divide by zero errors later without
additional checks.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/spi/spi-axi-spi-engine.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index 819744246952..8a6fbb3bb3f1 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -532,6 +532,9 @@ static int spi_engine_probe(struct platform_device *pdev)
 	host->transfer_one_message = spi_engine_transfer_one_message;
 	host->num_chipselect = 8;
 
+	if (host->max_speed_hz == 0)
+		return dev_err_probe(&pdev->dev, -EINVAL, "spi_clk rate is 0");
+
 	ret = devm_spi_register_controller(&pdev->dev, host);
 	if (ret)
 		return ret;

-- 
2.42.0


  parent reply	other threads:[~2023-11-17 20:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 20:12 [PATCH 00/14] spi: axi-spi-engine improvements David Lechner
2023-11-17 20:12 ` [PATCH 01/14] dt-bindings: spi: axi-spi-engine: convert to yaml David Lechner
2023-11-19 16:18   ` Rob Herring
2023-11-17 20:12 ` [PATCH 02/14] MAINTAINERS: add entry for AXI SPI Engine David Lechner
2023-11-17 20:44   ` David Lechner
2023-11-19 19:01     ` Lars-Peter Clausen
2023-11-17 20:12 ` [PATCH 03/14] spi: axi-spi-engine: simplify driver data allocation David Lechner
2023-11-17 20:12 ` [PATCH 04/14] spi: axi-spi-engine: use devm_spi_alloc_host() David Lechner
2023-11-17 20:12 ` [PATCH 05/14] spi: axi-spi-engine: use devm action to reset hw on remove David Lechner
2023-11-17 20:12 ` [PATCH 06/14] spi: axi-spi-engine: use devm_request_irq() David Lechner
2023-11-17 20:12 ` [PATCH 07/14] spi: axi-spi-engine: use devm_spi_register_controller() David Lechner
2023-11-17 20:12 ` David Lechner [this message]
2023-11-17 20:13 ` [PATCH 09/14] spi: axi-spi-engine: move msg state to new struct David Lechner
2023-11-18  3:55   ` kernel test robot
2023-11-17 20:13 ` [PATCH 10/14] spi: axi-spi-engine: use message_prepare/unprepare David Lechner
2023-11-17 20:13 ` [PATCH 11/14] spi: axi-spi-engine: remove completed_id from driver state David Lechner
2023-11-17 20:13 ` [PATCH 12/14] spi: axi-spi-engine: remove struct spi_engine::msg David Lechner
2023-11-17 20:13 ` [PATCH 13/14] spi: axi-spi-engine: add support for cs_off David Lechner
2023-11-17 20:13 ` [PATCH 14/14] spi: axi-spi-engine: add support for any word size David Lechner
2023-11-20 18:25 ` [PATCH 00/14] spi: axi-spi-engine improvements Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231117-axi-spi-engine-series-1-v1-8-cc59db999b87@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.