From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Maurer <mmaurer@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <ojeda@kernel.org>, Gary Guo <gary@garyguo.net>,
Luis Chamberlain <mcgrof@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org,
rust-for-linux@vger.kernel.org, Laura Abbott <laura@labbott.name>
Subject: Re: [PATCH v2 1/5] export_report: Rehabilitate script
Date: Sat, 18 Nov 2023 06:35:14 -0500 [thread overview]
Message-ID: <2023111809-mayday-citable-4fbd@gregkh> (raw)
In-Reply-To: <20231118025748.2778044-2-mmaurer@google.com>
On Sat, Nov 18, 2023 at 02:54:42AM +0000, Matthew Maurer wrote:
> * modules.order has .o files when in a build dir, support this
> * .mod.c source layout has changed, update regexes to match
> * Add a stage 3, to be more robust against additional .mod.c content
When you have to list different things you do in a patch, that is a huge
hint that you need to break up your patch into smaller pieces.
Remember, each patch can only do one logical thing. I know it feels
odd, but it makes it easier to review.
This patch, as-is, is nothing that I would be able to take, please make
it a series.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Maurer <mmaurer@google.com>
Cc: Nicolas Schier <nicolas@fjasle.eu>,
rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>, Gary Guo <gary@garyguo.net>,
Miguel Ojeda <ojeda@kernel.org>,
Laura Abbott <laura@labbott.name>,
linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH v2 1/5] export_report: Rehabilitate script
Date: Sat, 18 Nov 2023 06:35:14 -0500 [thread overview]
Message-ID: <2023111809-mayday-citable-4fbd@gregkh> (raw)
In-Reply-To: <20231118025748.2778044-2-mmaurer@google.com>
On Sat, Nov 18, 2023 at 02:54:42AM +0000, Matthew Maurer wrote:
> * modules.order has .o files when in a build dir, support this
> * .mod.c source layout has changed, update regexes to match
> * Add a stage 3, to be more robust against additional .mod.c content
When you have to list different things you do in a patch, that is a huge
hint that you need to break up your patch into smaller pieces.
Remember, each patch can only do one logical thing. I know it feels
odd, but it makes it easier to review.
This patch, as-is, is nothing that I would be able to take, please make
it a series.
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-18 11:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 2:54 [PATCH v2 0/5] MODVERSIONS + RUST Redux Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-18 2:54 ` [PATCH v2 1/5] export_report: Rehabilitate script Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-18 11:35 ` Greg KH [this message]
2023-11-18 11:35 ` Greg KH
2023-11-18 2:54 ` [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-18 11:36 ` Greg KH
2023-11-18 11:36 ` Greg KH
2023-11-18 2:54 ` [PATCH v2 3/5] modpost: Extended modversion support Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-18 13:42 ` kernel test robot
2023-11-18 13:42 ` kernel test robot
2023-11-18 2:54 ` [PATCH v2 4/5] rust: Allow MODVERSIONS Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-18 2:54 ` [PATCH v2 5/5] export_report: Use new version info format Matthew Maurer
2023-11-18 2:54 ` Matthew Maurer
2023-11-22 15:49 ` [PATCH v2 0/5] MODVERSIONS + RUST Redux Masahiro Yamada
2023-11-22 15:49 ` Masahiro Yamada
2023-11-22 21:04 ` Matthew Maurer
2023-11-22 21:04 ` Matthew Maurer
2023-11-23 9:05 ` Greg KH
2023-11-23 9:05 ` Greg KH
2023-11-23 11:38 ` Masahiro Yamada
2023-11-23 11:38 ` Masahiro Yamada
2023-11-23 12:12 ` Greg KH
2023-11-23 12:12 ` Greg KH
2023-11-27 19:27 ` Matthew Maurer
2023-11-27 19:27 ` Matthew Maurer
2023-11-28 8:05 ` Greg KH
2023-11-28 8:05 ` Greg KH
2023-11-28 8:44 ` Greg KH
2023-11-28 8:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023111809-mayday-citable-4fbd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gary@garyguo.net \
--cc=laura@labbott.name \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mmaurer@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.