From: kernel test robot <lkp@intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
"Jianlong Huang" <jianlong.huang@starfivetech.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sean Wang" <sean.wang@kernel.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH v1 01/17] pinctrl: equilibrium: Convert to use struct pingroup
Date: Thu, 23 Nov 2023 11:11:25 +0800 [thread overview]
Message-ID: <202311230820.MGDyVHJW-lkp@intel.com> (raw)
In-Reply-To: <20231122164040.2262742-2-andriy.shevchenko@linux.intel.com>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next geert-renesas-drivers/renesas-pinctrl pinctrl-samsung/for-next linus/master v6.7-rc2 next-20231122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-equilibrium-Convert-to-use-struct-pingroup/20231123-005932
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20231122164040.2262742-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 01/17] pinctrl: equilibrium: Convert to use struct pingroup
config: i386-randconfig-001-20231123 (https://download.01.org/0day-ci/archive/20231123/202311230820.MGDyVHJW-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231123/202311230820.MGDyVHJW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311230820.MGDyVHJW-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pinctrl/pinctrl-equilibrium.c: In function 'eqbr_build_groups':
drivers/pinctrl/pinctrl-equilibrium.c:750:17: error: assignment of read-only location '*(grp->pins + (sizetype)((unsigned int)j * 4))'
750 | grp->pins[j] = pin_id;
| ^
drivers/pinctrl/pinctrl-equilibrium.c:761:23: error: 'struct pingroup' has no member named 'num_pins'; did you mean 'npins'?
761 | grp->pins, grp->num_pins,
| ^~~~~~~~
| npins
>> drivers/pinctrl/pinctrl-equilibrium.c:761:10: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
761 | grp->pins, grp->num_pins,
| ~~~^~~~~~
In file included from drivers/pinctrl/pinctrl-equilibrium.c:16:
drivers/pinctrl/core.h:225:15: note: expected 'int *' but argument is of type 'const unsigned int *'
225 | int *gpins, int ngpins, void *data);
| ~~~~~^~~~~
vim +761 drivers/pinctrl/pinctrl-equilibrium.c
702
703 static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata)
704 {
705 struct device *dev = drvdata->dev;
706 struct device_node *node = dev->of_node;
707 unsigned int *pinmux, pin_id, pinmux_id;
708 struct pingroup group, *grp = &group;
709 struct device_node *np;
710 struct property *prop;
711 int j, err;
712
713 for_each_child_of_node(node, np) {
714 prop = of_find_property(np, "groups", NULL);
715 if (!prop)
716 continue;
717
718 grp->npins = of_property_count_u32_elems(np, "pins");
719 if (grp->npins < 0) {
720 dev_err(dev, "No pins in the group: %s\n", prop->name);
721 of_node_put(np);
722 return -EINVAL;
723 }
724 grp->name = prop->value;
725 grp->pins = devm_kcalloc(dev, grp->npins, sizeof(*grp->pins), GFP_KERNEL);
726 if (!grp->pins) {
727 of_node_put(np);
728 return -ENOMEM;
729 }
730
731 pinmux = devm_kcalloc(dev, grp->npins, sizeof(*pinmux), GFP_KERNEL);
732 if (!pinmux) {
733 of_node_put(np);
734 return -ENOMEM;
735 }
736
737 for (j = 0; j < grp->npins; j++) {
738 if (of_property_read_u32_index(np, "pins", j, &pin_id)) {
739 dev_err(dev, "Group %s: Read intel pins id failed\n",
740 grp->name);
741 of_node_put(np);
742 return -EINVAL;
743 }
744 if (pin_id >= drvdata->pctl_desc.npins) {
745 dev_err(dev, "Group %s: Invalid pin ID, idx: %d, pin %u\n",
746 grp->name, j, pin_id);
747 of_node_put(np);
748 return -EINVAL;
749 }
750 grp->pins[j] = pin_id;
751 if (of_property_read_u32_index(np, "pinmux", j, &pinmux_id)) {
752 dev_err(dev, "Group %s: Read intel pinmux id failed\n",
753 grp->name);
754 of_node_put(np);
755 return -EINVAL;
756 }
757 pinmux[j] = pinmux_id;
758 }
759
760 err = pinctrl_generic_add_group(drvdata->pctl_dev, grp->name,
> 761 grp->pins, grp->num_pins,
762 pinmux);
763 if (err < 0) {
764 dev_err(dev, "Failed to register group %s\n", grp->name);
765 of_node_put(np);
766 return err;
767 }
768 memset(&group, 0, sizeof(group));
769 pinmux = NULL;
770 }
771
772 return 0;
773 }
774
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
"Jianlong Huang" <jianlong.huang@starfivetech.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sean Wang" <sean.wang@kernel.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH v1 01/17] pinctrl: equilibrium: Convert to use struct pingroup
Date: Thu, 23 Nov 2023 11:11:25 +0800 [thread overview]
Message-ID: <202311230820.MGDyVHJW-lkp@intel.com> (raw)
In-Reply-To: <20231122164040.2262742-2-andriy.shevchenko@linux.intel.com>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next geert-renesas-drivers/renesas-pinctrl pinctrl-samsung/for-next linus/master v6.7-rc2 next-20231122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-equilibrium-Convert-to-use-struct-pingroup/20231123-005932
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20231122164040.2262742-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 01/17] pinctrl: equilibrium: Convert to use struct pingroup
config: i386-randconfig-001-20231123 (https://download.01.org/0day-ci/archive/20231123/202311230820.MGDyVHJW-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231123/202311230820.MGDyVHJW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311230820.MGDyVHJW-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pinctrl/pinctrl-equilibrium.c: In function 'eqbr_build_groups':
drivers/pinctrl/pinctrl-equilibrium.c:750:17: error: assignment of read-only location '*(grp->pins + (sizetype)((unsigned int)j * 4))'
750 | grp->pins[j] = pin_id;
| ^
drivers/pinctrl/pinctrl-equilibrium.c:761:23: error: 'struct pingroup' has no member named 'num_pins'; did you mean 'npins'?
761 | grp->pins, grp->num_pins,
| ^~~~~~~~
| npins
>> drivers/pinctrl/pinctrl-equilibrium.c:761:10: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
761 | grp->pins, grp->num_pins,
| ~~~^~~~~~
In file included from drivers/pinctrl/pinctrl-equilibrium.c:16:
drivers/pinctrl/core.h:225:15: note: expected 'int *' but argument is of type 'const unsigned int *'
225 | int *gpins, int ngpins, void *data);
| ~~~~~^~~~~
vim +761 drivers/pinctrl/pinctrl-equilibrium.c
702
703 static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata)
704 {
705 struct device *dev = drvdata->dev;
706 struct device_node *node = dev->of_node;
707 unsigned int *pinmux, pin_id, pinmux_id;
708 struct pingroup group, *grp = &group;
709 struct device_node *np;
710 struct property *prop;
711 int j, err;
712
713 for_each_child_of_node(node, np) {
714 prop = of_find_property(np, "groups", NULL);
715 if (!prop)
716 continue;
717
718 grp->npins = of_property_count_u32_elems(np, "pins");
719 if (grp->npins < 0) {
720 dev_err(dev, "No pins in the group: %s\n", prop->name);
721 of_node_put(np);
722 return -EINVAL;
723 }
724 grp->name = prop->value;
725 grp->pins = devm_kcalloc(dev, grp->npins, sizeof(*grp->pins), GFP_KERNEL);
726 if (!grp->pins) {
727 of_node_put(np);
728 return -ENOMEM;
729 }
730
731 pinmux = devm_kcalloc(dev, grp->npins, sizeof(*pinmux), GFP_KERNEL);
732 if (!pinmux) {
733 of_node_put(np);
734 return -ENOMEM;
735 }
736
737 for (j = 0; j < grp->npins; j++) {
738 if (of_property_read_u32_index(np, "pins", j, &pin_id)) {
739 dev_err(dev, "Group %s: Read intel pins id failed\n",
740 grp->name);
741 of_node_put(np);
742 return -EINVAL;
743 }
744 if (pin_id >= drvdata->pctl_desc.npins) {
745 dev_err(dev, "Group %s: Invalid pin ID, idx: %d, pin %u\n",
746 grp->name, j, pin_id);
747 of_node_put(np);
748 return -EINVAL;
749 }
750 grp->pins[j] = pin_id;
751 if (of_property_read_u32_index(np, "pinmux", j, &pinmux_id)) {
752 dev_err(dev, "Group %s: Read intel pinmux id failed\n",
753 grp->name);
754 of_node_put(np);
755 return -EINVAL;
756 }
757 pinmux[j] = pinmux_id;
758 }
759
760 err = pinctrl_generic_add_group(drvdata->pctl_dev, grp->name,
> 761 grp->pins, grp->num_pins,
762 pinmux);
763 if (err < 0) {
764 dev_err(dev, "Failed to register group %s\n", grp->name);
765 of_node_put(np);
766 return err;
767 }
768 memset(&group, 0, sizeof(group));
769 pinmux = NULL;
770 }
771
772 return 0;
773 }
774
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-23 3:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 16:35 [PATCH v1 00/17] pinctrl: Convert struct group_desc to use struct pingroup Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 01/17] pinctrl: equilibrium: Convert " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-23 3:11 ` kernel test robot
2023-11-23 3:11 ` kernel test robot
2023-11-23 3:11 ` kernel test robot [this message]
2023-11-23 3:11 ` kernel test robot
2023-11-22 16:35 ` [PATCH v1 02/17] pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP() Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-23 11:11 ` J. Neuschäfer
2023-11-23 11:11 ` J. Neuschäfer
2023-11-23 11:11 ` J. Neuschäfer
2023-11-22 16:35 ` [PATCH v1 03/17] pinctrl: qcom: lpass-lpi: Replace kernel.h with what is being used Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 04/17] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 05/17] pinctrl: core: Add a convenient define PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 06/17] pinctrl: ingenic: Make use of PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 07/17] pinctrl: mediatek: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 08/17] pinctrl: core: Embed struct pingroup into struct group_desc Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-23 3:11 ` kernel test robot
2023-11-23 3:11 ` kernel test robot
2023-11-22 16:35 ` [PATCH v1 09/17] pinctrl: bcm: Convert to use grp member Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 10/17] pinctrl: equilibrium: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 11/17] pinctrl: imx: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 12/17] pinctrl: ingenic: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 13/17] pinctrl: keembay: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 14/17] pinctrl: mediatek: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 15/17] pinctrl: renesas: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 16/17] pinctrl: starfive: " Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-22 16:35 ` [PATCH v1 17/17] pinctrl: core: Remove unused members from struct group_desc Andy Shevchenko
2023-11-22 16:35 ` Andy Shevchenko
2023-11-23 11:10 ` [PATCH v1 00/17] pinctrl: Convert struct group_desc to use struct pingroup J. Neuschäfer
2023-11-23 11:10 ` J. Neuschäfer
2023-11-23 11:10 ` J. Neuschäfer
2023-11-23 16:09 ` Andy Shevchenko
2023-11-23 16:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311230820.MGDyVHJW-lkp@intel.com \
--to=lkp@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=j.neuschaefer@gmx.net \
--cc=jianlong.huang@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=openbmc@lists.ozlabs.org \
--cc=ping.bai@nxp.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=sean.wang@kernel.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.