From: Paul Elder <paul.elder@ideasonboard.com>
To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com,
umang.jain@ideasonboard.com,
Paul Elder <paul.elder@ideasonboard.com>,
Dafna Hirschfeld <dafna@fastmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Rockchip SoC support),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] media: rkisp1: regs: Consolidate MI interrupt wrap fields
Date: Wed, 29 Nov 2023 18:29:54 +0900 [thread overview]
Message-ID: <20231129092956.250129-2-paul.elder@ideasonboard.com> (raw)
In-Reply-To: <20231129092956.250129-1-paul.elder@ideasonboard.com>
Consolidate the wraparound fields in the memory interface interrupt
status registers, so that it can be more succinctly expressed by taking
the stream ID (main or self) as a parameter.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
index 350f452e676f..bea69a0d766a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
@@ -172,12 +172,9 @@
#define RKISP1_CIF_MI_FRAME(stream) BIT((stream)->id)
#define RKISP1_CIF_MI_MBLK_LINE BIT(2)
#define RKISP1_CIF_MI_FILL_MP_Y BIT(3)
-#define RKISP1_CIF_MI_WRAP_MP_Y BIT(4)
-#define RKISP1_CIF_MI_WRAP_MP_CB BIT(5)
-#define RKISP1_CIF_MI_WRAP_MP_CR BIT(6)
-#define RKISP1_CIF_MI_WRAP_SP_Y BIT(7)
-#define RKISP1_CIF_MI_WRAP_SP_CB BIT(8)
-#define RKISP1_CIF_MI_WRAP_SP_CR BIT(9)
+#define RKISP1_CIF_MI_WRAP_Y(stream) BIT(4 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CB(stream) BIT(5 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CR(stream) BIT(6 + (stream)->id * 3)
#define RKISP1_CIF_MI_DMA_READY BIT(11)
/* MI_STATUS */
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Paul Elder <paul.elder@ideasonboard.com>
To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com,
umang.jain@ideasonboard.com,
Paul Elder <paul.elder@ideasonboard.com>,
Dafna Hirschfeld <dafna@fastmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Rockchip SoC support),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] media: rkisp1: regs: Consolidate MI interrupt wrap fields
Date: Wed, 29 Nov 2023 18:29:54 +0900 [thread overview]
Message-ID: <20231129092956.250129-2-paul.elder@ideasonboard.com> (raw)
In-Reply-To: <20231129092956.250129-1-paul.elder@ideasonboard.com>
Consolidate the wraparound fields in the memory interface interrupt
status registers, so that it can be more succinctly expressed by taking
the stream ID (main or self) as a parameter.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
index 350f452e676f..bea69a0d766a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
@@ -172,12 +172,9 @@
#define RKISP1_CIF_MI_FRAME(stream) BIT((stream)->id)
#define RKISP1_CIF_MI_MBLK_LINE BIT(2)
#define RKISP1_CIF_MI_FILL_MP_Y BIT(3)
-#define RKISP1_CIF_MI_WRAP_MP_Y BIT(4)
-#define RKISP1_CIF_MI_WRAP_MP_CB BIT(5)
-#define RKISP1_CIF_MI_WRAP_MP_CR BIT(6)
-#define RKISP1_CIF_MI_WRAP_SP_Y BIT(7)
-#define RKISP1_CIF_MI_WRAP_SP_CB BIT(8)
-#define RKISP1_CIF_MI_WRAP_SP_CR BIT(9)
+#define RKISP1_CIF_MI_WRAP_Y(stream) BIT(4 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CB(stream) BIT(5 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CR(stream) BIT(6 + (stream)->id * 3)
#define RKISP1_CIF_MI_DMA_READY BIT(11)
/* MI_STATUS */
--
2.39.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Paul Elder <paul.elder@ideasonboard.com>
To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com,
umang.jain@ideasonboard.com,
Paul Elder <paul.elder@ideasonboard.com>,
Dafna Hirschfeld <dafna@fastmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Rockchip SoC support),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] media: rkisp1: regs: Consolidate MI interrupt wrap fields
Date: Wed, 29 Nov 2023 18:29:54 +0900 [thread overview]
Message-ID: <20231129092956.250129-2-paul.elder@ideasonboard.com> (raw)
In-Reply-To: <20231129092956.250129-1-paul.elder@ideasonboard.com>
Consolidate the wraparound fields in the memory interface interrupt
status registers, so that it can be more succinctly expressed by taking
the stream ID (main or self) as a parameter.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
index 350f452e676f..bea69a0d766a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
@@ -172,12 +172,9 @@
#define RKISP1_CIF_MI_FRAME(stream) BIT((stream)->id)
#define RKISP1_CIF_MI_MBLK_LINE BIT(2)
#define RKISP1_CIF_MI_FILL_MP_Y BIT(3)
-#define RKISP1_CIF_MI_WRAP_MP_Y BIT(4)
-#define RKISP1_CIF_MI_WRAP_MP_CB BIT(5)
-#define RKISP1_CIF_MI_WRAP_MP_CR BIT(6)
-#define RKISP1_CIF_MI_WRAP_SP_Y BIT(7)
-#define RKISP1_CIF_MI_WRAP_SP_CB BIT(8)
-#define RKISP1_CIF_MI_WRAP_SP_CR BIT(9)
+#define RKISP1_CIF_MI_WRAP_Y(stream) BIT(4 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CB(stream) BIT(5 + (stream)->id * 3)
+#define RKISP1_CIF_MI_WRAP_CR(stream) BIT(6 + (stream)->id * 3)
#define RKISP1_CIF_MI_DMA_READY BIT(11)
/* MI_STATUS */
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-29 9:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:29 [PATCH 0/3] media: rkisp1: Misc fixes and debug Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 9:29 ` Paul Elder [this message]
2023-11-29 9:29 ` [PATCH 1/3] media: rkisp1: regs: Consolidate MI interrupt wrap fields Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 20:03 ` Kieran Bingham
2023-11-29 20:03 ` Kieran Bingham
2023-11-29 20:03 ` Kieran Bingham
2023-11-30 13:45 ` Laurent Pinchart
2023-11-30 13:45 ` Laurent Pinchart
2023-11-30 13:45 ` Laurent Pinchart
2023-11-29 9:29 ` [PATCH 2/3] media: rkisp1: debug: Add register dump for IS Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 11:00 ` Alexander Stein
2023-11-29 11:00 ` Alexander Stein
2023-11-29 11:00 ` Alexander Stein
2023-11-29 20:05 ` Kieran Bingham
2023-11-29 20:05 ` Kieran Bingham
2023-11-29 20:05 ` Kieran Bingham
2023-11-30 9:47 ` Paul Elder
2023-11-30 9:47 ` Paul Elder
2023-11-30 9:47 ` Paul Elder
2023-11-30 9:54 ` Alexander Stein
2023-11-30 9:54 ` Alexander Stein
2023-11-30 9:54 ` Alexander Stein
2023-11-30 10:18 ` Tommaso Merciai
2023-11-30 10:18 ` Tommaso Merciai
2023-11-30 10:18 ` Tommaso Merciai
2023-11-30 11:33 ` Paul Elder
2023-11-30 11:33 ` Paul Elder
2023-11-30 11:33 ` Paul Elder
2023-11-30 13:42 ` Laurent Pinchart
2023-11-30 13:42 ` Laurent Pinchart
2023-11-30 13:42 ` Laurent Pinchart
2023-11-29 9:29 ` [PATCH 3/3] media: rkisp1: debug: Count completed frame interrupts Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 9:29 ` Paul Elder
2023-11-29 11:01 ` Alexander Stein
2023-11-29 11:01 ` Alexander Stein
2023-11-29 11:01 ` Alexander Stein
2023-11-29 20:06 ` Kieran Bingham
2023-11-29 20:06 ` Kieran Bingham
2023-11-29 20:06 ` Kieran Bingham
2023-11-30 13:54 ` Laurent Pinchart
2023-11-30 13:54 ` Laurent Pinchart
2023-11-30 13:54 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129092956.250129-2-paul.elder@ideasonboard.com \
--to=paul.elder@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.