From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: <hdegoede@redhat.com>, <markgross@kernel.org>,
<ilpo.jarvinen@linux.intel.com>, <basavaraj.natikar@amd.com>,
<jikos@kernel.org>, <benjamin.tissoires@redhat.com>
Cc: <Patil.Reddy@amd.com>, <mario.limonciello@amd.com>,
<platform-driver-x86@vger.kernel.org>,
<linux-input@vger.kernel.org>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH v7 12/12] platform/x86/amd/pmf: dump policy binary data
Date: Tue, 12 Dec 2023 07:17:05 +0530 [thread overview]
Message-ID: <20231212014705.2017474-13-Shyam-sundar.S-k@amd.com> (raw)
In-Reply-To: <20231212014705.2017474-1-Shyam-sundar.S-k@amd.com>
Sometimes policy binary retrieved from the BIOS maybe incorrect that can
end up in failing to enable the Smart PC solution feature.
Use print_hex_dump_debug() to dump the policy binary in hex, so that we
debug the issues related to the binary even before sending that to TA.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
drivers/platform/x86/amd/pmf/tee-if.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
index cf95251741c7..9a4757f4f521 100644
--- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform/x86/amd/pmf/tee-if.c
@@ -276,6 +276,12 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev)
}
#ifdef CONFIG_AMD_PMF_DEBUG
+static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev)
+{
+ print_hex_dump_debug("(pb): ", DUMP_PREFIX_OFFSET, 16, 1, dev->policy_buf,
+ dev->policy_sz, false);
+}
+
static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf,
size_t length, loff_t *pos)
{
@@ -296,6 +302,7 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf,
if (copy_from_user(dev->policy_buf, buf, dev->policy_sz))
return -EFAULT;
+ amd_pmf_hex_dump_pb(dev);
ret = amd_pmf_start_policy_engine(dev);
if (ret)
return -EINVAL;
@@ -321,6 +328,7 @@ static void amd_pmf_remove_pb(struct amd_pmf_dev *dev)
#else
static void amd_pmf_open_pb(struct amd_pmf_dev *dev, struct dentry *debugfs_root) {}
static void amd_pmf_remove_pb(struct amd_pmf_dev *dev) {}
+static void amd_pmf_hex_dump_pb(struct amd_pmf_dev *dev) {}
#endif
static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev)
@@ -335,6 +343,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev)
memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz);
+ amd_pmf_hex_dump_pb(dev);
if (pb_side_load)
amd_pmf_open_pb(dev, dev->dbgfs_dir);
--
2.25.1
next prev parent reply other threads:[~2023-12-12 1:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 1:46 [PATCH v7 00/12] Introduce PMF Smart PC Solution Builder Feature Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 01/12] platform/x86/amd/pmf: Add PMF TEE interface Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 02/12] platform/x86/amd/pmf: Add support for PMF-TA interaction Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 03/12] platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr() Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 04/12] platform/x86/amd/pmf: Add support for PMF Policy Binary Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 05/12] platform/x86/amd/pmf: change amd_pmf_init_features() call sequence Shyam Sundar S K
2023-12-12 1:46 ` [PATCH v7 06/12] platform/x86/amd/pmf: Add support to get inputs from other subsystems Shyam Sundar S K
2023-12-12 1:47 ` [PATCH v7 07/12] platform/x86/amd/pmf: Add support update p3t limit Shyam Sundar S K
2023-12-12 1:47 ` [PATCH v7 08/12] platform/x86/amd/pmf: Add support to update system state Shyam Sundar S K
2023-12-12 1:47 ` [PATCH v7 09/12] platform/x86/amd/pmf: Make source_as_str() as non-static Shyam Sundar S K
2023-12-12 1:47 ` [PATCH v7 10/12] platform/x86/amd/pmf: Add facility to dump TA inputs Shyam Sundar S K
2023-12-12 1:47 ` [PATCH v7 11/12] platform/x86/amd/pmf: Add capability to sideload of policy binary Shyam Sundar S K
2023-12-18 11:58 ` Hans de Goede
2023-12-12 1:47 ` Shyam Sundar S K [this message]
2023-12-18 12:05 ` [PATCH v7 00/12] Introduce PMF Smart PC Solution Builder Feature Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212014705.2017474-13-Shyam-sundar.S-k@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Patil.Reddy@amd.com \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.