From: Andre Przywara <andre.przywara@arm.com> To: Maxim Kiselev <bigunclemax@gmail.com> Cc: anarsoul@gmail.com, bob@electricworry.net, conor+dt@kernel.org, daniel.lezcano@linaro.org, devicetree@vger.kernel.org, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, lukasz.luba@arm.com, martin.botka@somainline.org, rafael@kernel.org, robh+dt@kernel.org, rui.zhang@intel.com, samuel@sholland.org, tiny.windzz@gmail.com, wens@csie.org Subject: Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Date: Thu, 14 Dec 2023 09:59:14 +0000 [thread overview] Message-ID: <20231214095914.4a98ba8c@donnerap.manchester.arm.com> (raw) In-Reply-To: <CALHCpMjz4YiE_=6Cxq7RqF_3qPaw8UCA=6eLy9ZZuofRhr7mcA@mail.gmail.com> On Tue, 12 Dec 2023 21:09:45 +0300 Maxim Kiselev <bigunclemax@gmail.com> wrote: Hi Maksim, sorry for the delay. > пн, 11 дек. 2023 г. в 02:48, Andre Przywara <andre.przywara@arm.com>: > > > > On Sat, 9 Dec 2023 13:44:34 +0300 > > Maksim Kiselev <bigunclemax@gmail.com> wrote: > > > > Hi Maksim, > > > > > Hi Martin, Andre. > > > > > > May I inquire? Why do we need a separate sun50i_h616_ths_calibrate() > > > function? Why can't we just extend an existing sun50i_h6_ths_calibrate()? > > > > > > At my glance the calculations in both functions are the same. We just > > > need to handle a special case for the 4th sensor. > > > > You seem to be right, they are indeed the same, just written slightly > > differently. Do you already have any patches that unify that? > > No, I don't have any patches for that yet. But I can do it if you told > me where to > send the patch. Should I put it here as a reply? Can you make one patch on top of mainline, that prepares the existing sun50i_h6_ths_calibrate() function to deal with four sensors? I would then include this patch of yours in the next submission, and put Martin's H616 patch (now probably just the struct ths_thermal_chip) on top then. Please send this patch just to the list (CC:ing people like Martin and me), starting a new thread. Many thanks, Andre > > I don't know if Martin or I find time to do it this week, but we could > > also optimise this later. > > > > Cheers, > > Andre > > Best regards, > Maksim
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Maxim Kiselev <bigunclemax@gmail.com> Cc: anarsoul@gmail.com, bob@electricworry.net, conor+dt@kernel.org, daniel.lezcano@linaro.org, devicetree@vger.kernel.org, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, lukasz.luba@arm.com, martin.botka@somainline.org, rafael@kernel.org, robh+dt@kernel.org, rui.zhang@intel.com, samuel@sholland.org, tiny.windzz@gmail.com, wens@csie.org Subject: Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Date: Thu, 14 Dec 2023 09:59:14 +0000 [thread overview] Message-ID: <20231214095914.4a98ba8c@donnerap.manchester.arm.com> (raw) In-Reply-To: <CALHCpMjz4YiE_=6Cxq7RqF_3qPaw8UCA=6eLy9ZZuofRhr7mcA@mail.gmail.com> On Tue, 12 Dec 2023 21:09:45 +0300 Maxim Kiselev <bigunclemax@gmail.com> wrote: Hi Maksim, sorry for the delay. > пн, 11 дек. 2023 г. в 02:48, Andre Przywara <andre.przywara@arm.com>: > > > > On Sat, 9 Dec 2023 13:44:34 +0300 > > Maksim Kiselev <bigunclemax@gmail.com> wrote: > > > > Hi Maksim, > > > > > Hi Martin, Andre. > > > > > > May I inquire? Why do we need a separate sun50i_h616_ths_calibrate() > > > function? Why can't we just extend an existing sun50i_h6_ths_calibrate()? > > > > > > At my glance the calculations in both functions are the same. We just > > > need to handle a special case for the 4th sensor. > > > > You seem to be right, they are indeed the same, just written slightly > > differently. Do you already have any patches that unify that? > > No, I don't have any patches for that yet. But I can do it if you told > me where to > send the patch. Should I put it here as a reply? Can you make one patch on top of mainline, that prepares the existing sun50i_h6_ths_calibrate() function to deal with four sensors? I would then include this patch of yours in the next submission, and put Martin's H616 patch (now probably just the struct ths_thermal_chip) on top then. Please send this patch just to the list (CC:ing people like Martin and me), starting a new thread. Many thanks, Andre > > I don't know if Martin or I find time to do it this week, but we could > > also optimise this later. > > > > Cheers, > > Andre > > Best regards, > Maksim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-14 9:59 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-28 0:58 [PATCH v3 0/6] Add support for H616 Thermal system Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-11-28 0:58 ` [PATCH v3 1/6] soc: sunxi: sram: export register 0 for THS on H616 Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-11-28 0:58 ` [PATCH v3 2/6] dt-bindings: thermal: sun8i: Add H616 THS controller Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-11-28 7:41 ` Krzysztof Kozlowski 2023-11-28 7:41 ` Krzysztof Kozlowski 2023-11-28 0:58 ` [PATCH v3 3/6] thermal: sun8i: explain unknown H6 register value Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-11-28 0:58 ` [PATCH v3 4/6] thermal: sun8i: add syscon register access code Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-11-28 7:43 ` Krzysztof Kozlowski 2023-11-28 7:43 ` Krzysztof Kozlowski 2023-11-28 7:50 ` Chen-Yu Tsai 2023-11-28 7:50 ` Chen-Yu Tsai 2023-11-28 8:29 ` Krzysztof Kozlowski 2023-11-28 8:29 ` Krzysztof Kozlowski 2023-11-28 8:59 ` Chen-Yu Tsai 2023-11-28 8:59 ` Chen-Yu Tsai 2023-11-28 9:02 ` Chen-Yu Tsai 2023-11-28 9:02 ` Chen-Yu Tsai 2023-11-28 9:09 ` Chen-Yu Tsai 2023-11-28 9:09 ` Chen-Yu Tsai 2023-11-28 9:13 ` Krzysztof Kozlowski 2023-11-28 9:13 ` Krzysztof Kozlowski 2023-11-28 14:11 ` Krzysztof Kozlowski 2023-11-28 14:11 ` Krzysztof Kozlowski 2023-11-28 14:33 ` Andre Przywara 2023-11-28 14:33 ` Andre Przywara 2023-11-28 14:48 ` Krzysztof Kozlowski 2023-11-28 14:48 ` Krzysztof Kozlowski 2023-11-28 16:10 ` Andre Przywara 2023-11-28 16:10 ` Andre Przywara 2023-11-28 16:39 ` Chen-Yu Tsai 2023-11-28 16:39 ` Chen-Yu Tsai 2023-11-28 16:50 ` Rob Herring 2023-11-28 16:50 ` Rob Herring 2023-11-29 17:03 ` Andre Przywara 2023-11-29 17:03 ` Andre Przywara 2023-11-29 17:09 ` Chen-Yu Tsai 2023-11-29 17:09 ` Chen-Yu Tsai 2023-11-28 0:58 ` [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-12-09 10:44 ` Maksim Kiselev 2023-12-09 10:44 ` Maksim Kiselev 2023-12-11 0:05 ` Andre Przywara 2023-12-11 0:05 ` Andre Przywara 2023-12-12 18:09 ` Maxim Kiselev 2023-12-12 18:09 ` Maxim Kiselev 2023-12-14 9:59 ` Andre Przywara [this message] 2023-12-14 9:59 ` Andre Przywara 2023-12-17 14:16 ` Maxim Kiselev 2023-12-17 14:16 ` Maxim Kiselev 2023-11-28 0:58 ` [PATCH v3 6/6] arm64: dts: allwinner: h616: Add thermal sensor and zones Andre Przywara 2023-11-28 0:58 ` Andre Przywara 2023-12-13 9:41 [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Maxim Kiselev 2023-12-14 9:59 ` Andre Przywara 2023-12-14 9:59 ` Andre Przywara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231214095914.4a98ba8c@donnerap.manchester.arm.com \ --to=andre.przywara@arm.com \ --cc=anarsoul@gmail.com \ --cc=bigunclemax@gmail.com \ --cc=bob@electricworry.net \ --cc=conor+dt@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=lukasz.luba@arm.com \ --cc=martin.botka@somainline.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=samuel@sholland.org \ --cc=tiny.windzz@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.