From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: Davidlohr Bueso <dave@stgolabs.net> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Fan Ni <fan.ni@samsung.com>, "Michael S . Tsirkin" <mst@redhat.com>, <linux-cxl@vger.kernel.org>, <qemu-devel@nongnu.org> Subject: Re: [PATCH v2 4/4] hw/cxl/events: discard all event records during sanitation Date: Tue, 9 Jan 2024 17:55:54 +0000 [thread overview] Message-ID: <20240109175554.0000467f@Huawei.com> (raw) In-Reply-To: <20240101213828.nxayq6ps3azk2eic@offworld> On Mon, 1 Jan 2024 13:38:28 -0800 Davidlohr Bueso <dave@stgolabs.net> wrote: > On Fri, 22 Dec 2023, Hyeonggon Yoo wrote: > > >Per spec 8.2.9.9.5.1 Sanitize (Opcode 4400h), sanitize command should > >delete all event logs. Introduce cxl_discard_all_event_logs() and call > >this in __do_sanitization(). > > lgtm > > Reviewed-by: Davidlohr Bueso <dave@stgolabs.net> I'll carry this on my tree on top of where I put the previous patch. Seems to apply there at least :) If it makes sense to remix these patches a bit to provide cleaner history I'll do so once these are ready to send for Michael to look at. Jonathan > > >Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >--- > > hw/cxl/cxl-events.c | 13 +++++++++++++ > > hw/cxl/cxl-mailbox-utils.c | 1 + > > include/hw/cxl/cxl_device.h | 1 + > > 3 files changed, 15 insertions(+) > > > >diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > >index bee6dfaf14..837b18ab47 100644 > >--- a/hw/cxl/cxl-events.c > >+++ b/hw/cxl/cxl-events.c > >@@ -141,6 +141,19 @@ bool cxl_event_insert(CXLDeviceState *cxlds, CXLEventLogType log_type, > > return cxl_event_count(log) == 1; > > } > > > >+void cxl_discard_all_event_records(CXLDeviceState *cxlds) > >+{ > >+ CXLEventLogType log_type; > >+ CXLEventLog *log; > >+ > >+ for (log_type = 0; log_type < CXL_EVENT_TYPE_MAX; log_type++) { > >+ log = &cxlds->event_logs[log_type]; > >+ while (!cxl_event_empty(log)) { > >+ cxl_event_delete_head(cxlds, log_type, log); > >+ } > >+ } > >+} > >+ > > CXLRetCode cxl_event_get_records(CXLDeviceState *cxlds, CXLGetEventPayload *pl, > > uint8_t log_type, int max_recs, > > size_t *len) > >diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c > >index efeb5f8174..2ade351d82 100644 > >--- a/hw/cxl/cxl-mailbox-utils.c > >+++ b/hw/cxl/cxl-mailbox-utils.c > >@@ -1150,6 +1150,7 @@ static void __do_sanitization(CXLType3Dev *ct3d) > > memset(lsa, 0, memory_region_size(mr)); > > } > > } > >+ cxl_discard_all_event_records(&ct3d->cxl_dstate); > > } > > > > /* > >diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > >index 5618061ebe..8f05dd9beb 100644 > >--- a/include/hw/cxl/cxl_device.h > >+++ b/include/hw/cxl/cxl_device.h > >@@ -604,6 +604,7 @@ CXLRetCode cxl_event_get_records(CXLDeviceState *cxlds, CXLGetEventPayload *pl, > > size_t *len); > > CXLRetCode cxl_event_clear_records(CXLDeviceState *cxlds, > > CXLClearEventPayload *pl); > >+void cxl_discard_all_event_records(CXLDeviceState *cxlds); > > > > void cxl_event_irq_assert(CXLType3Dev *ct3d); > > > >-- > >2.39.3 > >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org> To: Davidlohr Bueso <dave@stgolabs.net> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Fan Ni <fan.ni@samsung.com>, "Michael S . Tsirkin" <mst@redhat.com>, <linux-cxl@vger.kernel.org>, <qemu-devel@nongnu.org> Subject: Re: [PATCH v2 4/4] hw/cxl/events: discard all event records during sanitation Date: Tue, 9 Jan 2024 17:55:54 +0000 [thread overview] Message-ID: <20240109175554.0000467f@Huawei.com> (raw) In-Reply-To: <20240101213828.nxayq6ps3azk2eic@offworld> On Mon, 1 Jan 2024 13:38:28 -0800 Davidlohr Bueso <dave@stgolabs.net> wrote: > On Fri, 22 Dec 2023, Hyeonggon Yoo wrote: > > >Per spec 8.2.9.9.5.1 Sanitize (Opcode 4400h), sanitize command should > >delete all event logs. Introduce cxl_discard_all_event_logs() and call > >this in __do_sanitization(). > > lgtm > > Reviewed-by: Davidlohr Bueso <dave@stgolabs.net> I'll carry this on my tree on top of where I put the previous patch. Seems to apply there at least :) If it makes sense to remix these patches a bit to provide cleaner history I'll do so once these are ready to send for Michael to look at. Jonathan > > >Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >--- > > hw/cxl/cxl-events.c | 13 +++++++++++++ > > hw/cxl/cxl-mailbox-utils.c | 1 + > > include/hw/cxl/cxl_device.h | 1 + > > 3 files changed, 15 insertions(+) > > > >diff --git a/hw/cxl/cxl-events.c b/hw/cxl/cxl-events.c > >index bee6dfaf14..837b18ab47 100644 > >--- a/hw/cxl/cxl-events.c > >+++ b/hw/cxl/cxl-events.c > >@@ -141,6 +141,19 @@ bool cxl_event_insert(CXLDeviceState *cxlds, CXLEventLogType log_type, > > return cxl_event_count(log) == 1; > > } > > > >+void cxl_discard_all_event_records(CXLDeviceState *cxlds) > >+{ > >+ CXLEventLogType log_type; > >+ CXLEventLog *log; > >+ > >+ for (log_type = 0; log_type < CXL_EVENT_TYPE_MAX; log_type++) { > >+ log = &cxlds->event_logs[log_type]; > >+ while (!cxl_event_empty(log)) { > >+ cxl_event_delete_head(cxlds, log_type, log); > >+ } > >+ } > >+} > >+ > > CXLRetCode cxl_event_get_records(CXLDeviceState *cxlds, CXLGetEventPayload *pl, > > uint8_t log_type, int max_recs, > > size_t *len) > >diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c > >index efeb5f8174..2ade351d82 100644 > >--- a/hw/cxl/cxl-mailbox-utils.c > >+++ b/hw/cxl/cxl-mailbox-utils.c > >@@ -1150,6 +1150,7 @@ static void __do_sanitization(CXLType3Dev *ct3d) > > memset(lsa, 0, memory_region_size(mr)); > > } > > } > >+ cxl_discard_all_event_records(&ct3d->cxl_dstate); > > } > > > > /* > >diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h > >index 5618061ebe..8f05dd9beb 100644 > >--- a/include/hw/cxl/cxl_device.h > >+++ b/include/hw/cxl/cxl_device.h > >@@ -604,6 +604,7 @@ CXLRetCode cxl_event_get_records(CXLDeviceState *cxlds, CXLGetEventPayload *pl, > > size_t *len); > > CXLRetCode cxl_event_clear_records(CXLDeviceState *cxlds, > > CXLClearEventPayload *pl); > >+void cxl_discard_all_event_records(CXLDeviceState *cxlds); > > > > void cxl_event_irq_assert(CXLType3Dev *ct3d); > > > >-- > >2.39.3 > >
next prev parent reply other threads:[~2024-01-09 17:55 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-22 9:00 [PATCH v2 0/4] A Followup for "QEMU: CXL mailbox rework and features (Part 1)" Hyeonggon Yoo 2023-12-22 9:00 ` [PATCH v2 1/4] hw/cxl: fix build error in cxl_type3_stubs.c Hyeonggon Yoo 2024-01-09 17:40 ` Jonathan Cameron 2024-01-09 17:40 ` Jonathan Cameron via 2024-01-10 17:30 ` fan 2023-12-22 9:00 ` [PATCH v2 2/4] hw/cxl/device: read from register values in mdev_reg_read() Hyeonggon Yoo 2024-01-09 17:45 ` Jonathan Cameron 2024-01-09 17:45 ` Jonathan Cameron via 2024-01-11 12:32 ` Jonathan Cameron 2024-01-11 12:32 ` Jonathan Cameron via 2023-12-22 9:00 ` [PATCH v2 3/4] hw/cxl/mbox: replace sanitize_running() with cxl_dev_media_disabled() Hyeonggon Yoo 2024-01-09 17:53 ` Jonathan Cameron 2024-01-09 17:53 ` Jonathan Cameron via 2024-01-22 2:50 ` Hyeonggon Yoo 2024-04-01 18:44 ` Jonathan Cameron 2024-04-01 18:44 ` Jonathan Cameron via 2023-12-22 9:00 ` [PATCH v2 4/4] hw/cxl/events: discard all event records during sanitation Hyeonggon Yoo 2024-01-01 21:38 ` Davidlohr Bueso 2024-01-09 17:55 ` Jonathan Cameron [this message] 2024-01-09 17:55 ` Jonathan Cameron via
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240109175554.0000467f@Huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=42.hyeyoo@gmail.com \ --cc=dave@stgolabs.net \ --cc=fan.ni@samsung.com \ --cc=linux-cxl@vger.kernel.org \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.