From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J . Wong" <djwong@kernel.org>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Christian Koenig <christian.koenig@amd.com>,
Huang Rui <ray.huang@amd.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: disable large folios for shmem file used by xfs xfile
Date: Wed, 10 Jan 2024 07:38:43 -0800 [thread overview]
Message-ID: <20240110073843.d663fa6610785a8611b2cebe@linux-foundation.org> (raw)
In-Reply-To: <20240110092109.1950011-1-hch@lst.de>
On Wed, 10 Jan 2024 10:21:07 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> Darrick reported that the fairly new XFS xfile code blows up when force
> enabling large folio for shmem. This series fixes this quickly by disabling
> large folios for this particular shmem file for now until it can be fixed
> properly, which will be a lot more invasive.
>
Patches seems reasonable as a short-term only-affects-xfs thing.
I assume that kernels which contain 137db333b29186 ("xfs: teach xfile
to pass back direct-map pages to caller") want this, so a Fixes: that
and a cc:stable are appropriate?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J . Wong" <djwong@kernel.org>,
dri-devel@lists.freedesktop.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, Huang Rui <ray.huang@amd.com>,
x86@kernel.org, Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
intel-gfx@lists.freedesktop.org,
Maxime Ripard <mripard@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
linux-sgx@vger.kernel.org,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christian Koenig <christian.koenig@amd.com>,
Chandan Babu R <chandan.babu@oracle.com>
Subject: Re: disable large folios for shmem file used by xfs xfile
Date: Wed, 10 Jan 2024 07:38:43 -0800 [thread overview]
Message-ID: <20240110073843.d663fa6610785a8611b2cebe@linux-foundation.org> (raw)
In-Reply-To: <20240110092109.1950011-1-hch@lst.de>
On Wed, 10 Jan 2024 10:21:07 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> Darrick reported that the fairly new XFS xfile code blows up when force
> enabling large folio for shmem. This series fixes this quickly by disabling
> large folios for this particular shmem file for now until it can be fixed
> properly, which will be a lot more invasive.
>
Patches seems reasonable as a short-term only-affects-xfs thing.
I assume that kernels which contain 137db333b29186 ("xfs: teach xfile
to pass back direct-map pages to caller") want this, so a Fixes: that
and a cc:stable are appropriate?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J . Wong" <djwong@kernel.org>,
dri-devel@lists.freedesktop.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, Huang Rui <ray.huang@amd.com>,
David Airlie <airlied@gmail.com>,
x86@kernel.org, Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
intel-gfx@lists.freedesktop.org,
Maxime Ripard <mripard@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
linux-sgx@vger.kernel.org, Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
linux-fsdevel@vger.kernel.org,
Christian Koenig <christian.koenig@amd.com>,
Chandan Babu R <chandan.babu@oracle.com>
Subject: Re: disable large folios for shmem file used by xfs xfile
Date: Wed, 10 Jan 2024 07:38:43 -0800 [thread overview]
Message-ID: <20240110073843.d663fa6610785a8611b2cebe@linux-foundation.org> (raw)
In-Reply-To: <20240110092109.1950011-1-hch@lst.de>
On Wed, 10 Jan 2024 10:21:07 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> Darrick reported that the fairly new XFS xfile code blows up when force
> enabling large folio for shmem. This series fixes this quickly by disabling
> large folios for this particular shmem file for now until it can be fixed
> properly, which will be a lot more invasive.
>
Patches seems reasonable as a short-term only-affects-xfs thing.
I assume that kernels which contain 137db333b29186 ("xfs: teach xfile
to pass back direct-map pages to caller") want this, so a Fixes: that
and a cc:stable are appropriate?
next prev parent reply other threads:[~2024-01-10 15:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:21 disable large folios for shmem file used by xfs xfile Christoph Hellwig
2024-01-10 9:21 ` Christoph Hellwig
2024-01-10 9:21 ` [PATCH 1/2] mm: add a mapping_clear_large_folios helper Christoph Hellwig
2024-01-10 9:21 ` Christoph Hellwig
2024-01-10 9:21 ` [PATCH 2/2] xfs: disable large folio support in xfile_create Christoph Hellwig
2024-01-10 9:21 ` Christoph Hellwig
2024-01-10 17:55 ` Darrick J. Wong
2024-01-10 17:55 ` Darrick J. Wong
2024-01-10 17:55 ` Darrick J. Wong
2024-01-10 20:04 ` Darrick J. Wong
2024-01-10 20:04 ` Darrick J. Wong
2024-01-10 20:04 ` Darrick J. Wong
2024-01-11 22:00 ` Andrew Morton
2024-01-11 22:00 ` Andrew Morton
2024-01-11 22:00 ` Andrew Morton
2024-01-11 22:45 ` Matthew Wilcox
2024-01-11 22:45 ` Matthew Wilcox
2024-01-11 22:45 ` Matthew Wilcox
2024-01-12 2:22 ` Darrick J. Wong
2024-01-12 2:22 ` Darrick J. Wong
2024-01-12 2:22 ` Darrick J. Wong
2024-02-08 1:56 ` Andrew Morton
2024-02-08 16:03 ` Darrick J. Wong
2024-01-10 12:37 ` disable large folios for shmem file used by xfs xfile Matthew Wilcox
2024-01-10 12:37 ` Matthew Wilcox
2024-01-10 12:37 ` Matthew Wilcox
2024-01-10 15:20 ` Joonas Lahtinen
2024-01-10 15:20 ` Joonas Lahtinen
2024-01-10 15:20 ` Joonas Lahtinen
2024-01-10 15:28 ` Joonas Lahtinen
2024-01-10 15:28 ` Joonas Lahtinen
2024-01-10 15:28 ` Joonas Lahtinen
2024-01-10 15:34 ` Matthew Wilcox
2024-01-10 15:34 ` Matthew Wilcox
2024-01-10 15:34 ` Matthew Wilcox
2024-01-11 21:30 ` Daniel Gomez
2024-01-11 21:30 ` Daniel Gomez
2024-01-11 21:30 ` Daniel Gomez
2024-01-10 16:18 ` Christoph Hellwig
2024-01-10 16:18 ` Christoph Hellwig
2024-01-10 14:35 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] mm: add a mapping_clear_large_folios helper Patchwork
2024-01-10 14:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-10 14:54 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-10 15:38 ` Andrew Morton [this message]
2024-01-10 15:38 ` disable large folios for shmem file used by xfs xfile Andrew Morton
2024-01-10 15:38 ` Andrew Morton
2024-01-10 16:19 ` Christoph Hellwig
2024-01-10 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110073843.d663fa6610785a8611b2cebe@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=airlied@gmail.com \
--cc=chandan.babu@oracle.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ray.huang@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.