From: Alexander Stein <alexander.stein@ew.tq-group.com> To: Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/1] spi: spi-imx: Use dev_err_probe for failed DMA channel requests Date: Wed, 10 Jan 2024 09:54:03 +0100 [thread overview] Message-ID: <20240110085403.457089-1-alexander.stein@ew.tq-group.com> (raw) If dma_request_chan() fails, no error is shown nor any information is shown in /sys/kernel/debug/devices_deferred if -EPROBE_DEFER is returned. Use dev_err_probe to fix both problems. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Sorry, I lost sight of the replies from v1 series. I'll address Fabio's concern here instead. It's true that running spi-imx with SDMA is valid. But if provided DMA channels are not available, aka -EPROBE_DEFER, there is no information why so. This can simply be seen by disabling the sdma1 node on imx8mp: $ cat /sys/kernel/debug/devices_deferred 30820000.spi 30830000.spi 30840000.spi There is no indication what is wrong/missing here. There is also no fallback to pio mode. This patch addresses this by setting the defer probe reason. Changes in v2: * Rebase to next-20240110 [1] https://lore.kernel.org/all/CAOMZO5CcD5iDkaempdxnQHx1fAgnXAmMq_0MdEq5wNgOLHcMuw@mail.gmail.com/ drivers/spi/spi-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 272bc871a848b..546cdce525fc5 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1344,7 +1344,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(controller->dma_tx)) { ret = PTR_ERR(controller->dma_tx); - dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret); + dev_err_probe(dev, ret, "can't get the TX DMA channel!\n"); controller->dma_tx = NULL; goto err; } @@ -1353,7 +1353,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_rx = dma_request_chan(dev, "rx"); if (IS_ERR(controller->dma_rx)) { ret = PTR_ERR(controller->dma_rx); - dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret); + dev_err_probe(dev, ret, "can't get the RX DMA channel!\n"); controller->dma_rx = NULL; goto err; } -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com> To: Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/1] spi: spi-imx: Use dev_err_probe for failed DMA channel requests Date: Wed, 10 Jan 2024 09:54:03 +0100 [thread overview] Message-ID: <20240110085403.457089-1-alexander.stein@ew.tq-group.com> (raw) If dma_request_chan() fails, no error is shown nor any information is shown in /sys/kernel/debug/devices_deferred if -EPROBE_DEFER is returned. Use dev_err_probe to fix both problems. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Sorry, I lost sight of the replies from v1 series. I'll address Fabio's concern here instead. It's true that running spi-imx with SDMA is valid. But if provided DMA channels are not available, aka -EPROBE_DEFER, there is no information why so. This can simply be seen by disabling the sdma1 node on imx8mp: $ cat /sys/kernel/debug/devices_deferred 30820000.spi 30830000.spi 30840000.spi There is no indication what is wrong/missing here. There is also no fallback to pio mode. This patch addresses this by setting the defer probe reason. Changes in v2: * Rebase to next-20240110 [1] https://lore.kernel.org/all/CAOMZO5CcD5iDkaempdxnQHx1fAgnXAmMq_0MdEq5wNgOLHcMuw@mail.gmail.com/ drivers/spi/spi-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 272bc871a848b..546cdce525fc5 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1344,7 +1344,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(controller->dma_tx)) { ret = PTR_ERR(controller->dma_tx); - dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret); + dev_err_probe(dev, ret, "can't get the TX DMA channel!\n"); controller->dma_tx = NULL; goto err; } @@ -1353,7 +1353,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_rx = dma_request_chan(dev, "rx"); if (IS_ERR(controller->dma_rx)) { ret = PTR_ERR(controller->dma_rx); - dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret); + dev_err_probe(dev, ret, "can't get the RX DMA channel!\n"); controller->dma_rx = NULL; goto err; } -- 2.34.1
next reply other threads:[~2024-01-10 8:54 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-10 8:54 Alexander Stein [this message] 2024-01-10 8:54 ` [PATCH v2 1/1] spi: spi-imx: Use dev_err_probe for failed DMA channel requests Alexander Stein 2024-01-10 9:07 ` Francesco Dolcini 2024-01-10 9:07 ` Francesco Dolcini 2024-01-22 22:07 ` Mark Brown 2024-01-22 22:07 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240110085403.457089-1-alexander.stein@ew.tq-group.com \ --to=alexander.stein@ew.tq-group.com \ --cc=broonie@kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-spi@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.