From: Conor Dooley <conor@kernel.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, linux@roeck-us.net, heikki.krogerus@linux.intel.com, cy_huang@richtek.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names Date: Fri, 19 Jan 2024 16:32:37 +0000 [thread overview] Message-ID: <20240119-eldest-discharge-e2d3812be0a9@spud> (raw) In-Reply-To: <20240119094105.98312-1-angelogioacchino.delregno@collabora.com> [-- Attachment #1: Type: text/plain, Size: 1467 bytes --] On Fri, Jan 19, 2024 at 10:41:04AM +0100, AngeloGioacchino Del Regno wrote: > This IP has only one interrupt, hence interrupt-names is not necessary > to have. > Since there is no user yet, simply remove interrupt-names. I'm a bit confused chief. Patch 2 in this series removes a user of this property from a driver, so can you explain how this statement is true? Maybe I need to drink a few cans of Monster and revisit this patchset? Thanks, Conor. > --- > .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..339bc9c00ac0 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -22,10 +22,6 @@ properties: > interrupts: > maxItems: 1 > > - interrupt-names: > - items: > - - const: PD_IRQB > - > connector: > type: object > $ref: ../connector/usb-connector.yaml# > @@ -58,7 +54,6 @@ examples: > tcpc { > compatible = "mediatek,mt6360-tcpc"; > interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; > - interrupt-names = "PD_IRQB"; > > connector { > compatible = "usb-c-connector"; > -- > 2.43.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, linux@roeck-us.net, heikki.krogerus@linux.intel.com, cy_huang@richtek.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names Date: Fri, 19 Jan 2024 16:32:37 +0000 [thread overview] Message-ID: <20240119-eldest-discharge-e2d3812be0a9@spud> (raw) In-Reply-To: <20240119094105.98312-1-angelogioacchino.delregno@collabora.com> [-- Attachment #1.1: Type: text/plain, Size: 1467 bytes --] On Fri, Jan 19, 2024 at 10:41:04AM +0100, AngeloGioacchino Del Regno wrote: > This IP has only one interrupt, hence interrupt-names is not necessary > to have. > Since there is no user yet, simply remove interrupt-names. I'm a bit confused chief. Patch 2 in this series removes a user of this property from a driver, so can you explain how this statement is true? Maybe I need to drink a few cans of Monster and revisit this patchset? Thanks, Conor. > --- > .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..339bc9c00ac0 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -22,10 +22,6 @@ properties: > interrupts: > maxItems: 1 > > - interrupt-names: > - items: > - - const: PD_IRQB > - > connector: > type: object > $ref: ../connector/usb-connector.yaml# > @@ -58,7 +54,6 @@ examples: > tcpc { > compatible = "mediatek,mt6360-tcpc"; > interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; > - interrupt-names = "PD_IRQB"; > > connector { > compatible = "usb-c-connector"; > -- > 2.43.0 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-19 16:32 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-19 9:41 [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names AngeloGioacchino Del Regno 2024-01-19 9:41 ` AngeloGioacchino Del Regno 2024-01-19 9:41 ` [PATCH v2 2/2] usb: typec: tcpci_mt6360: Retrieve interrupt by index AngeloGioacchino Del Regno 2024-01-19 9:41 ` AngeloGioacchino Del Regno 2024-01-19 11:49 ` [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names Rob Herring 2024-01-19 11:49 ` Rob Herring 2024-01-19 16:32 ` Conor Dooley [this message] 2024-01-19 16:32 ` Conor Dooley 2024-01-22 10:32 ` AngeloGioacchino Del Regno 2024-01-22 10:32 ` AngeloGioacchino Del Regno 2024-01-23 17:14 ` Conor Dooley 2024-01-23 17:14 ` Conor Dooley 2024-01-24 8:48 ` AngeloGioacchino Del Regno 2024-01-24 8:48 ` AngeloGioacchino Del Regno 2024-01-24 16:18 ` Conor Dooley 2024-01-24 16:18 ` Conor Dooley 2024-01-25 10:32 ` Krzysztof Kozlowski 2024-01-25 10:32 ` Krzysztof Kozlowski 2024-01-25 11:41 ` AngeloGioacchino Del Regno 2024-01-25 11:41 ` AngeloGioacchino Del Regno 2024-01-25 16:57 ` Conor Dooley 2024-01-25 16:57 ` Conor Dooley 2024-01-25 17:02 ` Conor Dooley 2024-01-25 17:02 ` Conor Dooley 2024-01-26 9:15 ` AngeloGioacchino Del Regno 2024-01-26 9:15 ` AngeloGioacchino Del Regno 2024-01-26 9:27 ` Conor Dooley 2024-01-26 9:27 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240119-eldest-discharge-e2d3812be0a9@spud \ --to=conor@kernel.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=chunfeng.yun@mediatek.com \ --cc=conor+dt@kernel.org \ --cc=cy_huang@richtek.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.