From: Andre Przywara <andre.przywara@arm.com> To: Chen-Yu Tsai <wens@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Date: Tue, 23 Jan 2024 00:43:15 +0000 [thread overview] Message-ID: <20240123004315.068adcba@minigeek.lan> (raw) In-Reply-To: <20240122170518.3090814-8-wens@kernel.org> On Tue, 23 Jan 2024 01:05:18 +0800 Chen-Yu Tsai <wens@kernel.org> wrote: Hi, > From: Chen-Yu Tsai <wens@csie.org> > > The H616 SoC has an SPDIF transmitter hardware block, which has the same > layout as the one in the H6, minus the receiver side. > > Add a device node for it, and a default pinmux. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Compared the details against the manual, the clock driver, and the binding, they match: Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index a0268439f3be..fd4c080b8e62 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -253,6 +253,11 @@ spi1_cs0_pin: spi1-cs0-pin { > function = "spi1"; > }; > > + spdif_tx_pin: spdif-tx-pin { > + pins = "PH4"; > + function = "spdif"; > + }; > + > uart0_ph_pins: uart0-ph-pins { > pins = "PH0", "PH1"; > function = "uart0"; > @@ -550,6 +555,21 @@ mdio0: mdio { > }; > }; > > + spdif: spdif@5093000 { > + compatible = "allwinner,sun50i-h616-spdif"; > + reg = <0x05093000 0x400>; > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>; > + clock-names = "apb", "spdif"; > + resets = <&ccu RST_BUS_SPDIF>; > + dmas = <&dma 2>; > + dma-names = "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_tx_pin>; > + #sound-dai-cells = <0>; > + status = "disabled"; > + }; > + > usbotg: usb@5100000 { > compatible = "allwinner,sun50i-h616-musb", > "allwinner,sun8i-h3-musb";
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Chen-Yu Tsai <wens@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Date: Tue, 23 Jan 2024 00:43:15 +0000 [thread overview] Message-ID: <20240123004315.068adcba@minigeek.lan> (raw) In-Reply-To: <20240122170518.3090814-8-wens@kernel.org> On Tue, 23 Jan 2024 01:05:18 +0800 Chen-Yu Tsai <wens@kernel.org> wrote: Hi, > From: Chen-Yu Tsai <wens@csie.org> > > The H616 SoC has an SPDIF transmitter hardware block, which has the same > layout as the one in the H6, minus the receiver side. > > Add a device node for it, and a default pinmux. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Compared the details against the manual, the clock driver, and the binding, they match: Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index a0268439f3be..fd4c080b8e62 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -253,6 +253,11 @@ spi1_cs0_pin: spi1-cs0-pin { > function = "spi1"; > }; > > + spdif_tx_pin: spdif-tx-pin { > + pins = "PH4"; > + function = "spdif"; > + }; > + > uart0_ph_pins: uart0-ph-pins { > pins = "PH0", "PH1"; > function = "uart0"; > @@ -550,6 +555,21 @@ mdio0: mdio { > }; > }; > > + spdif: spdif@5093000 { > + compatible = "allwinner,sun50i-h616-spdif"; > + reg = <0x05093000 0x400>; > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>; > + clock-names = "apb", "spdif"; > + resets = <&ccu RST_BUS_SPDIF>; > + dmas = <&dma 2>; > + dma-names = "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_tx_pin>; > + #sound-dai-cells = <0>; > + status = "disabled"; > + }; > + > usbotg: usb@5100000 { > compatible = "allwinner,sun50i-h616-musb", > "allwinner,sun8i-h3-musb"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-23 0:44 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-22 17:05 [PATCH 0/7] arm64: sun50i-h616: Add DMA and SPDIF controllers Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 17:05 ` [PATCH 1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6 Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 18:18 ` Conor Dooley 2024-01-22 18:18 ` Conor Dooley 2024-01-23 17:48 ` Jernej Škrabec 2024-01-23 17:48 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 2/7] dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 18:19 ` Conor Dooley 2024-01-22 18:19 ` Conor Dooley 2024-01-23 17:49 ` Jernej Škrabec 2024-01-23 17:49 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:38 ` Andre Przywara 2024-01-23 0:38 ` Andre Przywara 2024-01-23 17:50 ` Jernej Škrabec 2024-01-23 17:50 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 18:18 ` Conor Dooley 2024-01-22 18:18 ` Conor Dooley 2024-01-25 14:31 ` Chen-Yu Tsai 2024-01-25 14:31 ` Chen-Yu Tsai 2024-01-23 0:40 ` Andre Przywara 2024-01-23 0:40 ` Andre Przywara 2024-01-25 14:37 ` Chen-Yu Tsai 2024-01-25 14:37 ` Chen-Yu Tsai 2024-01-25 15:09 ` Andre Przywara 2024-01-25 15:09 ` Andre Przywara 2024-01-25 15:45 ` Chen-Yu Tsai 2024-01-25 15:45 ` Chen-Yu Tsai 2024-01-22 17:05 ` [PATCH 5/7] arm64: dts: allwinner: h6: Add RX DMA channel for SPDIF Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:39 ` Andre Przywara 2024-01-23 0:39 ` Andre Przywara 2024-01-23 17:52 ` Jernej Škrabec 2024-01-23 17:52 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 6/7] arm64: dts: allwinner: h616: Add DMA controller and DMA channels Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:41 ` Andre Przywara 2024-01-23 0:41 ` Andre Przywara 2024-01-22 17:05 ` [PATCH 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:43 ` Andre Przywara [this message] 2024-01-23 0:43 ` Andre Przywara 2024-01-23 17:53 ` Jernej Škrabec 2024-01-23 17:53 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240123004315.068adcba@minigeek.lan \ --to=andre.przywara@arm.com \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sound@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=tiwai@suse.com \ --cc=vkoul@kernel.org \ --cc=wens@csie.org \ --cc=wens@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.