All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: oe-kbuild-all@lists.linux.dev, alexandre.belloni@bootlin.com,
	conor.culhane@silvaco.com, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	jirislaby@kernel.org, joe@perches.com,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	miquel.raynal@bootlin.com, robh@kernel.org,
	zbigniew.lukwinski@linux.intel.com
Subject: Re: [PATCH v4 5/8] i3c: target: add svc target controller support
Date: Sat, 27 Jan 2024 08:58:28 +0800	[thread overview]
Message-ID: <202401270838.wdxHPaAT-lkp@intel.com> (raw)
In-Reply-To: <20240123231043.3891847-6-Frank.Li@nxp.com>

Hi Frank,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus robh/for-next linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/i3c-add-target-mode-support/20240124-071453
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20240123231043.3891847-6-Frank.Li%40nxp.com
patch subject: [PATCH v4 5/8] i3c: target: add svc target controller support
config: i386-buildonly-randconfig-003-20240127 (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401270838.wdxHPaAT-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h: In function 'i3c_target_ctrl_alloc_request':
   include/linux/i3c/target.h:280:9: error: implicit declaration of function 'kzalloc'; did you mean 'xa_alloc'? [-Werror=implicit-function-declaration]
      req = kzalloc(sizeof(*req), gfp_flags);
            ^~~~~~~
            xa_alloc
>> include/linux/i3c/target.h:280:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      req = kzalloc(sizeof(*req), gfp_flags);
          ^
   include/linux/i3c/target.h: In function 'i3c_target_ctrl_free_request':
   include/linux/i3c/target.h:306:3: error: implicit declaration of function 'kfree'; did you mean '__free'? [-Werror=implicit-function-declaration]
      kfree(req);
      ^~~~~
      __free
   In file included from include/linux/resource_ext.h:11:0,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from include/linux/i3c/device.h:13,
                    from drivers/i3c/master/svc-i3c-target.c:24:
   include/linux/slab.h: At top level:
>> include/linux/slab.h:227:6: warning: conflicting types for 'kfree'
    void kfree(const void *objp);
         ^~~~~
   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h:306:3: note: previous implicit declaration of 'kfree' was here
      kfree(req);
      ^~~~~
   In file included from include/linux/resource_ext.h:11:0,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from include/linux/i3c/device.h:13,
                    from drivers/i3c/master/svc-i3c-target.c:24:
>> include/linux/slab.h:709:37: error: conflicting types for 'kzalloc'
    static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags)
                                        ^~~~~~~
   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h:280:9: note: previous implicit declaration of 'kzalloc' was here
      req = kzalloc(sizeof(*req), gfp_flags);
            ^~~~~~~
   cc1: some warnings being treated as errors


vim +280 include/linux/i3c/target.h

ebda81e6094f36 Frank Li 2024-01-23  264  
ebda81e6094f36 Frank Li 2024-01-23  265  /**
ebda81e6094f36 Frank Li 2024-01-23  266   * i3c_target_ctrl_alloc_request() - Alloc an I3C transfer
ebda81e6094f36 Frank Li 2024-01-23  267   * @ctrl: I3C target controller device
ebda81e6094f36 Frank Li 2024-01-23  268   * @gfp_flags: additional gfp flags used when allocating the buffers
ebda81e6094f36 Frank Li 2024-01-23  269   *
ebda81e6094f36 Frank Li 2024-01-23  270   * Returns: Zero for success, or an error code in case of failure
ebda81e6094f36 Frank Li 2024-01-23  271   */
ebda81e6094f36 Frank Li 2024-01-23  272  static inline struct i3c_request *
ebda81e6094f36 Frank Li 2024-01-23  273  i3c_target_ctrl_alloc_request(struct i3c_target_ctrl *ctrl, gfp_t gfp_flags)
ebda81e6094f36 Frank Li 2024-01-23  274  {
ebda81e6094f36 Frank Li 2024-01-23  275  	struct i3c_request *req = NULL;
ebda81e6094f36 Frank Li 2024-01-23  276  
ebda81e6094f36 Frank Li 2024-01-23  277  	if (ctrl && ctrl->ops && ctrl->ops->alloc_request)
ebda81e6094f36 Frank Li 2024-01-23  278  		req = ctrl->ops->alloc_request(ctrl, gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23  279  	else
ebda81e6094f36 Frank Li 2024-01-23 @280  		req = kzalloc(sizeof(*req), gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23  281  
ebda81e6094f36 Frank Li 2024-01-23  282  	if (req)
ebda81e6094f36 Frank Li 2024-01-23  283  		req->ctrl = ctrl;
ebda81e6094f36 Frank Li 2024-01-23  284  
ebda81e6094f36 Frank Li 2024-01-23  285  	return req;
ebda81e6094f36 Frank Li 2024-01-23  286  }
ebda81e6094f36 Frank Li 2024-01-23  287  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: oe-kbuild-all@lists.linux.dev, alexandre.belloni@bootlin.com,
	conor.culhane@silvaco.com, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	jirislaby@kernel.org, joe@perches.com,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	miquel.raynal@bootlin.com, robh@kernel.org,
	zbigniew.lukwinski@linux.intel.com
Subject: Re: [PATCH v4 5/8] i3c: target: add svc target controller support
Date: Sat, 27 Jan 2024 08:58:28 +0800	[thread overview]
Message-ID: <202401270838.wdxHPaAT-lkp@intel.com> (raw)
In-Reply-To: <20240123231043.3891847-6-Frank.Li@nxp.com>

Hi Frank,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus robh/for-next linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/i3c-add-target-mode-support/20240124-071453
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20240123231043.3891847-6-Frank.Li%40nxp.com
patch subject: [PATCH v4 5/8] i3c: target: add svc target controller support
config: i386-buildonly-randconfig-003-20240127 (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401270838.wdxHPaAT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401270838.wdxHPaAT-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h: In function 'i3c_target_ctrl_alloc_request':
   include/linux/i3c/target.h:280:9: error: implicit declaration of function 'kzalloc'; did you mean 'xa_alloc'? [-Werror=implicit-function-declaration]
      req = kzalloc(sizeof(*req), gfp_flags);
            ^~~~~~~
            xa_alloc
>> include/linux/i3c/target.h:280:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      req = kzalloc(sizeof(*req), gfp_flags);
          ^
   include/linux/i3c/target.h: In function 'i3c_target_ctrl_free_request':
   include/linux/i3c/target.h:306:3: error: implicit declaration of function 'kfree'; did you mean '__free'? [-Werror=implicit-function-declaration]
      kfree(req);
      ^~~~~
      __free
   In file included from include/linux/resource_ext.h:11:0,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from include/linux/i3c/device.h:13,
                    from drivers/i3c/master/svc-i3c-target.c:24:
   include/linux/slab.h: At top level:
>> include/linux/slab.h:227:6: warning: conflicting types for 'kfree'
    void kfree(const void *objp);
         ^~~~~
   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h:306:3: note: previous implicit declaration of 'kfree' was here
      kfree(req);
      ^~~~~
   In file included from include/linux/resource_ext.h:11:0,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from include/linux/i3c/device.h:13,
                    from drivers/i3c/master/svc-i3c-target.c:24:
>> include/linux/slab.h:709:37: error: conflicting types for 'kzalloc'
    static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags)
                                        ^~~~~~~
   In file included from drivers/i3c/master/svc-i3c-target.c:12:0:
   include/linux/i3c/target.h:280:9: note: previous implicit declaration of 'kzalloc' was here
      req = kzalloc(sizeof(*req), gfp_flags);
            ^~~~~~~
   cc1: some warnings being treated as errors


vim +280 include/linux/i3c/target.h

ebda81e6094f36 Frank Li 2024-01-23  264  
ebda81e6094f36 Frank Li 2024-01-23  265  /**
ebda81e6094f36 Frank Li 2024-01-23  266   * i3c_target_ctrl_alloc_request() - Alloc an I3C transfer
ebda81e6094f36 Frank Li 2024-01-23  267   * @ctrl: I3C target controller device
ebda81e6094f36 Frank Li 2024-01-23  268   * @gfp_flags: additional gfp flags used when allocating the buffers
ebda81e6094f36 Frank Li 2024-01-23  269   *
ebda81e6094f36 Frank Li 2024-01-23  270   * Returns: Zero for success, or an error code in case of failure
ebda81e6094f36 Frank Li 2024-01-23  271   */
ebda81e6094f36 Frank Li 2024-01-23  272  static inline struct i3c_request *
ebda81e6094f36 Frank Li 2024-01-23  273  i3c_target_ctrl_alloc_request(struct i3c_target_ctrl *ctrl, gfp_t gfp_flags)
ebda81e6094f36 Frank Li 2024-01-23  274  {
ebda81e6094f36 Frank Li 2024-01-23  275  	struct i3c_request *req = NULL;
ebda81e6094f36 Frank Li 2024-01-23  276  
ebda81e6094f36 Frank Li 2024-01-23  277  	if (ctrl && ctrl->ops && ctrl->ops->alloc_request)
ebda81e6094f36 Frank Li 2024-01-23  278  		req = ctrl->ops->alloc_request(ctrl, gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23  279  	else
ebda81e6094f36 Frank Li 2024-01-23 @280  		req = kzalloc(sizeof(*req), gfp_flags);
ebda81e6094f36 Frank Li 2024-01-23  281  
ebda81e6094f36 Frank Li 2024-01-23  282  	if (req)
ebda81e6094f36 Frank Li 2024-01-23  283  		req->ctrl = ctrl;
ebda81e6094f36 Frank Li 2024-01-23  284  
ebda81e6094f36 Frank Li 2024-01-23  285  	return req;
ebda81e6094f36 Frank Li 2024-01-23  286  }
ebda81e6094f36 Frank Li 2024-01-23  287  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-01-27  0:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 23:10 [PATCH v4 0/8] I3C target mode support Frank Li
2024-01-23 23:10 ` Frank Li
2024-01-23 23:10 ` [PATCH v4 1/8] i3c: add " Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-23 23:10 ` [PATCH v4 2/8] dt-bindings: i3c: svc: add proptery mode Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-23 23:10 ` [PATCH v4 3/8] Documentation: i3c: Add I3C target mode controller and function Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-23 23:10 ` [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-24 14:59   ` Ilpo Järvinen
2024-01-24 14:59     ` Ilpo Järvinen
2024-01-23 23:10 ` [PATCH v4 5/8] i3c: target: add svc target controller support Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-27  0:58   ` kernel test robot [this message]
2024-01-27  0:58     ` kernel test robot
2024-01-23 23:10 ` [PATCH v4 6/8] i3c: target: func: add tty driver Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-24 15:15   ` Ilpo Järvinen
2024-01-24 15:15     ` Ilpo Järvinen
2024-01-23 23:10 ` [PATCH v4 7/8] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-23 23:10 ` [PATCH v4 8/8] tty: i3c: add TTY over I3C master support Frank Li
2024-01-23 23:10   ` Frank Li
2024-01-24 15:26   ` Ilpo Järvinen
2024-01-24 15:26     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401270838.wdxHPaAT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jirislaby@kernel.org \
    --cc=joe@perches.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=zbigniew.lukwinski@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.