From: kernel test robot <lkp@intel.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@lists.linux.dev, Chris Mason <chris.mason@fusionio.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH 5/5] block: remove gfp_flags from blkdev_zone_mgmt
Date: Sat, 27 Jan 2024 17:57:59 +0800 [thread overview]
Message-ID: <202401271724.LJfDQ6VB-lkp@intel.com> (raw)
In-Reply-To: <20240123-zonefs_nofs-v1-5-cc0b0308ef25@wdc.com>
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on 7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Thumshirn/zonefs-pass-GFP_KERNEL-to-blkdev_zone_mgmt-call/20240123-174911
base: 7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf
patch link: https://lore.kernel.org/r/20240123-zonefs_nofs-v1-5-cc0b0308ef25%40wdc.com
patch subject: [PATCH 5/5] block: remove gfp_flags from blkdev_zone_mgmt
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240127/202401271724.LJfDQ6VB-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401271724.LJfDQ6VB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401271724.LJfDQ6VB-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/md/dm-zoned-metadata.c: In function 'dmz_reset_zone':
>> drivers/md/dm-zoned-metadata.c:1659:23: error: too many arguments to function 'blkdev_zone_mgmt'
1659 | ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
| ^~~~~~~~~~~~~~~~
In file included from drivers/md/dm-zoned.h:12,
from drivers/md/dm-zoned-metadata.c:8:
include/linux/blkdev.h:327:5: note: declared here
327 | int blkdev_zone_mgmt(struct block_device *bdev, enum req_op op,
| ^~~~~~~~~~~~~~~~
vim +/blkdev_zone_mgmt +1659 drivers/md/dm-zoned-metadata.c
3b1a94c88b798d Damien Le Moal 2017-06-07 1639
3b1a94c88b798d Damien Le Moal 2017-06-07 1640 /*
3b1a94c88b798d Damien Le Moal 2017-06-07 1641 * Reset a zone write pointer.
3b1a94c88b798d Damien Le Moal 2017-06-07 1642 */
3b1a94c88b798d Damien Le Moal 2017-06-07 1643 static int dmz_reset_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
3b1a94c88b798d Damien Le Moal 2017-06-07 1644 {
3b1a94c88b798d Damien Le Moal 2017-06-07 1645 int ret;
3b1a94c88b798d Damien Le Moal 2017-06-07 1646
3b1a94c88b798d Damien Le Moal 2017-06-07 1647 /*
3b1a94c88b798d Damien Le Moal 2017-06-07 1648 * Ignore offline zones, read only zones,
3b1a94c88b798d Damien Le Moal 2017-06-07 1649 * and conventional zones.
3b1a94c88b798d Damien Le Moal 2017-06-07 1650 */
3b1a94c88b798d Damien Le Moal 2017-06-07 1651 if (dmz_is_offline(zone) ||
3b1a94c88b798d Damien Le Moal 2017-06-07 1652 dmz_is_readonly(zone) ||
3b1a94c88b798d Damien Le Moal 2017-06-07 1653 dmz_is_rnd(zone))
3b1a94c88b798d Damien Le Moal 2017-06-07 1654 return 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1655
3b1a94c88b798d Damien Le Moal 2017-06-07 1656 if (!dmz_is_empty(zone) || dmz_seq_write_err(zone)) {
8f22272af7a727 Hannes Reinecke 2020-06-02 1657 struct dmz_dev *dev = zone->dev;
3b1a94c88b798d Damien Le Moal 2017-06-07 1658
6c1b1da58f8c7a Ajay Joshi 2019-10-27 @1659 ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
3b1a94c88b798d Damien Le Moal 2017-06-07 1660 dmz_start_sect(zmd, zone),
c4d4977392621f Johannes Thumshirn 2024-01-23 1661 zmd->zone_nr_sectors, GFP_KERNEL);
3b1a94c88b798d Damien Le Moal 2017-06-07 1662 if (ret) {
3b1a94c88b798d Damien Le Moal 2017-06-07 1663 dmz_dev_err(dev, "Reset zone %u failed %d",
b71228739851a9 Hannes Reinecke 2020-05-11 1664 zone->id, ret);
3b1a94c88b798d Damien Le Moal 2017-06-07 1665 return ret;
3b1a94c88b798d Damien Le Moal 2017-06-07 1666 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1667 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1668
3b1a94c88b798d Damien Le Moal 2017-06-07 1669 /* Clear write error bit and rewind write pointer position */
3b1a94c88b798d Damien Le Moal 2017-06-07 1670 clear_bit(DMZ_SEQ_WRITE_ERR, &zone->flags);
3b1a94c88b798d Damien Le Moal 2017-06-07 1671 zone->wp_block = 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1672
3b1a94c88b798d Damien Le Moal 2017-06-07 1673 return 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1674 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1675
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@lists.linux.dev, Chris Mason <chris.mason@fusionio.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org,
"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 5/5] block: remove gfp_flags from blkdev_zone_mgmt
Date: Sat, 27 Jan 2024 17:57:59 +0800 [thread overview]
Message-ID: <202401271724.LJfDQ6VB-lkp@intel.com> (raw)
In-Reply-To: <20240123-zonefs_nofs-v1-5-cc0b0308ef25@wdc.com>
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on 7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Thumshirn/zonefs-pass-GFP_KERNEL-to-blkdev_zone_mgmt-call/20240123-174911
base: 7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf
patch link: https://lore.kernel.org/r/20240123-zonefs_nofs-v1-5-cc0b0308ef25%40wdc.com
patch subject: [PATCH 5/5] block: remove gfp_flags from blkdev_zone_mgmt
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240127/202401271724.LJfDQ6VB-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401271724.LJfDQ6VB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401271724.LJfDQ6VB-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/md/dm-zoned-metadata.c: In function 'dmz_reset_zone':
>> drivers/md/dm-zoned-metadata.c:1659:23: error: too many arguments to function 'blkdev_zone_mgmt'
1659 | ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
| ^~~~~~~~~~~~~~~~
In file included from drivers/md/dm-zoned.h:12,
from drivers/md/dm-zoned-metadata.c:8:
include/linux/blkdev.h:327:5: note: declared here
327 | int blkdev_zone_mgmt(struct block_device *bdev, enum req_op op,
| ^~~~~~~~~~~~~~~~
vim +/blkdev_zone_mgmt +1659 drivers/md/dm-zoned-metadata.c
3b1a94c88b798d Damien Le Moal 2017-06-07 1639
3b1a94c88b798d Damien Le Moal 2017-06-07 1640 /*
3b1a94c88b798d Damien Le Moal 2017-06-07 1641 * Reset a zone write pointer.
3b1a94c88b798d Damien Le Moal 2017-06-07 1642 */
3b1a94c88b798d Damien Le Moal 2017-06-07 1643 static int dmz_reset_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
3b1a94c88b798d Damien Le Moal 2017-06-07 1644 {
3b1a94c88b798d Damien Le Moal 2017-06-07 1645 int ret;
3b1a94c88b798d Damien Le Moal 2017-06-07 1646
3b1a94c88b798d Damien Le Moal 2017-06-07 1647 /*
3b1a94c88b798d Damien Le Moal 2017-06-07 1648 * Ignore offline zones, read only zones,
3b1a94c88b798d Damien Le Moal 2017-06-07 1649 * and conventional zones.
3b1a94c88b798d Damien Le Moal 2017-06-07 1650 */
3b1a94c88b798d Damien Le Moal 2017-06-07 1651 if (dmz_is_offline(zone) ||
3b1a94c88b798d Damien Le Moal 2017-06-07 1652 dmz_is_readonly(zone) ||
3b1a94c88b798d Damien Le Moal 2017-06-07 1653 dmz_is_rnd(zone))
3b1a94c88b798d Damien Le Moal 2017-06-07 1654 return 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1655
3b1a94c88b798d Damien Le Moal 2017-06-07 1656 if (!dmz_is_empty(zone) || dmz_seq_write_err(zone)) {
8f22272af7a727 Hannes Reinecke 2020-06-02 1657 struct dmz_dev *dev = zone->dev;
3b1a94c88b798d Damien Le Moal 2017-06-07 1658
6c1b1da58f8c7a Ajay Joshi 2019-10-27 @1659 ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
3b1a94c88b798d Damien Le Moal 2017-06-07 1660 dmz_start_sect(zmd, zone),
c4d4977392621f Johannes Thumshirn 2024-01-23 1661 zmd->zone_nr_sectors, GFP_KERNEL);
3b1a94c88b798d Damien Le Moal 2017-06-07 1662 if (ret) {
3b1a94c88b798d Damien Le Moal 2017-06-07 1663 dmz_dev_err(dev, "Reset zone %u failed %d",
b71228739851a9 Hannes Reinecke 2020-05-11 1664 zone->id, ret);
3b1a94c88b798d Damien Le Moal 2017-06-07 1665 return ret;
3b1a94c88b798d Damien Le Moal 2017-06-07 1666 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1667 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1668
3b1a94c88b798d Damien Le Moal 2017-06-07 1669 /* Clear write error bit and rewind write pointer position */
3b1a94c88b798d Damien Le Moal 2017-06-07 1670 clear_bit(DMZ_SEQ_WRITE_ERR, &zone->flags);
3b1a94c88b798d Damien Le Moal 2017-06-07 1671 zone->wp_block = 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1672
3b1a94c88b798d Damien Le Moal 2017-06-07 1673 return 0;
3b1a94c88b798d Damien Le Moal 2017-06-07 1674 }
3b1a94c88b798d Damien Le Moal 2017-06-07 1675
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-01-27 9:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 9:43 [PATCH 0/5] block: remove gfp_mask for blkdev_zone_mgmt() Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-23 9:43 ` [PATCH 1/5] zonefs: pass GFP_KERNEL to blkdev_zone_mgmt() call Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-23 20:39 ` Mikulas Patocka
2024-01-23 20:39 ` [f2fs-dev] " Mikulas Patocka
2024-01-23 23:21 ` Dave Chinner
2024-01-23 23:21 ` [f2fs-dev] " Dave Chinner via Linux-f2fs-devel
2024-01-23 23:31 ` Damien Le Moal
2024-01-23 23:31 ` [f2fs-dev] " Damien Le Moal
2024-01-23 9:43 ` [PATCH 2/5] dm: dm-zoned: pass GFP_KERNEL to blkdev_zone_mgmt Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-23 20:18 ` Mikulas Patocka
2024-01-23 20:18 ` [f2fs-dev] " Mikulas Patocka
2024-01-23 9:43 ` [PATCH 3/5] btrfs: zoned: call blkdev_zone_mgmt in nofs scope Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-23 9:43 ` [PATCH 4/5] f2fs: guard blkdev_zone_mgmt with " Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-23 9:43 ` [PATCH 5/5] block: remove gfp_flags from blkdev_zone_mgmt Johannes Thumshirn
2024-01-23 9:43 ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2024-01-26 22:03 ` kernel test robot
2024-01-26 22:03 ` [f2fs-dev] " kernel test robot
2024-01-27 9:57 ` kernel test robot [this message]
2024-01-27 9:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401271724.LJfDQ6VB-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=chao@kernel.org \
--cc=chris.mason@fusionio.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=naohiro.aota@wdc.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.