From: Luis Chamberlain <mcgrof@kernel.org>
To: masahiroy@kernel.org, deller@gmx.de
Cc: mcgrof@kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] vmlinux.lds.h: add missing alignment for symbol CRCs
Date: Mon, 29 Jan 2024 11:26:42 -0800 [thread overview]
Message-ID: <20240129192644.3359978-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20240129192644.3359978-1-mcgrof@kernel.org>
Commit f3304ecd7f06 (linux/export: use inline assembler to populate
symbol CRCs") fixed an issue with unexpected padding by adding
asm inline assembly to directly specify the desired data layout.
It however forgot to add the alignment, fix that.
Reported-by: Helge Deller <deller@gmx.de>
Fixes: f3304ecd7f06 ("linux/export: use inline assembler to populate symbol CRCs")
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
include/linux/export-internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/export-internal.h b/include/linux/export-internal.h
index 69501e0ec239..51b8cf3f60ef 100644
--- a/include/linux/export-internal.h
+++ b/include/linux/export-internal.h
@@ -61,6 +61,7 @@
#define SYMBOL_CRC(sym, crc, sec) \
asm(".section \"___kcrctab" sec "+" #sym "\",\"a\"" "\n" \
+ ".balign 4" "\n" \
"__crc_" #sym ":" "\n" \
".long " #crc "\n" \
".previous" "\n")
--
2.42.0
next prev parent reply other threads:[~2024-01-29 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 19:26 [PATCH v2 0/3] modules: few of alignment fixes Luis Chamberlain
2024-01-29 19:26 ` [PATCH v2 1/4] selftests: add new kallsyms selftests Luis Chamberlain
2024-01-29 19:26 ` [PATCH v2 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections Luis Chamberlain
2024-01-29 19:26 ` Luis Chamberlain [this message]
2024-01-29 19:26 ` [PATCH v2 4/4] modules: Add missing entry for __ex_table Luis Chamberlain
2024-01-31 22:11 ` [PATCH v2 0/3] modules: few of alignment fixes Luis Chamberlain
2024-02-01 18:05 ` Luis Chamberlain
2024-02-02 15:20 ` Masahiro Yamada
2024-02-02 18:23 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129192644.3359978-4-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.