All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Perry <charles.perry@savoirfairelinux.com>
To: mdf@kernel.org
Cc: avandiver@markem-imaje.com, bcody@markem-imaje.com,
	Charles Perry <charles.perry@savoirfairelinux.com>,
	Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
	Tom Rix <trix@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michal Simek <michal.simek@amd.com>,
	kishore Manne <nava.kishore.manne@amd.com>,
	linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios
Date: Wed,  7 Feb 2024 13:01:25 -0500	[thread overview]
Message-ID: <20240207180142.79625-3-charles.perry@savoirfairelinux.com> (raw)
In-Reply-To: <20240207180142.79625-1-charles.perry@savoirfairelinux.com>

By convention, gpio consumer names should not contain underscores
(prog_b here) and shouldn't contain active low suffixes (-b here).

Signed-off-by: Charles Perry <charles.perry@savoirfairelinux.com>
---
 .../bindings/fpga/xlnx,fpga-slave-serial.yaml        | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
index 614d86ad825f3..650a4d8792b64 100644
--- a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
+++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
@@ -36,7 +36,7 @@ properties:
   reg:
     maxItems: 1
 
-  prog_b-gpios:
+  prog-gpios:
     description:
       config pin (referred to as PROGRAM_B in the manual)
     maxItems: 1
@@ -46,7 +46,7 @@ properties:
       config status pin (referred to as DONE in the manual)
     maxItems: 1
 
-  init-b-gpios:
+  init-gpios:
     description:
       initialization status and configuration error pin
       (referred to as INIT_B in the manual)
@@ -55,9 +55,9 @@ properties:
 required:
   - compatible
   - reg
-  - prog_b-gpios
+  - prog-gpios
   - done-gpios
-  - init-b-gpios
+  - init-gpios
 
 additionalProperties: false
 
@@ -72,8 +72,8 @@ examples:
         spi-max-frequency = <60000000>;
         spi-cpha;
         reg = <0>;
-        prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-        init-b-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
+        prog-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
+        init-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
         done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
       };
     };
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Charles Perry <charles.perry@savoirfairelinux.com>
To: mdf@kernel.org
Cc: avandiver@markem-imaje.com, bcody@markem-imaje.com,
	Charles Perry <charles.perry@savoirfairelinux.com>,
	Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
	Tom Rix <trix@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michal Simek <michal.simek@amd.com>,
	kishore Manne <nava.kishore.manne@amd.com>,
	linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios
Date: Wed,  7 Feb 2024 13:01:25 -0500	[thread overview]
Message-ID: <20240207180142.79625-3-charles.perry@savoirfairelinux.com> (raw)
In-Reply-To: <20240207180142.79625-1-charles.perry@savoirfairelinux.com>

By convention, gpio consumer names should not contain underscores
(prog_b here) and shouldn't contain active low suffixes (-b here).

Signed-off-by: Charles Perry <charles.perry@savoirfairelinux.com>
---
 .../bindings/fpga/xlnx,fpga-slave-serial.yaml        | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
index 614d86ad825f3..650a4d8792b64 100644
--- a/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
+++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
@@ -36,7 +36,7 @@ properties:
   reg:
     maxItems: 1
 
-  prog_b-gpios:
+  prog-gpios:
     description:
       config pin (referred to as PROGRAM_B in the manual)
     maxItems: 1
@@ -46,7 +46,7 @@ properties:
       config status pin (referred to as DONE in the manual)
     maxItems: 1
 
-  init-b-gpios:
+  init-gpios:
     description:
       initialization status and configuration error pin
       (referred to as INIT_B in the manual)
@@ -55,9 +55,9 @@ properties:
 required:
   - compatible
   - reg
-  - prog_b-gpios
+  - prog-gpios
   - done-gpios
-  - init-b-gpios
+  - init-gpios
 
 additionalProperties: false
 
@@ -72,8 +72,8 @@ examples:
         spi-max-frequency = <60000000>;
         spi-cpha;
         reg = <0>;
-        prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
-        init-b-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
+        prog-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
+        init-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
         done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
       };
     };
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-02-07 18:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 18:01 [PATCH v3 0/5] fpga: xilinx-selectmap: add new driver Charles Perry
2024-02-07 18:01 ` Charles Perry
2024-02-07 18:01 ` [PATCH v3 1/5] fpga: xilinx-spi: extract a common driver core Charles Perry
2024-02-07 18:01   ` Charles Perry
2024-02-07 18:01 ` Charles Perry [this message]
2024-02-07 18:01   ` [PATCH v3 2/5] dt-bindings: fpga: xlnx,fpga-slave-serial: rename gpios Charles Perry
2024-02-11 15:39   ` Krzysztof Kozlowski
2024-02-11 15:39     ` Krzysztof Kozlowski
2024-02-13 21:40     ` Charles Perry
2024-02-13 21:40       ` Charles Perry
2024-02-15 13:32   ` Rob Herring
2024-02-15 13:32     ` Rob Herring
2024-02-15 19:42     ` Charles Perry
2024-02-15 19:42       ` Charles Perry
2024-02-07 18:01 ` [PATCH v3 3/5] fpga: xilinx-core: rename "prog_b" and "init-b" gpios Charles Perry
2024-02-07 18:01   ` Charles Perry
2024-02-11 15:40   ` Krzysztof Kozlowski
2024-02-11 15:40     ` Krzysztof Kozlowski
2024-02-07 18:01 ` [PATCH v3 4/5] dt-bindings: fpga: xlnx,fpga-selectmap: add DT schema Charles Perry
2024-02-07 18:01   ` Charles Perry
2024-02-07 21:25   ` Rob Herring
2024-02-07 21:25     ` Rob Herring
2024-02-07 18:01 ` [PATCH v3 5/5] fpga: xilinx-selectmap: add new driver Charles Perry
2024-02-07 18:01   ` Charles Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207180142.79625-3-charles.perry@savoirfairelinux.com \
    --to=charles.perry@savoirfairelinux.com \
    --cc=avandiver@markem-imaje.com \
    --cc=bcody@markem-imaje.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hao.wu@intel.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=nava.kishore.manne@amd.com \
    --cc=robh+dt@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.