From: Lee Jones <lee@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 0/6] mfd: tmio: simplify header and move to platform_data Date: Fri, 9 Feb 2024 13:28:37 +0000 [thread overview] Message-ID: <20240209132837.GJ689448@google.com> (raw) In-Reply-To: <CAPDyKFpmfgwJ5dJFmORhg1tBewzhB_jrWikpX=b23r-joN91SA@mail.gmail.com> On Fri, 09 Feb 2024, Ulf Hansson wrote: > On Fri, 9 Feb 2024 at 02:59, Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > > > The MFD parts of the TMIO have been removed by Arnd, so that only the > > SD/MMC related functionality is left. Remove the outdated remains in the > > public header file and then move it to platform_data as the data is now > > specific for the SD/MMC part. > > > > Based on 6.8-rc3, build bot is happy. Branch is here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > > > I'd suggest this goes via the MFD tree, so the series would need acks > > from the MMC and SH maintainers. Is that okay with everyone? > > Wouldn't it be better to funnel this via the mmc tree? In that way, we > can easily avoid conflicts with additional renesas-mmc driver changes > that we have in pipe. You could say the same about changes SH, MFD and Platform Data have in the pipe. > Or perhaps there are other changes that make the mfd tree preferred? MFD is usually preferred since the parent device usually lives there and we are well accustomed to merging multi-subsystem related sets. It doesn't really matter how this is merged. The only stipulation is that whoever applies the set does so on a succinct, immutable, tagged branch and sends out a pull-request for everyone else to pull from. If you want to do that, there are no complains from me. > > All the best! > > > > Wolfram > > > > > > Wolfram Sang (6): > > mfd: tmio: remove obsolete platform_data > > mfd: tmio: remove obsolete io accessors > > mmc: tmio/sdhi: fix includes > > mfd: tmio: update include files > > mfd: tmio: sanitize comments > > mfd: tmio: move header to platform_data > > > > MAINTAINERS | 2 +- > > arch/sh/boards/board-sh7757lcr.c | 2 +- > > arch/sh/boards/mach-ap325rxa/setup.c | 2 +- > > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > > arch/sh/boards/mach-kfr2r09/setup.c | 2 +- > > arch/sh/boards/mach-migor/setup.c | 2 +- > > arch/sh/boards/mach-se/7724/setup.c | 2 +- > > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 5 +- > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 5 +- > > drivers/mmc/host/tmio_mmc_core.c | 3 +- > > drivers/mmc/host/uniphier-sd.c | 2 +- > > include/linux/mfd/tmio.h | 133 ------------------ > > include/linux/platform_data/tmio.h | 64 +++++++++ > > 14 files changed, 81 insertions(+), 147 deletions(-) > > delete mode 100644 include/linux/mfd/tmio.h > > create mode 100644 include/linux/platform_data/tmio.h > > > > -- > > 2.43.0 > > > > -- Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 0/6] mfd: tmio: simplify header and move to platform_data Date: Fri, 9 Feb 2024 13:28:37 +0000 [thread overview] Message-ID: <20240209132837.GJ689448@google.com> (raw) In-Reply-To: <CAPDyKFpmfgwJ5dJFmORhg1tBewzhB_jrWikpX=b23r-joN91SA@mail.gmail.com> On Fri, 09 Feb 2024, Ulf Hansson wrote: > On Fri, 9 Feb 2024 at 02:59, Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > > > The MFD parts of the TMIO have been removed by Arnd, so that only the > > SD/MMC related functionality is left. Remove the outdated remains in the > > public header file and then move it to platform_data as the data is now > > specific for the SD/MMC part. > > > > Based on 6.8-rc3, build bot is happy. Branch is here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > > > I'd suggest this goes via the MFD tree, so the series would need acks > > from the MMC and SH maintainers. Is that okay with everyone? > > Wouldn't it be better to funnel this via the mmc tree? In that way, we > can easily avoid conflicts with additional renesas-mmc driver changes > that we have in pipe. You could say the same about changes SH, MFD and Platform Data have in the pipe. > Or perhaps there are other changes that make the mfd tree preferred? MFD is usually preferred since the parent device usually lives there and we are well accustomed to merging multi-subsystem related sets. It doesn't really matter how this is merged. The only stipulation is that whoever applies the set does so on a succinct, immutable, tagged branch and sends out a pull-request for everyone else to pull from. If you want to do that, there are no complains from me. > > All the best! > > > > Wolfram > > > > > > Wolfram Sang (6): > > mfd: tmio: remove obsolete platform_data > > mfd: tmio: remove obsolete io accessors > > mmc: tmio/sdhi: fix includes > > mfd: tmio: update include files > > mfd: tmio: sanitize comments > > mfd: tmio: move header to platform_data > > > > MAINTAINERS | 2 +- > > arch/sh/boards/board-sh7757lcr.c | 2 +- > > arch/sh/boards/mach-ap325rxa/setup.c | 2 +- > > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > > arch/sh/boards/mach-kfr2r09/setup.c | 2 +- > > arch/sh/boards/mach-migor/setup.c | 2 +- > > arch/sh/boards/mach-se/7724/setup.c | 2 +- > > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 5 +- > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 5 +- > > drivers/mmc/host/tmio_mmc_core.c | 3 +- > > drivers/mmc/host/uniphier-sd.c | 2 +- > > include/linux/mfd/tmio.h | 133 ------------------ > > include/linux/platform_data/tmio.h | 64 +++++++++ > > 14 files changed, 81 insertions(+), 147 deletions(-) > > delete mode 100644 include/linux/mfd/tmio.h > > create mode 100644 include/linux/platform_data/tmio.h > > > > -- > > 2.43.0 > > > > -- Lee Jones [李琼斯] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-09 13:28 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-09 1:58 [PATCH 0/6] mfd: tmio: simplify header and move to platform_data Wolfram Sang 2024-02-09 1:58 ` Wolfram Sang 2024-02-09 1:58 ` [PATCH 1/6] mfd: tmio: remove obsolete platform_data Wolfram Sang 2024-02-09 7:54 ` Lee Jones 2024-02-09 1:58 ` [PATCH 2/6] mfd: tmio: remove obsolete io accessors Wolfram Sang 2024-02-09 7:54 ` Lee Jones 2024-02-09 1:58 ` [PATCH 3/6] mmc: tmio/sdhi: fix includes Wolfram Sang 2024-02-09 1:58 ` [PATCH 4/6] mfd: tmio: update include files Wolfram Sang 2024-02-09 7:55 ` Lee Jones 2024-02-09 1:58 ` [PATCH 5/6] mfd: tmio: sanitize comments Wolfram Sang 2024-02-09 7:56 ` Lee Jones 2024-02-09 1:58 ` [PATCH 6/6] mfd: tmio: move header to platform_data Wolfram Sang 2024-02-09 1:58 ` Wolfram Sang 2024-02-09 7:56 ` Lee Jones 2024-02-09 7:56 ` Lee Jones 2024-02-13 20:52 ` John Paul Adrian Glaubitz 2024-02-13 20:52 ` John Paul Adrian Glaubitz 2024-02-09 7:58 ` [PATCH 0/6] mfd: tmio: simplify header and move " Lee Jones 2024-02-09 7:58 ` Lee Jones 2024-02-09 10:02 ` Wolfram Sang 2024-02-09 10:02 ` Wolfram Sang 2024-02-09 11:34 ` Ulf Hansson 2024-02-09 11:34 ` Ulf Hansson 2024-02-09 13:28 ` Lee Jones [this message] 2024-02-09 13:28 ` Lee Jones 2024-02-12 11:17 ` Ulf Hansson 2024-02-12 11:17 ` Ulf Hansson 2024-02-12 12:12 ` Wolfram Sang 2024-02-12 12:12 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240209132837.GJ689448@google.com \ --to=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.