From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org> To: linux-modules@vger.kernel.org Cc: Emil Velikov <emil.l.velikov@gmail.com> Subject: [PATCH kmod 00/13] Load compressed modules with compression-less kmod Date: Mon, 12 Feb 2024 17:23:01 +0000 [thread overview] Message-ID: <20240212-decompression-fixes-v1-0-06f92ad07985@gmail.com> (raw) While I was digging into a dkms bug, I've noticed that kmod does not fallback to the normal init_module() code path when the in-kernel decompression fails. As I looked closer, I realised that the current module compression detection relies on kmod being build with zstd, xz, zlib ... Even in the case where we rely on the kernel module itself to decompress - aka we don't use the external libraries all together. By building kmod without zstd and friends, we shave some space off the initrd which helps with boot time. Majority of this series handles the latter and fixes a few related bugs along the way. The last commits is somewhat questionable commit and addresses the former issue. Happy to hear your feedback, Emil --- Emil Velikov (13): libkmod: use a dup()'d fd for zlib libkmod: keep gzFile gzf local to load_zlib() libkmod: remove kmod_file::{zstd,xz}_used flags libkmod: clear file->memory if map fails libkmod: nuke struct file_ops libkmod: propagate {zstd,xz,zlib}_load errors libkmod: move kmod_file_load_contents as applicable libkmod: always detect the module compression libkmod: swap alloca usage for a few assert_cc libkmod: tidy-up kmod_file_open() libkmod: move load_reg() further up libkmod: keep KMOD_FILE_COMPRESSION_NONE/load_reg in comp_types libkmod: always fallback to do_init_module() libkmod/libkmod-file.c | 206 ++++++++++++++++++--------------------------- libkmod/libkmod-internal.h | 2 +- libkmod/libkmod-module.c | 8 +- 3 files changed, 90 insertions(+), 126 deletions(-) --- base-commit: b29704cd448aaa455dba4e656fc0f0d3c686df3f change-id: 20240212-decompression-fixes-56371eeb707d Best regards, -- Emil Velikov <emil.l.velikov@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com> To: linux-modules@vger.kernel.org Cc: Emil Velikov <emil.l.velikov@gmail.com> Subject: [PATCH kmod 00/13] Load compressed modules with compression-less kmod Date: Mon, 12 Feb 2024 17:23:01 +0000 [thread overview] Message-ID: <20240212-decompression-fixes-v1-0-06f92ad07985@gmail.com> (raw) While I was digging into a dkms bug, I've noticed that kmod does not fallback to the normal init_module() code path when the in-kernel decompression fails. As I looked closer, I realised that the current module compression detection relies on kmod being build with zstd, xz, zlib ... Even in the case where we rely on the kernel module itself to decompress - aka we don't use the external libraries all together. By building kmod without zstd and friends, we shave some space off the initrd which helps with boot time. Majority of this series handles the latter and fixes a few related bugs along the way. The last commits is somewhat questionable commit and addresses the former issue. Happy to hear your feedback, Emil --- Emil Velikov (13): libkmod: use a dup()'d fd for zlib libkmod: keep gzFile gzf local to load_zlib() libkmod: remove kmod_file::{zstd,xz}_used flags libkmod: clear file->memory if map fails libkmod: nuke struct file_ops libkmod: propagate {zstd,xz,zlib}_load errors libkmod: move kmod_file_load_contents as applicable libkmod: always detect the module compression libkmod: swap alloca usage for a few assert_cc libkmod: tidy-up kmod_file_open() libkmod: move load_reg() further up libkmod: keep KMOD_FILE_COMPRESSION_NONE/load_reg in comp_types libkmod: always fallback to do_init_module() libkmod/libkmod-file.c | 206 ++++++++++++++++++--------------------------- libkmod/libkmod-internal.h | 2 +- libkmod/libkmod-module.c | 8 +- 3 files changed, 90 insertions(+), 126 deletions(-) --- base-commit: b29704cd448aaa455dba4e656fc0f0d3c686df3f change-id: 20240212-decompression-fixes-56371eeb707d Best regards, -- Emil Velikov <emil.l.velikov@gmail.com>
next reply other threads:[~2024-02-12 17:23 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-12 17:23 Emil Velikov via B4 Relay [this message] 2024-02-12 17:23 ` [PATCH kmod 00/13] Load compressed modules with compression-less kmod Emil Velikov 2024-02-12 17:23 ` [PATCH kmod 01/13] libkmod: use a dup()'d fd for zlib Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:13 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 02/13] libkmod: keep gzFile gzf local to load_zlib() Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 21:52 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 03/13] libkmod: remove kmod_file::{zstd,xz}_used flags Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 21:54 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 04/13] libkmod: clear file->memory if map fails Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:13 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 05/13] libkmod: nuke struct file_ops Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:13 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 06/13] libkmod: propagate {zstd,xz,zlib}_load errors Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:14 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 07/13] libkmod: move kmod_file_load_contents as applicable Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:14 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 08/13] libkmod: always detect the module compression Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-02-13 16:33 ` Emil Velikov 2024-04-29 23:13 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 09/13] libkmod: swap alloca usage for a few assert_cc Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:19 ` Lucas De Marchi 2024-04-30 17:39 ` Lucas De Marchi 2024-04-30 17:54 ` Emil Velikov 2024-04-30 18:17 ` Lucas De Marchi 2024-04-30 18:27 ` Emil Velikov 2024-04-30 18:43 ` Lucas De Marchi 2024-04-30 18:47 ` Emil Velikov 2024-04-30 20:36 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 10/13] libkmod: tidy-up kmod_file_open() Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:25 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 11/13] libkmod: move load_reg() further up Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:30 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 12/13] libkmod: keep KMOD_FILE_COMPRESSION_NONE/load_reg in comp_types Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:32 ` Lucas De Marchi 2024-02-12 17:23 ` [PATCH kmod 13/13] libkmod: always fallback to do_init_module() Emil Velikov via B4 Relay 2024-02-12 17:23 ` Emil Velikov 2024-04-29 23:39 ` Lucas De Marchi 2024-04-30 17:48 ` Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240212-decompression-fixes-v1-0-06f92ad07985@gmail.com \ --to=devnull+emil.l.velikov.gmail.com@kernel.org \ --cc=emil.l.velikov@gmail.com \ --cc=linux-modules@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.