From: Conor Dooley <conor@kernel.org>
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org,
linux-gpio@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"David Lechner" <dlechner@baylibre.com>,
"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173
Date: Tue, 20 Feb 2024 18:52:37 +0000 [thread overview]
Message-ID: <20240220-outmost-flavoring-b2593160de91@spud> (raw)
In-Reply-To: <20240220094344.17556-1-mitrutzceclan@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Tue, Feb 20, 2024 at 11:43:38AM +0200, Dumitru Ceclan wrote:
> + interrupts:
> + minItems: 1
> + description: |
> +
> + interrupt-names:
> + minItems: 1
> + items:
> + - const: rdy
> + - const: err
I noticed that for minItems == 1, the rdy interrupt is required and err
is the optional one.
With that in mind, you can simplify the interrupts description so that
it describes the interrupts separately:
interrupts:
minItems:
items:
- description:
Ready: multiplexed with SPI data out. While SPI CS is low,
can be used to indicate the completion of a conversion.
- description:
Error: The three error bits in the status register (ADC_ERROR, CRC_ERROR,
and REG_ERROR) are OR'ed, inverted, and mapped to the ERROR pin. Therefore,
the ERROR pin indicates that an error has occurred.
Otherwise, I think everything has been sorted out?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-20 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:43 [PATCH v13 1/3] dt-bindings: adc: add AD7173 Dumitru Ceclan
2024-02-20 9:43 ` [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection Dumitru Ceclan
2024-02-20 14:11 ` Andy Shevchenko
2024-02-20 14:13 ` Ceclan Dumitru
2024-02-20 14:17 ` Andy Shevchenko
2024-02-24 17:02 ` Jonathan Cameron
2024-02-20 9:43 ` [PATCH v13 3/3] iio: adc: ad7173: add AD7173 driver Dumitru Ceclan
2024-02-20 10:38 ` Nuno Sá
2024-02-20 11:25 ` Ceclan Dumitru
2024-02-20 12:15 ` Nuno Sá
2024-02-20 12:20 ` Nuno Sá
2024-02-20 14:19 ` Andy Shevchenko
2024-02-20 18:52 ` Conor Dooley [this message]
2024-02-24 18:29 ` [PATCH v13 1/3] dt-bindings: adc: add AD7173 Jonathan Cameron
2024-02-20 20:54 ` David Lechner
2024-02-21 8:29 ` Ceclan Dumitru
2024-02-21 20:00 ` Conor Dooley
2024-02-24 17:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220-outmost-flavoring-b2593160de91@spud \
--to=conor@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=haibo.chen@nxp.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mike.looijmans@topic.nl \
--cc=mitrutzceclan@gmail.com \
--cc=robh+dt@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.