All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy@kernel.org>
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
	linux-gpio@vger.kernel.org,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michael Walle" <michael@walle.cc>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"ChiaEn Wu" <chiaen_wu@richtek.com>,
	"Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection
Date: Tue, 20 Feb 2024 16:11:21 +0200	[thread overview]
Message-ID: <ZdSzCe2cw8gL3K-W@smile.fi.intel.com> (raw)
In-Reply-To: <20240220094344.17556-2-mitrutzceclan@gmail.com>

On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote:
> Add optional irq_num attribute to ad_sigma_delta_info structure for
> selecting the used interrupt line for adc's conversion completion.

...

> +	if (!info->irq_num)
> +		sigma_delta->irq_num = spi->irq;
> +	else
> +		sigma_delta->irq_num = info->irq_num;

Why not positive check?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-02-20 14:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20  9:43 [PATCH v13 1/3] dt-bindings: adc: add AD7173 Dumitru Ceclan
2024-02-20  9:43 ` [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection Dumitru Ceclan
2024-02-20 14:11   ` Andy Shevchenko [this message]
2024-02-20 14:13     ` Ceclan Dumitru
2024-02-20 14:17       ` Andy Shevchenko
2024-02-24 17:02         ` Jonathan Cameron
2024-02-20  9:43 ` [PATCH v13 3/3] iio: adc: ad7173: add AD7173 driver Dumitru Ceclan
2024-02-20 10:38   ` Nuno Sá
2024-02-20 11:25     ` Ceclan Dumitru
2024-02-20 12:15       ` Nuno Sá
2024-02-20 12:20   ` Nuno Sá
2024-02-20 14:19     ` Andy Shevchenko
2024-02-20 18:52 ` [PATCH v13 1/3] dt-bindings: adc: add AD7173 Conor Dooley
2024-02-24 18:29   ` Jonathan Cameron
2024-02-20 20:54 ` David Lechner
2024-02-21  8:29   ` Ceclan Dumitru
2024-02-21 20:00     ` Conor Dooley
2024-02-24 17:07     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdSzCe2cw8gL3K-W@smile.fi.intel.com \
    --to=andy@kernel.org \
    --cc=arnd@arndb.de \
    --cc=brgl@bgdev.pl \
    --cc=chiaen_wu@richtek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=dumitru.ceclan@analog.com \
    --cc=haibo.chen@nxp.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.goehrs@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=mike.looijmans@topic.nl \
    --cc=mitrutzceclan@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=schnelle@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.