From: Xu Yang <xu.yang_2@nxp.com> To: Frank.li@nxp.com, will@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com Cc: mike.leach@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, adrian.hunter@intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH v6 5/7] perf: imx_perf: fix counter start and config sequence Date: Thu, 7 Mar 2024 17:57:28 +0800 [thread overview] Message-ID: <20240307095730.3792680-5-xu.yang_2@nxp.com> (raw) In-Reply-To: <20240307095730.3792680-1-xu.yang_2@nxp.com> In current driver, the counter will start firstly and then be configured. This sequence is not correct for AXI filter events since the correct AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v5: - new patch Changes in v6: - no changes --- drivers/perf/fsl_imx9_ddr_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c index 4e8a3a4349c5..52234b97d0cb 100644 --- a/drivers/perf/fsl_imx9_ddr_perf.c +++ b/drivers/perf/fsl_imx9_ddr_perf.c @@ -543,12 +543,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags) hwc->idx = counter; hwc->state |= PERF_HES_STOPPED; - if (flags & PERF_EF_START) - ddr_perf_event_start(event, flags); - /* read trans, write trans, read beat */ imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2); + if (flags & PERF_EF_START) + ddr_perf_event_start(event, flags); + return 0; } -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Xu Yang <xu.yang_2@nxp.com> To: Frank.li@nxp.com, will@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com Cc: mike.leach@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, adrian.hunter@intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH v6 5/7] perf: imx_perf: fix counter start and config sequence Date: Thu, 7 Mar 2024 17:57:28 +0800 [thread overview] Message-ID: <20240307095730.3792680-5-xu.yang_2@nxp.com> (raw) In-Reply-To: <20240307095730.3792680-1-xu.yang_2@nxp.com> In current driver, the counter will start firstly and then be configured. This sequence is not correct for AXI filter events since the correct AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v5: - new patch Changes in v6: - no changes --- drivers/perf/fsl_imx9_ddr_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c index 4e8a3a4349c5..52234b97d0cb 100644 --- a/drivers/perf/fsl_imx9_ddr_perf.c +++ b/drivers/perf/fsl_imx9_ddr_perf.c @@ -543,12 +543,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags) hwc->idx = counter; hwc->state |= PERF_HES_STOPPED; - if (flags & PERF_EF_START) - ddr_perf_event_start(event, flags); - /* read trans, write trans, read beat */ imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2); + if (flags & PERF_EF_START) + ddr_perf_event_start(event, flags); + return 0; } -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-07 9:57 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-07 9:57 [PATCH v6 1/7] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 9:57 ` [PATCH v6 2/7] perf: imx_perf: add macro definitions for parsing config attr Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 16:42 ` Frank Li 2024-03-07 16:42 ` Frank Li 2024-03-08 3:36 ` Xu Yang 2024-03-08 3:36 ` Xu Yang 2024-03-07 9:57 ` [PATCH v6 3/7] perf: imx_perf: let the driver manage the counter usage rather the user Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 9:57 ` [PATCH v6 4/7] perf: imx_perf: refactor driver for imx93 Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 16:55 ` Frank Li 2024-03-07 16:55 ` Frank Li 2024-03-08 7:32 ` Xu Yang 2024-03-08 7:32 ` Xu Yang 2024-03-07 9:57 ` Xu Yang [this message] 2024-03-07 9:57 ` [PATCH v6 5/7] perf: imx_perf: fix counter start and config sequence Xu Yang 2024-03-07 9:57 ` [PATCH v6 6/7] perf: imx_perf: add support for i.MX95 platform Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 17:05 ` Frank Li 2024-03-07 17:05 ` Frank Li 2024-03-07 22:45 ` Frank Li 2024-03-07 22:45 ` Frank Li 2024-03-07 9:57 ` [PATCH v6 7/7] perf vendor events arm64:: Add i.MX95 DDR Performance Monitor metrics Xu Yang 2024-03-07 9:57 ` Xu Yang 2024-03-07 13:02 ` John Garry 2024-03-07 13:02 ` John Garry 2024-03-08 3:30 ` [EXT] " Xu Yang 2024-03-08 3:30 ` Xu Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240307095730.3792680-5-xu.yang_2@nxp.com \ --to=xu.yang_2@nxp.com \ --cc=Frank.li@nxp.com \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=imx@lists.linux.dev \ --cc=irogers@google.com \ --cc=john.g.garry@oracle.com \ --cc=jolsa@kernel.org \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.