From: Conor Dooley <conor@kernel.org> To: Frank Li <Frank.Li@nxp.com> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com> Subject: Re: [PATCH v5 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Date: Fri, 8 Mar 2024 16:33:16 +0000 [thread overview] Message-ID: <20240308-flyaway-hangup-112b11535823@spud> (raw) In-Reply-To: <20240307-asrc_8qxp-v5-3-db363740368d@nxp.com> [-- Attachment #1: Type: text/plain, Size: 1490 bytes --] On Thu, Mar 07, 2024 at 02:19:10PM -0500, Frank Li wrote: > Some sai only connect one direction dma (rx/tx) in SOC. For example: > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx" > for dma-names. > > Remove description under dmas because no user use index to get dma channel. > All user use 'dma-names' to get correct dma channel. dma-names already in > 'required' list. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Could you please drop the ack when you change a patch significantly between versions? > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > index 2456d958adeef..93e7737a49a7b 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > @@ -81,15 +81,13 @@ properties: > > dmas: > minItems: 1 > - items: > - - description: DMA controller phandle and request line for RX > - - description: DMA controller phandle and request line for TX > + maxItems: 2 > > dma-names: > minItems: 1 > + maxItems: 2 > items: > - - const: rx > - - const: tx > + enum: [ rx, tx ] > > interrupts: > items: > > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org> To: Frank Li <Frank.Li@nxp.com> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com> Subject: Re: [PATCH v5 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Date: Fri, 8 Mar 2024 16:33:16 +0000 [thread overview] Message-ID: <20240308-flyaway-hangup-112b11535823@spud> (raw) In-Reply-To: <20240307-asrc_8qxp-v5-3-db363740368d@nxp.com> [-- Attachment #1.1: Type: text/plain, Size: 1490 bytes --] On Thu, Mar 07, 2024 at 02:19:10PM -0500, Frank Li wrote: > Some sai only connect one direction dma (rx/tx) in SOC. For example: > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx" > for dma-names. > > Remove description under dmas because no user use index to get dma channel. > All user use 'dma-names' to get correct dma channel. dma-names already in > 'required' list. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Could you please drop the ack when you change a patch significantly between versions? > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > index 2456d958adeef..93e7737a49a7b 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > @@ -81,15 +81,13 @@ properties: > > dmas: > minItems: 1 > - items: > - - description: DMA controller phandle and request line for RX > - - description: DMA controller phandle and request line for TX > + maxItems: 2 > > dma-names: > minItems: 1 > + maxItems: 2 > items: > - - const: rx > - - const: tx > + enum: [ rx, tx ] > > interrupts: > items: > > -- > 2.34.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-08 16:33 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-07 19:19 [PATCH v5 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li 2024-03-07 19:19 ` Frank Li 2024-03-07 19:19 ` [PATCH v5 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property Frank Li 2024-03-07 19:19 ` Frank Li 2024-03-07 19:19 ` [PATCH v5 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Frank Li 2024-03-07 19:19 ` Frank Li 2024-03-07 22:03 ` Rob Herring 2024-03-07 22:03 ` Rob Herring 2024-03-07 22:22 ` Frank Li 2024-03-07 22:22 ` Frank Li 2024-03-07 19:19 ` [PATCH v5 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Frank Li 2024-03-07 19:19 ` Frank Li 2024-03-08 16:33 ` Conor Dooley [this message] 2024-03-08 16:33 ` Conor Dooley 2024-03-07 19:19 ` [PATCH v5 4/4] arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif0 and sai[4,5] Frank Li 2024-03-07 19:19 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240308-flyaway-hangup-112b11535823@spud \ --to=conor@kernel.org \ --cc=Frank.Li@nxp.com \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=conor.dooley@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=imx@lists.linux.dev \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sound@vger.kernel.org \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=shengjiu.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.