From: Linus Walleij <linus.walleij@linaro.org> To: Russell King <linux@armlinux.org.uk>, Sami Tolvanen <samitolvanen@google.com>, Kees Cook <keescook@chromium.org>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v3 5/9] ARM: delay: Turn delay functions into static inlines Date: Mon, 11 Mar 2024 10:15:42 +0100 [thread overview] Message-ID: <20240311-arm32-cfi-v3-5-224a0f0a45c2@linaro.org> (raw) In-Reply-To: <20240311-arm32-cfi-v3-0-224a0f0a45c2@linaro.org> The members of the vector table arm_delay_ops are called directly using defines, but this is really confusing for KCFI. Wrap the calls in static inlines and tag them with __nocfi so things start to work. Without this patch, platforms without a delay timer will not boot (sticks in calibrating loop etc). Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/include/asm/delay.h | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/include/asm/delay.h b/arch/arm/include/asm/delay.h index 1d069e558d8d..7d611b810b6c 100644 --- a/arch/arm/include/asm/delay.h +++ b/arch/arm/include/asm/delay.h @@ -55,7 +55,10 @@ extern struct arm_delay_ops { unsigned long ticks_per_jiffy; } arm_delay_ops; -#define __delay(n) arm_delay_ops.delay(n) +static inline void __nocfi __delay(unsigned long n) +{ + arm_delay_ops.delay(n); +} /* * This function intentionally does not exist; if you see references to @@ -76,8 +79,15 @@ extern void __bad_udelay(void); * first constant multiplications gets optimized away if the delay is * a constant) */ -#define __udelay(n) arm_delay_ops.udelay(n) -#define __const_udelay(n) arm_delay_ops.const_udelay(n) +static inline void __nocfi __udelay(unsigned long n) +{ + arm_delay_ops.udelay(n); +} + +static inline void __nocfi __const_udelay(unsigned long n) +{ + arm_delay_ops.const_udelay(n); +} #define udelay(n) \ (__builtin_constant_p(n) ? \ -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Russell King <linux@armlinux.org.uk>, Sami Tolvanen <samitolvanen@google.com>, Kees Cook <keescook@chromium.org>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v3 5/9] ARM: delay: Turn delay functions into static inlines Date: Mon, 11 Mar 2024 10:15:42 +0100 [thread overview] Message-ID: <20240311-arm32-cfi-v3-5-224a0f0a45c2@linaro.org> (raw) In-Reply-To: <20240311-arm32-cfi-v3-0-224a0f0a45c2@linaro.org> The members of the vector table arm_delay_ops are called directly using defines, but this is really confusing for KCFI. Wrap the calls in static inlines and tag them with __nocfi so things start to work. Without this patch, platforms without a delay timer will not boot (sticks in calibrating loop etc). Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/include/asm/delay.h | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/include/asm/delay.h b/arch/arm/include/asm/delay.h index 1d069e558d8d..7d611b810b6c 100644 --- a/arch/arm/include/asm/delay.h +++ b/arch/arm/include/asm/delay.h @@ -55,7 +55,10 @@ extern struct arm_delay_ops { unsigned long ticks_per_jiffy; } arm_delay_ops; -#define __delay(n) arm_delay_ops.delay(n) +static inline void __nocfi __delay(unsigned long n) +{ + arm_delay_ops.delay(n); +} /* * This function intentionally does not exist; if you see references to @@ -76,8 +79,15 @@ extern void __bad_udelay(void); * first constant multiplications gets optimized away if the delay is * a constant) */ -#define __udelay(n) arm_delay_ops.udelay(n) -#define __const_udelay(n) arm_delay_ops.const_udelay(n) +static inline void __nocfi __udelay(unsigned long n) +{ + arm_delay_ops.udelay(n); +} + +static inline void __nocfi __const_udelay(unsigned long n) +{ + arm_delay_ops.const_udelay(n); +} #define udelay(n) \ (__builtin_constant_p(n) ? \ -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-11 9:15 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-11 9:15 [PATCH v3 0/9] CFI for ARM32 using LLVM Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 1/9] ARM: Support CLANG CFI Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 10:24 ` Ard Biesheuvel 2024-03-11 10:24 ` Ard Biesheuvel 2024-03-11 9:15 ` [PATCH v3 2/9] ARM: tlbflush: Make TLB flushes into static inlines Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:39 ` Russell King (Oracle) 2024-03-11 9:39 ` Russell King (Oracle) 2024-03-11 10:03 ` Ard Biesheuvel 2024-03-11 10:03 ` Ard Biesheuvel 2024-03-11 15:34 ` Sami Tolvanen 2024-03-11 15:34 ` Sami Tolvanen 2024-03-11 19:50 ` Linus Walleij 2024-03-11 19:50 ` Linus Walleij 2024-03-11 21:36 ` Sami Tolvanen 2024-03-11 21:36 ` Sami Tolvanen 2024-03-11 22:17 ` Linus Walleij 2024-03-11 22:17 ` Linus Walleij 2024-03-11 22:28 ` Sami Tolvanen 2024-03-11 22:28 ` Sami Tolvanen 2024-03-11 23:56 ` Linus Walleij 2024-03-11 23:56 ` Linus Walleij 2024-03-12 7:24 ` Ard Biesheuvel 2024-03-12 7:24 ` Ard Biesheuvel 2024-03-12 8:14 ` Linus Walleij 2024-03-12 8:14 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 3/9] ARM: bugs: Check in the vtable instead of defined aliases Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 4/9] ARM: proc: Use inlines instead of defines Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:15 ` Linus Walleij [this message] 2024-03-11 9:15 ` [PATCH v3 5/9] ARM: delay: Turn delay functions into static inlines Linus Walleij 2024-03-11 12:26 ` Ard Biesheuvel 2024-03-11 12:26 ` Ard Biesheuvel 2024-03-11 9:15 ` [PATCH v3 6/9] ARM: turn CPU cache flush " Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 7/9] ARM: page: Turn highpage accesses " Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 12:15 ` Ard Biesheuvel 2024-03-11 12:15 ` Ard Biesheuvel 2024-03-28 8:18 ` Linus Walleij 2024-03-28 8:18 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 8/9] ARM: ftrace: Define ftrace_stub_graph Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 9:15 ` [PATCH v3 9/9] ARM: KCFI: Allow permissive CFI mode Linus Walleij 2024-03-11 9:15 ` Linus Walleij 2024-03-11 22:03 ` Kees Cook 2024-03-11 22:03 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240311-arm32-cfi-v3-5-224a0f0a45c2@linaro.org \ --to=linus.walleij@linaro.org \ --cc=ardb@kernel.org \ --cc=arnd@arndb.de \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=llvm@lists.linux.dev \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=samitolvanen@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.