From: Dhruva Gole <d-gole@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sibi Sankar <quic_sibis@quicinc.com>, <dietmar.eggemann@arm.com>,
<rafael@kernel.org>, <xuwei5@hisilicon.com>,
<zhanjie9@hisilicon.com>, <sudeep.holla@arm.com>,
<cristian.marussi@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_rgottimu@quicinc.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw
Date: Mon, 11 Mar 2024 10:56:51 +0530 [thread overview]
Message-ID: <20240311052651.uedxt2wvywqlrsac@dhruva> (raw)
In-Reply-To: <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7>
Hi,
On Mar 11, 2024 at 10:20:44 +0530, Viresh Kumar wrote:
> On 08-03-24, 16:06, Sibi Sankar wrote:
> > + /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
> > + if (cpufreq_driver->boost_enabled)
> > + policy->boost_enabled = policy_has_boost_freq(policy) ? true : false;
>
> Can be written as:
>
> policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
I would like to recommend the same.
>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Rest looks fine,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva Gole <d-gole@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Dhruva Gole <d-gole@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sibi Sankar <quic_sibis@quicinc.com>, <dietmar.eggemann@arm.com>,
<rafael@kernel.org>, <xuwei5@hisilicon.com>,
<zhanjie9@hisilicon.com>, <sudeep.holla@arm.com>,
<cristian.marussi@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_rgottimu@quicinc.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw
Date: Mon, 11 Mar 2024 10:56:51 +0530 [thread overview]
Message-ID: <20240311052651.uedxt2wvywqlrsac@dhruva> (raw)
In-Reply-To: <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7>
Hi,
On Mar 11, 2024 at 10:20:44 +0530, Viresh Kumar wrote:
> On 08-03-24, 16:06, Sibi Sankar wrote:
> > + /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
> > + if (cpufreq_driver->boost_enabled)
> > + policy->boost_enabled = policy_has_boost_freq(policy) ? true : false;
>
> Can be written as:
>
> policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
I would like to recommend the same.
>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Rest looks fine,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva Gole <d-gole@ti.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-11 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 10:36 [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw Sibi Sankar
2024-03-08 10:36 ` Sibi Sankar
2024-03-11 4:50 ` Viresh Kumar
2024-03-11 4:50 ` Viresh Kumar
2024-03-11 5:26 ` Dhruva Gole [this message]
2024-03-11 5:26 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311052651.uedxt2wvywqlrsac@dhruva \
--to=d-gole@ti.com \
--cc=cristian.marussi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_rgottimu@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=xuwei5@hisilicon.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.