From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Anatoliy Klymenko <anatoliy.klymenko@amd.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Michal Simek <michal.simek@amd.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag Date: Tue, 19 Mar 2024 02:12:55 +0200 [thread overview] Message-ID: <20240319001255.GV13682@pendragon.ideasonboard.com> (raw) In-Reply-To: <20240312-dp-live-fmt-v2-4-a9c35dc5c50d@amd.com> Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:55:01PM -0700, Anatoliy Klymenko wrote: > Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer > context. This flag signals whether the driver runs in DRM CRTC or DRM > bridge mode, assuming that all display layers share the same live or > non-live mode of operation. Using per-layer mode instead of global flag > will siplify future support of the hybrid scenario. s/siplify/simplify/ > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com> > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index af851190f447..dd48fa60fa9a 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -975,7 +975,7 @@ void zynqmp_disp_layer_disable(struct zynqmp_disp_layer *layer) > { > unsigned int i; > > - if (layer->disp->dpsub->dma_enabled) { > + if (layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE) { > for (i = 0; i < layer->drm_fmt->num_planes; i++) > dmaengine_terminate_sync(layer->dmas[i].chan); > } > @@ -1001,7 +1001,7 @@ void zynqmp_disp_layer_set_format(struct zynqmp_disp_layer *layer, > > zynqmp_disp_avbuf_set_format(layer->disp, layer, layer->disp_fmt); > > - if (!layer->disp->dpsub->dma_enabled) > + if (layer->mode == ZYNQMP_DPSUB_LAYER_LIVE) > return; > > /* > @@ -1039,7 +1039,7 @@ int zynqmp_disp_layer_update(struct zynqmp_disp_layer *layer, > const struct drm_format_info *info = layer->drm_fmt; > unsigned int i; > > - if (!layer->disp->dpsub->dma_enabled) > + if (layer->mode == ZYNQMP_DPSUB_LAYER_LIVE) > return 0; The above changes look nice. > > for (i = 0; i < info->num_planes; i++) { > @@ -1089,7 +1089,7 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp, > { > unsigned int i; > > - if (!layer->info || !disp->dpsub->dma_enabled) > + if (!layer->info) This, however, doesn't seem right, as this function is called unconditionally from the remove path. The change below seems weird too. If I'm missing something, it should at least be explained in the commit message. > return; > > for (i = 0; i < layer->info->num_channels; i++) { > @@ -1132,9 +1132,6 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp, > unsigned int i; > int ret; > > - if (!disp->dpsub->dma_enabled) > - return 0; > - > for (i = 0; i < layer->info->num_channels; i++) { > struct zynqmp_disp_layer_dma *dma = &layer->dmas[i]; > char dma_channel_name[16]; > -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Anatoliy Klymenko <anatoliy.klymenko@amd.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Michal Simek <michal.simek@amd.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag Date: Tue, 19 Mar 2024 02:12:55 +0200 [thread overview] Message-ID: <20240319001255.GV13682@pendragon.ideasonboard.com> (raw) In-Reply-To: <20240312-dp-live-fmt-v2-4-a9c35dc5c50d@amd.com> Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:55:01PM -0700, Anatoliy Klymenko wrote: > Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer > context. This flag signals whether the driver runs in DRM CRTC or DRM > bridge mode, assuming that all display layers share the same live or > non-live mode of operation. Using per-layer mode instead of global flag > will siplify future support of the hybrid scenario. s/siplify/simplify/ > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com> > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index af851190f447..dd48fa60fa9a 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -975,7 +975,7 @@ void zynqmp_disp_layer_disable(struct zynqmp_disp_layer *layer) > { > unsigned int i; > > - if (layer->disp->dpsub->dma_enabled) { > + if (layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE) { > for (i = 0; i < layer->drm_fmt->num_planes; i++) > dmaengine_terminate_sync(layer->dmas[i].chan); > } > @@ -1001,7 +1001,7 @@ void zynqmp_disp_layer_set_format(struct zynqmp_disp_layer *layer, > > zynqmp_disp_avbuf_set_format(layer->disp, layer, layer->disp_fmt); > > - if (!layer->disp->dpsub->dma_enabled) > + if (layer->mode == ZYNQMP_DPSUB_LAYER_LIVE) > return; > > /* > @@ -1039,7 +1039,7 @@ int zynqmp_disp_layer_update(struct zynqmp_disp_layer *layer, > const struct drm_format_info *info = layer->drm_fmt; > unsigned int i; > > - if (!layer->disp->dpsub->dma_enabled) > + if (layer->mode == ZYNQMP_DPSUB_LAYER_LIVE) > return 0; The above changes look nice. > > for (i = 0; i < info->num_planes; i++) { > @@ -1089,7 +1089,7 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp, > { > unsigned int i; > > - if (!layer->info || !disp->dpsub->dma_enabled) > + if (!layer->info) This, however, doesn't seem right, as this function is called unconditionally from the remove path. The change below seems weird too. If I'm missing something, it should at least be explained in the commit message. > return; > > for (i = 0; i < layer->info->num_channels; i++) { > @@ -1132,9 +1132,6 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp, > unsigned int i; > int ret; > > - if (!disp->dpsub->dma_enabled) > - return 0; > - > for (i = 0; i < layer->info->num_channels; i++) { > struct zynqmp_disp_layer_dma *dma = &layer->dmas[i]; > char dma_channel_name[16]; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-19 0:12 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-13 0:54 [PATCH v2 0/8] Setting live video input format for ZynqMP DPSUB Anatoliy Klymenko 2024-03-13 0:54 ` Anatoliy Klymenko 2024-03-13 0:54 ` [PATCH v2 1/8] drm: xlnx: zynqmp_dpsub: Set layer mode during creation Anatoliy Klymenko 2024-03-13 0:54 ` Anatoliy Klymenko 2024-03-13 0:54 ` [PATCH v2 2/8] drm: xlnx: zynqmp_dpsub: Update live format defines Anatoliy Klymenko 2024-03-13 0:54 ` Anatoliy Klymenko 2024-03-18 23:16 ` Laurent Pinchart 2024-03-18 23:16 ` Laurent Pinchart 2024-03-13 0:55 ` [PATCH v2 3/8] drm: xlnx: zynqmp_dpsub: Anounce supported input formats Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-19 0:05 ` Laurent Pinchart 2024-03-19 0:05 ` Laurent Pinchart 2024-03-20 0:57 ` Klymenko, Anatoliy 2024-03-20 0:57 ` Klymenko, Anatoliy 2024-03-13 0:55 ` [PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-19 0:12 ` Laurent Pinchart [this message] 2024-03-19 0:12 ` Laurent Pinchart 2024-03-20 1:12 ` Klymenko, Anatoliy 2024-03-20 1:12 ` Klymenko, Anatoliy 2024-03-13 0:55 ` [PATCH v2 5/8] drm: xlnx: zynqmp_dpsub: Set input live format Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-19 0:35 ` Laurent Pinchart 2024-03-19 0:35 ` Laurent Pinchart 2024-03-20 1:25 ` Klymenko, Anatoliy 2024-03-20 1:25 ` Klymenko, Anatoliy 2024-03-13 0:55 ` [PATCH v2 6/8] drm/atomic-helper: Add select_output_bus_format callback Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-13 0:55 ` [PATCH v2 7/8] dt-bindings: xlnx: Add VTC and TPG bindings Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-13 2:30 ` Rob Herring 2024-03-13 2:30 ` Rob Herring 2024-03-13 7:27 ` Krzysztof Kozlowski 2024-03-13 7:27 ` Krzysztof Kozlowski 2024-03-13 0:55 ` [PATCH v2 8/8] drm: xlnx: Intoduce TPG CRTC driver Anatoliy Klymenko 2024-03-13 0:55 ` Anatoliy Klymenko 2024-03-14 12:05 ` Maxime Ripard 2024-03-14 12:05 ` Maxime Ripard 2024-03-14 19:43 ` Klymenko, Anatoliy 2024-03-14 19:43 ` Klymenko, Anatoliy 2024-03-15 15:24 ` Maxime Ripard 2024-03-15 15:24 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240319001255.GV13682@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@gmail.com \ --cc=anatoliy.klymenko@amd.com \ --cc=andrzej.hajda@intel.com \ --cc=conor+dt@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mchehab@kernel.org \ --cc=michal.simek@amd.com \ --cc=mripard@kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=rfoss@kernel.org \ --cc=robh+dt@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.