Re: [PATCH v2 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

From: Conor Dooley <conor@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema
Date: Fri, 22 Mar 2024 17:59:37 +0000	[thread overview]
Message-ID: <20240322-papaya-diabolic-e7c2c4319eb2@spud> (raw)
In-Reply-To: <20240322-hwmon_dtschema-v2-2-570bee1acecb@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3029 bytes --]

On Fri, Mar 22, 2024 at 07:45:27AM +0100, Javier Carrasco wrote:
> Convert existing binding to support validation.
> 
> This is a straightforward conversion with now new properties.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>  .../devicetree/bindings/hwmon/ibm,powernv.yaml     | 37 ++++++++++++++++++++++
>  .../devicetree/bindings/hwmon/ibmpowernv.txt       | 23 --------------
>  2 files changed, 37 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ibm,powernv.yaml b/Documentation/devicetree/bindings/hwmon/ibm,powernv.yaml
> new file mode 100644
> index 000000000000..b26d42bce938
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ibm,powernv.yaml

Filename should really match one of the compatibles. "powernv" is not a
type of hwmon as far as a quick google reports so I think its a poor
choice here regardless. With a compatible for the filename:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ibm,powernv.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IBM POWERNV platform sensors
> +
> +maintainers:
> +  - Javier Carrasco <javier.carrasco.cruz@gmail.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ibm,opal-sensor-cooling-fan
> +      - ibm,opal-sensor-amb-temp
> +      - ibm,opal-sensor-power-supply
> +      - ibm,opal-sensor-power
> +
> +  sensor-id:
> +    description:
> +      An opaque id provided by the firmware to the kernel, identifies a
> +      given sensor and its attribute data.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> +  - compatible
> +  - sensor-id
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sensor {
> +        compatible = "ibm,opal-sensor-cooling-fan";
> +        sensor-id = <0x7052107>;
> +    };
> diff --git a/Documentation/devicetree/bindings/hwmon/ibmpowernv.txt b/Documentation/devicetree/bindings/hwmon/ibmpowernv.txt
> deleted file mode 100644
> index f93242be60a1..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ibmpowernv.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -IBM POWERNV platform sensors
> -----------------------------
> -
> -Required node properties:
> -- compatible: must be one of
> -		"ibm,opal-sensor-cooling-fan"
> -		"ibm,opal-sensor-amb-temp"
> -		"ibm,opal-sensor-power-supply"
> -		"ibm,opal-sensor-power"
> -- sensor-id: an opaque id provided by the firmware to the kernel, identifies a
> -	     given sensor and its attribute data
> -
> -Example sensors node:
> -
> -cooling-fan#8-data {
> -	sensor-id = <0x7052107>;
> -	compatible = "ibm,opal-sensor-cooling-fan";
> -};
> -
> -amb-temp#1-thrs {
> -	sensor-id = <0x5096000>;
> -	compatible = "ibm,opal-sensor-amb-temp";
> -};
> 
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]