Re: [XEN v6 1/3] xen/arm: Introduce CONFIG_PARTIAL_EMULATION and "partial-emulation" cmd option

From: Julien Grall <julien@xen.org>
To: Ayan Kumar Halder <ayan.kumar.halder@amd.com>,
	xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefano.stabellini@amd.com,
	Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
	michal.orzel@amd.com
Subject: Re: [XEN v6 1/3] xen/arm: Introduce CONFIG_PARTIAL_EMULATION and "partial-emulation" cmd option
Date: Tue, 12 Mar 2024 22:25:29 +0000	[thread overview]
Message-ID: <20531f63-d342-4ce5-88fb-01b7431ebd96@xen.org> (raw)
In-Reply-To: <20240307123943.1991755-2-ayan.kumar.halder@amd.com>

Hi,

On 07/03/2024 12:39, Ayan Kumar Halder wrote:
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 7eb6875cfa..b49da114ab 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -102,6 +102,15 @@ Extension to the GICv3 interrupt controller to support MSI.
>   
>       Status: Experimental
>   
> +### ARM/Partial Emulation
> +
> +Enable partial emulation of registers, otherwise considered unimplemented,
> +that would normally trigger a fault injection.
> +
> +    Status: Supported, with caveats
> +
> +Only the following system registers are security supported:

This reads slightly odd. I would have have expected a few more registers 
afterwards. I would have considered to move this sentence to patch #2 or 
maybe N/A. Anyway, that's not too important (the patch doesn't make 
sense without the next one). So:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall