From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>, <bpf@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API
Date: Tue, 17 Oct 2023 15:56:48 +0800 [thread overview]
Message-ID: <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com> (raw)
In-Reply-To: <20231016182725.6aa5544f@kernel.org>
On 2023/10/17 9:27, Jakub Kicinski wrote:
> On Fri, 13 Oct 2023 14:48:20 +0800 Yunsheng Lin wrote:
>> v5 RFC: Add a new page_pool_cache_alloc() API, and other minor
>> change as discussed in v4. As there seems to be three
>> comsumers that might be made use of the new API, so
>> repost it as RFC and CC the relevant authors to see
>> if the new API fits their need.
>
> I have looked thru the v4 discussion (admittedly it was pretty huge).
> I can't find where the "cache" API was suggested.
Actually, the discussion happened in V3 as both of discussions in V3
and V4 seems to be happening concurrently:
https://lore.kernel.org/all/f8ce176f-f975-af11-641c-b56c53a8066a@redhat.com/
> And I can't figure out now what the "cache" in the name is referring to.
> Looks like these are just convenience wrappers which return VA instead
> of struct page..
Yes, it is corresponding to some API like napi_alloc_frag() returning va
instead of 'struct page' mentioned in patch 5.
Anyway, naming is hard, any suggestion for a better naming is always
welcomed:)
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>, <bpf@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API
Date: Tue, 17 Oct 2023 15:56:48 +0800 [thread overview]
Message-ID: <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com> (raw)
In-Reply-To: <20231016182725.6aa5544f@kernel.org>
On 2023/10/17 9:27, Jakub Kicinski wrote:
> On Fri, 13 Oct 2023 14:48:20 +0800 Yunsheng Lin wrote:
>> v5 RFC: Add a new page_pool_cache_alloc() API, and other minor
>> change as discussed in v4. As there seems to be three
>> comsumers that might be made use of the new API, so
>> repost it as RFC and CC the relevant authors to see
>> if the new API fits their need.
>
> I have looked thru the v4 discussion (admittedly it was pretty huge).
> I can't find where the "cache" API was suggested.
Actually, the discussion happened in V3 as both of discussions in V3
and V4 seems to be happening concurrently:
https://lore.kernel.org/all/f8ce176f-f975-af11-641c-b56c53a8066a@redhat.com/
> And I can't figure out now what the "cache" in the name is referring to.
> Looks like these are just convenience wrappers which return VA instead
> of struct page..
Yes, it is corresponding to some API like napi_alloc_frag() returning va
instead of 'struct page' mentioned in patch 5.
Anyway, naming is hard, any suggestion for a better naming is always
welcomed:)
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-17 7:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 6:48 [PATCH net-next v11 0/6] introduce page_pool_alloc() related API Yunsheng Lin
2023-10-13 6:48 ` Yunsheng Lin
2023-10-13 6:48 ` [PATCH net-next v11 1/6] page_pool: fragment API support for 32-bit arch with 64-bit DMA Yunsheng Lin
2023-10-17 1:31 ` Jakub Kicinski
2023-10-17 12:05 ` Ilias Apalodimas
2023-10-17 12:17 ` Ilias Apalodimas
2023-10-17 12:53 ` Yunsheng Lin
2023-10-17 13:02 ` Ilias Apalodimas
2023-10-13 6:48 ` [PATCH net-next v11 2/6] page_pool: unify frag_count handling in page_pool_is_last_frag() Yunsheng Lin
2023-10-13 6:48 ` [PATCH net-next v11 3/6] page_pool: remove PP_FLAG_PAGE_FRAG Yunsheng Lin
2023-10-13 6:48 ` [Intel-wired-lan] " Yunsheng Lin
2023-10-13 6:48 ` Yunsheng Lin
2023-10-13 6:48 ` [PATCH net-next v11 4/6] page_pool: introduce page_pool[_cache]_alloc() API Yunsheng Lin
2023-10-13 6:48 ` [PATCH net-next v11 5/6] page_pool: update document about fragment API Yunsheng Lin
2023-10-13 6:48 ` [PATCH net-next v11 6/6] net: veth: use newly added page pool API for veth with xdp Yunsheng Lin
2023-10-17 1:27 ` [PATCH net-next v11 0/6] introduce page_pool_alloc() related API Jakub Kicinski
2023-10-17 1:27 ` Jakub Kicinski
2023-10-17 7:56 ` Yunsheng Lin [this message]
2023-10-17 7:56 ` Yunsheng Lin
2023-10-17 15:13 ` Jakub Kicinski
2023-10-17 15:13 ` Jakub Kicinski
2023-10-17 15:14 ` Jakub Kicinski
2023-10-17 15:14 ` Jakub Kicinski
2023-10-18 11:47 ` Yunsheng Lin
2023-10-18 11:47 ` Yunsheng Lin
2023-10-18 15:35 ` Jakub Kicinski
2023-10-18 15:35 ` Jakub Kicinski
2023-10-19 13:22 ` Yunsheng Lin
2023-10-19 13:22 ` Yunsheng Lin
2023-10-19 13:56 ` Jakub Kicinski
2023-10-19 13:56 ` Jakub Kicinski
2023-10-17 4:10 ` patchwork-bot+netdevbpf
2023-10-17 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com \
--to=linyunsheng@huawei.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.