From: Stefan Wahren <stefan.wahren@i2se.com> To: Horia Geanta <horia.geanta@nxp.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, arm-soc <arm@kernel.org>, Marc Gonzalez <marc.w.gonzalez@free.fr>, Olof Johansson <olof@lixom.net>, LKML <linux-kernel@vger.kernel.org>, linux-next@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Date: Tue, 18 Dec 2018 21:10:30 +0100 (CET) [thread overview] Message-ID: <2071995319.127120.1545163830046@email.ionos.de> (raw) In-Reply-To: <VI1PR0402MB3485A452549CF37694720A7B98BC0@VI1PR0402MB3485.eurprd04.prod.outlook.com> Hi Horia, > Horia Geanta <horia.geanta@nxp.com> hat am 17. Dezember 2018 um 16:33 geschrieben: > > > On 12/15/2018 11:44 PM, Stefan Wahren wrote: > > Hi, > > > >> Olof Johansson <olof@lixom.net> hat am 13. Dezember 2018 um 07:48 geschrieben: > >> > >> > >> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote: > >>> On 11/9/2018 3:11 AM, Marc Gonzalez wrote: > >>>> Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs") > >>>> enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO, > >>>> which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and > >>>> CRYPTO_DEV_FSL_DPAA2_CAAM as modules. > >>>> > >>>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > >>> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> > >> > >> I had to redo this one, and when I did I noticed that there's also an ethernet > >> driver. Should that be enabled as well? > >> > > > > this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine: > > > > DEPMOD 4.20.0-rc6-next-20181214 > > depmod: ERROR: Found 6 modules in dependency cycles! > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio > > depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc > > > > After reverting of this patch the issue disappeared. > > > Seems there's a dependency cycle b/w dpaa2_caam and caam{alg,hash}_desc, as follows: > > A->B > --- > dpaa2_caam needs cnstr_* exported by caam{alg,hash}_desc > > B->A > --- > caam{alg,hash}_desc need caam_imx, caam_little_end: > caam{hash,alg}_desc.c > --> desc_constr.h (included for descriptors generation functions) > --> regs.h (included for endianness helpers) > --> extern bool caam_imx, caam_little_end > caam_imx, caam_little_end are exported by dpaa2_caam - caamalg_qi2.c (when > CONFIG_CRYPTO_DEV_FSL_CAAM=n) > > Could we drop this patch, until CAAM driver gets a proper fix (which is not > straightforward)? this issue still persists in 4.20.0-rc7-next-20181218. Could you please send a patch to revert this change? Thanks Stefan > > Thanks, > Horia > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com> To: Horia Geanta <horia.geanta@nxp.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, arm-soc <arm@kernel.org>, Marc Gonzalez <marc.w.gonzalez@free.fr>, LKML <linux-kernel@vger.kernel.org>, linux-next@vger.kernel.org, Olof Johansson <olof@lixom.net>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Date: Tue, 18 Dec 2018 21:10:30 +0100 (CET) [thread overview] Message-ID: <2071995319.127120.1545163830046@email.ionos.de> (raw) In-Reply-To: <VI1PR0402MB3485A452549CF37694720A7B98BC0@VI1PR0402MB3485.eurprd04.prod.outlook.com> Hi Horia, > Horia Geanta <horia.geanta@nxp.com> hat am 17. Dezember 2018 um 16:33 geschrieben: > > > On 12/15/2018 11:44 PM, Stefan Wahren wrote: > > Hi, > > > >> Olof Johansson <olof@lixom.net> hat am 13. Dezember 2018 um 07:48 geschrieben: > >> > >> > >> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote: > >>> On 11/9/2018 3:11 AM, Marc Gonzalez wrote: > >>>> Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs") > >>>> enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO, > >>>> which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and > >>>> CRYPTO_DEV_FSL_DPAA2_CAAM as modules. > >>>> > >>>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > >>> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> > >> > >> I had to redo this one, and when I did I noticed that there's also an ethernet > >> driver. Should that be enabled as well? > >> > > > > this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine: > > > > DEPMOD 4.20.0-rc6-next-20181214 > > depmod: ERROR: Found 6 modules in dependency cycles! > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio > > depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc > > > > After reverting of this patch the issue disappeared. > > > Seems there's a dependency cycle b/w dpaa2_caam and caam{alg,hash}_desc, as follows: > > A->B > --- > dpaa2_caam needs cnstr_* exported by caam{alg,hash}_desc > > B->A > --- > caam{alg,hash}_desc need caam_imx, caam_little_end: > caam{hash,alg}_desc.c > --> desc_constr.h (included for descriptors generation functions) > --> regs.h (included for endianness helpers) > --> extern bool caam_imx, caam_little_end > caam_imx, caam_little_end are exported by dpaa2_caam - caamalg_qi2.c (when > CONFIG_CRYPTO_DEV_FSL_CAAM=n) > > Could we drop this patch, until CAAM driver gets a proper fix (which is not > straightforward)? this issue still persists in 4.20.0-rc7-next-20181218. Could you please send a patch to revert this change? Thanks Stefan > > Thanks, > Horia > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 20:11 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-09 0:54 [PATCH v3 0/9] Regenerate arm64 defconfig for current kernel Marc Gonzalez 2018-11-09 0:54 ` Marc Gonzalez 2018-11-09 0:56 ` [PATCH v3 1/9] arm64: defconfig: Regenerate for v4.20 Marc Gonzalez 2018-11-09 0:56 ` Marc Gonzalez 2018-12-13 2:09 ` Olof Johansson 2018-12-13 2:09 ` Olof Johansson 2018-11-09 1:00 ` [PATCH v3 2/9] arm64: defconfig: Drop ARM_BIG_LITTLE_CPUFREQ Marc Gonzalez 2018-11-09 1:00 ` Marc Gonzalez 2018-12-13 2:09 ` Olof Johansson 2018-12-13 2:09 ` Olof Johansson 2018-11-09 1:01 ` [PATCH v3 3/9] arm64: defconfig: Drop NF_CONNTRACK_IPV{4,6} Marc Gonzalez 2018-11-09 1:01 ` Marc Gonzalez 2018-12-13 2:09 ` Olof Johansson 2018-12-13 2:09 ` Olof Johansson 2018-11-09 1:02 ` [PATCH v3 4/9] arm64: defconfig: Drop USB_ULPI_BUS and USB_CHIPIDEA_ULPI Marc Gonzalez 2018-11-09 1:02 ` Marc Gonzalez 2018-12-13 2:14 ` Olof Johansson 2018-12-13 2:14 ` Olof Johansson 2018-11-09 1:03 ` [PATCH v3 5/9] arm64: defconfig: Replace PINCTRL_MT7622 with PINCTRL_MTK_MOORE Marc Gonzalez 2018-11-09 1:03 ` Marc Gonzalez 2018-11-09 13:03 ` Matthias Brugger 2018-11-09 13:03 ` Matthias Brugger 2018-11-09 19:59 ` Marc Gonzalez 2018-11-09 19:59 ` Marc Gonzalez 2018-11-15 16:32 ` Matthias Brugger 2018-11-15 16:32 ` Matthias Brugger 2018-12-13 2:16 ` Olof Johansson 2018-12-13 2:16 ` Olof Johansson 2018-11-09 1:03 ` [PATCH v3 6/9] arm64: defconfig: Drop redundant SND_SOC_ROCKCHIP_I2S Marc Gonzalez 2018-11-09 1:03 ` Marc Gonzalez 2018-12-13 6:47 ` Olof Johansson 2018-12-13 6:47 ` Olof Johansson 2018-11-09 1:07 ` [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Marc Gonzalez 2018-11-09 1:07 ` Marc Gonzalez 2018-11-09 6:05 ` Horia Geanta 2018-11-09 6:05 ` Horia Geanta 2018-12-13 6:48 ` Olof Johansson 2018-12-13 6:48 ` Olof Johansson 2018-12-13 9:18 ` Ioana Ciocoi Radulescu 2018-12-13 9:18 ` Ioana Ciocoi Radulescu 2018-12-15 21:44 ` Stefan Wahren 2018-12-15 21:44 ` Stefan Wahren 2018-12-17 15:33 ` Horia Geanta 2018-12-17 15:33 ` Horia Geanta 2018-12-18 20:10 ` Stefan Wahren [this message] 2018-12-18 20:10 ` Stefan Wahren 2018-12-19 10:18 ` [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" Horia Geantă 2018-12-19 10:18 ` Horia Geantă 2018-12-20 15:27 ` Arnd Bergmann 2018-12-20 15:27 ` Arnd Bergmann 2018-12-20 20:43 ` Horia Geanta 2018-12-20 20:43 ` Horia Geanta 2018-11-09 1:08 ` [PATCH v3 8/9] arm64: defconfig: Change SCSI_UFS_HISI=m Marc Gonzalez 2018-11-09 1:08 ` Marc Gonzalez 2018-12-13 6:48 ` Olof Johansson 2018-12-13 6:48 ` Olof Johansson 2018-11-09 1:08 ` [PATCH v3 9/9] arm64: defconfig: Drop redundant sound codec options Marc Gonzalez 2018-11-09 1:08 ` Marc Gonzalez 2018-12-13 6:50 ` Olof Johansson 2018-12-13 6:50 ` Olof Johansson 2018-12-05 15:33 ` [PATCH v3 0/9] Regenerate arm64 defconfig for current kernel Marc Gonzalez 2018-12-05 15:33 ` Marc Gonzalez 2018-12-11 15:41 ` Olof Johansson 2018-12-11 15:41 ` Olof Johansson 2018-12-13 6:51 ` Olof Johansson 2018-12-13 6:51 ` Olof Johansson 2018-12-14 15:44 ` Marc Gonzalez 2018-12-14 15:44 ` Marc Gonzalez 2018-12-18 15:27 ` Arnd Bergmann 2018-12-18 15:27 ` Arnd Bergmann 2018-12-18 18:31 ` Olof Johansson 2018-12-18 18:31 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2071995319.127120.1545163830046@email.ionos.de \ --to=stefan.wahren@i2se.com \ --cc=arm@kernel.org \ --cc=horia.geanta@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=marc.w.gonzalez@free.fr \ --cc=olof@lixom.net \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.