Re: [PATCH 2/7] dt-bindings: clock: separate bindings for MSM8916 GCC device

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: clock: separate bindings for MSM8916 GCC device
Date: Sun, 19 Jun 2022 14:02:29 +0200	[thread overview]
Message-ID: <20c93477-f41d-69c2-5fa5-3640f24fee12@linaro.org> (raw)
In-Reply-To: <cd4eaead-4218-2de0-1929-7c8a2aafaff4@linaro.org>

On 18/06/2022 06:35, Dmitry Baryshkov wrote:
> On 18/06/2022 04:40, Krzysztof Kozlowski wrote:
>> On 17/06/2022 07:47, Dmitry Baryshkov wrote:
>>> Separate bindings for GCC on Qualcomm MSM8916 platforms. This adds new
>>> clocks/clock-names properties to be used for clock links.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>>   .../bindings/clock/qcom,gcc-msm8916.yaml      | 61 +++++++++++++++++++
>>>   .../bindings/clock/qcom,gcc-other.yaml        |  1 -
>>>   2 files changed, 61 insertions(+), 1 deletion(-)
>>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml
>>> new file mode 100644
>>> index 000000000000..564aa764b17b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml
>>> @@ -0,0 +1,61 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8916.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm Global Clock & Reset Controller Binding for MSM8916
>>> +
>>> +maintainers:
>>> +  - Stephen Boyd <sboyd@kernel.org>
>>> +  - Taniya Das <quic_tdas@quicinc.com>
>>> +
>>> +description: |
>>> +  Qualcomm global clock control module which supports the clocks, resets and
>>> +  power domains on MSM8916.
>>> +
>>> +  See also:
>>> +  - dt-bindings/clock/qcom,gcc-msm8916.h
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: qcom,gcc-msm8916
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: XO source
>>> +      - description: Sleep clock source
>>> +      - description: DSI phy instance 0 dsi clock
>>> +      - description: DSI phy instance 0 byte clock
>>> +      - description: External MCLK clock
>>> +      - description: External Primary I2S clock
>>> +      - description: External Secondary I2S clock
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: xo
>>> +      - const: sleep_clk
>>
>> Just "sleep"
> 
> I was hesitating here as all other gcc drivers use 'sleep_clk'.

Eh, indeed, these are existing bindings and drivers. Let's keep sleep_clk.

Best regards,
Krzysztof