Re: [PATCH 7/7] arm64: dts: qcom: msm8916: add clocks to the GCC device node

From: Stephan Gerhold <stephan@gerhold.net>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Taniya Das <quic_tdas@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: qcom: msm8916: add clocks to the GCC device node
Date: Sat, 18 Jun 2022 15:02:04 +0200	[thread overview]
Message-ID: <Yq3MzJ58d0fbsb3L@gerhold.net> (raw)
In-Reply-To: <CAA8EJpozu6PoWC-kOpFB9OSZLVZaZt6ZkUpYo=bOr0zhErkWqA@mail.gmail.com>

On Fri, Jun 17, 2022 at 11:34:24PM +0300, Dmitry Baryshkov wrote:
> On Fri, 17 Jun 2022 at 20:14, Stephan Gerhold <stephan@gerhold.net> wrote:
> >
> > If we want to change this to the actual votable clock later this should
> > probably be <&rpmcc RPM_SMD_XO_CLK_SRC>. AFAIK that clock exists in RPM
> > on MSM8916 but was never added to the clk-smd-rpm driver (for MSM8916).
> >
> > Not sure where the pin-controlled BB_CLK1 is coming from here. :)
> 
> It came from the schematics I had at hand (db410c). It uses the
> BB_CLK1 together with the enable pin. I'll probably use xo_board for
> now and postpone changing this to rpmcc clock until the next attempt
> to read msm-3.x code.
> 

Hmm, you're right - BB_CLK1 goes to CXO on most MSM8916+PM8916 devices.
I think the msm-3.10 kernel still controls it via the RPM_SMD_XO_CLK_SRC
though. Quite confusing. :)

Thanks,
Stephan