From: Jiri Slaby <jirislaby@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>, linux-serial@vger.kernel.org
Cc: gregkh@linuxfoundation.org, joel@jms.id.au,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
jenmin_yuan@aspeedtech.com, ryan_chen@aspeedtech.com,
miltonm@us.ibm.com
Subject: Re: [PATCH v3 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_*
Date: Thu, 20 May 2021 07:25:13 +0200 [thread overview]
Message-ID: <20eec190-d80e-b32a-8949-e5e2918a110b@kernel.org> (raw)
In-Reply-To: <20210520021334.497341-3-andrew@aj.id.au>
On 20. 05. 21, 4:13, Andrew Jeffery wrote:
> BIT(x) improves readability and safety with respect to shifts.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250.h | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> index 34aa2714f3c9..6473361525d1 100644
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -7,6 +7,7 @@
> * Copyright (C) 2001 Russell King.
> */
>
> +#include <linux/bits.h>
> #include <linux/serial_8250.h>
> #include <linux/serial_reg.h>
> #include <linux/dmaengine.h>
> @@ -70,25 +71,25 @@ struct serial8250_config {
> unsigned int flags;
> };
>
> -#define UART_CAP_FIFO (1 << 8) /* UART has FIFO */
> -#define UART_CAP_EFR (1 << 9) /* UART has EFR */
> -#define UART_CAP_SLEEP (1 << 10) /* UART has IER sleep */
> -#define UART_CAP_AFE (1 << 11) /* MCR-based hw flow control */
> -#define UART_CAP_UUE (1 << 12) /* UART needs IER bit 6 set (Xscale) */
> -#define UART_CAP_RTOIE (1 << 13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> -#define UART_CAP_HFIFO (1 << 14) /* UART has a "hidden" FIFO */
> -#define UART_CAP_RPM (1 << 15) /* Runtime PM is active while idle */
> -#define UART_CAP_IRDA (1 << 16) /* UART supports IrDA line discipline */
> -#define UART_CAP_MINI (1 << 17) /* Mini UART on BCM283X family lacks:
> +#define UART_CAP_FIFO BIT(8) /* UART has FIFO */
> +#define UART_CAP_EFR BIT(9) /* UART has EFR */
> +#define UART_CAP_SLEEP BIT(10) /* UART has IER sleep */
> +#define UART_CAP_AFE BIT(11) /* MCR-based hw flow control */
> +#define UART_CAP_UUE BIT(12) /* UART needs IER bit 6 set (Xscale) */
> +#define UART_CAP_RTOIE BIT(13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> +#define UART_CAP_HFIFO BIT(14) /* UART has a "hidden" FIFO */
> +#define UART_CAP_RPM BIT(15) /* Runtime PM is active while idle */
> +#define UART_CAP_IRDA BIT(16) /* UART supports IrDA line discipline */
> +#define UART_CAP_MINI BIT(17) /* Mini UART on BCM283X family lacks:
> * STOP PARITY EPAR SPAR WLEN5 WLEN6
> */
>
> -#define UART_BUG_QUOT (1 << 0) /* UART has buggy quot LSB */
> -#define UART_BUG_TXEN (1 << 1) /* UART has buggy TX IIR status */
> -#define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */
> -#define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */
> -#define UART_BUG_PARITY (1 << 4) /* UART mishandles parity if FIFO enabled */
> -#define UART_BUG_TXRACE (1 << 5) /* UART Tx fails to set remote DR */
> +#define UART_BUG_QUOT BIT(0) /* UART has buggy quot LSB */
> +#define UART_BUG_TXEN BIT(1) /* UART has buggy TX IIR status */
> +#define UART_BUG_NOMSR BIT(2) /* UART has buggy MSR status bits (Au1x00) */
> +#define UART_BUG_THRE BIT(3) /* UART has buggy THRE reassertion */
> +#define UART_BUG_PARITY BIT(4) /* UART mishandles parity if FIFO enabled */
> +#define UART_BUG_TXRACE BIT(5) /* UART Tx fails to set remote DR */
>
>
> #ifdef CONFIG_SERIAL_8250_SHARE_IRQ
>
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>, linux-serial@vger.kernel.org
Cc: ryan_chen@aspeedtech.com, linux-aspeed@lists.ozlabs.org,
gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, jenmin_yuan@aspeedtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_*
Date: Thu, 20 May 2021 07:25:13 +0200 [thread overview]
Message-ID: <20eec190-d80e-b32a-8949-e5e2918a110b@kernel.org> (raw)
In-Reply-To: <20210520021334.497341-3-andrew@aj.id.au>
On 20. 05. 21, 4:13, Andrew Jeffery wrote:
> BIT(x) improves readability and safety with respect to shifts.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250.h | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> index 34aa2714f3c9..6473361525d1 100644
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -7,6 +7,7 @@
> * Copyright (C) 2001 Russell King.
> */
>
> +#include <linux/bits.h>
> #include <linux/serial_8250.h>
> #include <linux/serial_reg.h>
> #include <linux/dmaengine.h>
> @@ -70,25 +71,25 @@ struct serial8250_config {
> unsigned int flags;
> };
>
> -#define UART_CAP_FIFO (1 << 8) /* UART has FIFO */
> -#define UART_CAP_EFR (1 << 9) /* UART has EFR */
> -#define UART_CAP_SLEEP (1 << 10) /* UART has IER sleep */
> -#define UART_CAP_AFE (1 << 11) /* MCR-based hw flow control */
> -#define UART_CAP_UUE (1 << 12) /* UART needs IER bit 6 set (Xscale) */
> -#define UART_CAP_RTOIE (1 << 13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> -#define UART_CAP_HFIFO (1 << 14) /* UART has a "hidden" FIFO */
> -#define UART_CAP_RPM (1 << 15) /* Runtime PM is active while idle */
> -#define UART_CAP_IRDA (1 << 16) /* UART supports IrDA line discipline */
> -#define UART_CAP_MINI (1 << 17) /* Mini UART on BCM283X family lacks:
> +#define UART_CAP_FIFO BIT(8) /* UART has FIFO */
> +#define UART_CAP_EFR BIT(9) /* UART has EFR */
> +#define UART_CAP_SLEEP BIT(10) /* UART has IER sleep */
> +#define UART_CAP_AFE BIT(11) /* MCR-based hw flow control */
> +#define UART_CAP_UUE BIT(12) /* UART needs IER bit 6 set (Xscale) */
> +#define UART_CAP_RTOIE BIT(13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> +#define UART_CAP_HFIFO BIT(14) /* UART has a "hidden" FIFO */
> +#define UART_CAP_RPM BIT(15) /* Runtime PM is active while idle */
> +#define UART_CAP_IRDA BIT(16) /* UART supports IrDA line discipline */
> +#define UART_CAP_MINI BIT(17) /* Mini UART on BCM283X family lacks:
> * STOP PARITY EPAR SPAR WLEN5 WLEN6
> */
>
> -#define UART_BUG_QUOT (1 << 0) /* UART has buggy quot LSB */
> -#define UART_BUG_TXEN (1 << 1) /* UART has buggy TX IIR status */
> -#define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */
> -#define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */
> -#define UART_BUG_PARITY (1 << 4) /* UART mishandles parity if FIFO enabled */
> -#define UART_BUG_TXRACE (1 << 5) /* UART Tx fails to set remote DR */
> +#define UART_BUG_QUOT BIT(0) /* UART has buggy quot LSB */
> +#define UART_BUG_TXEN BIT(1) /* UART has buggy TX IIR status */
> +#define UART_BUG_NOMSR BIT(2) /* UART has buggy MSR status bits (Au1x00) */
> +#define UART_BUG_THRE BIT(3) /* UART has buggy THRE reassertion */
> +#define UART_BUG_PARITY BIT(4) /* UART mishandles parity if FIFO enabled */
> +#define UART_BUG_TXRACE BIT(5) /* UART Tx fails to set remote DR */
>
>
> #ifdef CONFIG_SERIAL_8250_SHARE_IRQ
>
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>, linux-serial@vger.kernel.org
Cc: gregkh@linuxfoundation.org, joel@jms.id.au,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
jenmin_yuan@aspeedtech.com, ryan_chen@aspeedtech.com,
miltonm@us.ibm.com
Subject: Re: [PATCH v3 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_*
Date: Thu, 20 May 2021 07:25:13 +0200 [thread overview]
Message-ID: <20eec190-d80e-b32a-8949-e5e2918a110b@kernel.org> (raw)
In-Reply-To: <20210520021334.497341-3-andrew@aj.id.au>
On 20. 05. 21, 4:13, Andrew Jeffery wrote:
> BIT(x) improves readability and safety with respect to shifts.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250.h | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> index 34aa2714f3c9..6473361525d1 100644
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -7,6 +7,7 @@
> * Copyright (C) 2001 Russell King.
> */
>
> +#include <linux/bits.h>
> #include <linux/serial_8250.h>
> #include <linux/serial_reg.h>
> #include <linux/dmaengine.h>
> @@ -70,25 +71,25 @@ struct serial8250_config {
> unsigned int flags;
> };
>
> -#define UART_CAP_FIFO (1 << 8) /* UART has FIFO */
> -#define UART_CAP_EFR (1 << 9) /* UART has EFR */
> -#define UART_CAP_SLEEP (1 << 10) /* UART has IER sleep */
> -#define UART_CAP_AFE (1 << 11) /* MCR-based hw flow control */
> -#define UART_CAP_UUE (1 << 12) /* UART needs IER bit 6 set (Xscale) */
> -#define UART_CAP_RTOIE (1 << 13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> -#define UART_CAP_HFIFO (1 << 14) /* UART has a "hidden" FIFO */
> -#define UART_CAP_RPM (1 << 15) /* Runtime PM is active while idle */
> -#define UART_CAP_IRDA (1 << 16) /* UART supports IrDA line discipline */
> -#define UART_CAP_MINI (1 << 17) /* Mini UART on BCM283X family lacks:
> +#define UART_CAP_FIFO BIT(8) /* UART has FIFO */
> +#define UART_CAP_EFR BIT(9) /* UART has EFR */
> +#define UART_CAP_SLEEP BIT(10) /* UART has IER sleep */
> +#define UART_CAP_AFE BIT(11) /* MCR-based hw flow control */
> +#define UART_CAP_UUE BIT(12) /* UART needs IER bit 6 set (Xscale) */
> +#define UART_CAP_RTOIE BIT(13) /* UART needs IER bit 4 set (Xscale, Tegra) */
> +#define UART_CAP_HFIFO BIT(14) /* UART has a "hidden" FIFO */
> +#define UART_CAP_RPM BIT(15) /* Runtime PM is active while idle */
> +#define UART_CAP_IRDA BIT(16) /* UART supports IrDA line discipline */
> +#define UART_CAP_MINI BIT(17) /* Mini UART on BCM283X family lacks:
> * STOP PARITY EPAR SPAR WLEN5 WLEN6
> */
>
> -#define UART_BUG_QUOT (1 << 0) /* UART has buggy quot LSB */
> -#define UART_BUG_TXEN (1 << 1) /* UART has buggy TX IIR status */
> -#define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */
> -#define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */
> -#define UART_BUG_PARITY (1 << 4) /* UART mishandles parity if FIFO enabled */
> -#define UART_BUG_TXRACE (1 << 5) /* UART Tx fails to set remote DR */
> +#define UART_BUG_QUOT BIT(0) /* UART has buggy quot LSB */
> +#define UART_BUG_TXEN BIT(1) /* UART has buggy TX IIR status */
> +#define UART_BUG_NOMSR BIT(2) /* UART has buggy MSR status bits (Au1x00) */
> +#define UART_BUG_THRE BIT(3) /* UART has buggy THRE reassertion */
> +#define UART_BUG_PARITY BIT(4) /* UART mishandles parity if FIFO enabled */
> +#define UART_BUG_TXRACE BIT(5) /* UART Tx fails to set remote DR */
>
>
> #ifdef CONFIG_SERIAL_8250_SHARE_IRQ
>
--
js
suse labs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-20 5:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 2:13 [PATCH v3 0/2] serial: 8250: Mitigate Tx stall risk for Aspeed VUARTs Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 2:13 ` [PATCH v3 1/2] serial: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 5:24 ` Jiri Slaby
2021-05-20 5:24 ` Jiri Slaby
2021-05-20 5:24 ` Jiri Slaby
2021-05-20 5:42 ` ChiaWei Wang
2021-05-20 5:42 ` ChiaWei Wang
2021-05-20 5:42 ` ChiaWei Wang
2021-05-20 2:13 ` [PATCH v3 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_* Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 2:13 ` Andrew Jeffery
2021-05-20 5:25 ` Jiri Slaby [this message]
2021-05-20 5:25 ` Jiri Slaby
2021-05-20 5:25 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20eec190-d80e-b32a-8949-e5e2918a110b@kernel.org \
--to=jirislaby@kernel.org \
--cc=andrew@aj.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=jenmin_yuan@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.