From: Thomas Renninger <trenn@suse.de>
To: Abhishek Goel <huntbag@linux.vnet.ibm.com>
Cc: linux-pm@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com,
akshay.adiga@linux.vnet.ibm.com,
Bharath Thodla <bharath.thodla@in.ibm.com>
Subject: Re: [PATCH] cpupower : Auto-completion for cpupower tool
Date: Wed, 05 Dec 2018 12:48:53 +0100 [thread overview]
Message-ID: <2133486.u21R1XiQqC@house> (raw)
In-Reply-To: <20181205113104.71319-1-huntbag@linux.vnet.ibm.com>
On Wednesday, December 5, 2018 12:31:04 PM CET Abhishek Goel wrote:
> This script adds support for auto-completion for cpupower tool.
> Added support for auto-completion of all the eight commands for
> cpupower tool and their all subsequent sub-commands, wherever
> possible.
From what I see all changes I proposed in a previous review round
with a "not that broad audience" have been addressed.
I already integrated the patch (slightly different, without functional
changes) into the latest cpupower sources of our build service and
things work out nice.
Shuah: Can you pick this up for next cpupower submission round, please.
Thanks,
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Renninger <trenn@suse.de>
To: Abhishek Goel <huntbag@linux.vnet.ibm.com>
Cc: linux-pm@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com,
akshay.adiga@linux.vnet.ibm.com,
Bharath Thodla <bharath.thodla@in.ibm.com>
Subject: Re: [PATCH] cpupower : Auto-completion for cpupower tool
Date: Wed, 05 Dec 2018 12:48:53 +0100 [thread overview]
Message-ID: <2133486.u21R1XiQqC@house> (raw)
In-Reply-To: <20181205113104.71319-1-huntbag@linux.vnet.ibm.com>
On Wednesday, December 5, 2018 12:31:04 PM CET Abhishek Goel wrote:
> This script adds support for auto-completion for cpupower tool.
> Added support for auto-completion of all the eight commands for
> cpupower tool and their all subsequent sub-commands, wherever
> possible.
>From what I see all changes I proposed in a previous review round
with a "not that broad audience" have been addressed.
I already integrated the patch (slightly different, without functional
changes) into the latest cpupower sources of our build service and
things work out nice.
Shuah: Can you pick this up for next cpupower submission round, please.
Thanks,
Thomas
next prev parent reply other threads:[~2018-12-05 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 11:31 [PATCH] cpupower : Auto-completion for cpupower tool Abhishek Goel
2018-12-05 11:48 ` Thomas Renninger [this message]
2018-12-05 11:48 ` Thomas Renninger
2018-12-05 14:57 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2133486.u21R1XiQqC@house \
--to=trenn@suse.de \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=bharath.thodla@in.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.