From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings
Date: Sun, 01 Mar 2020 00:55:19 +0100 [thread overview]
Message-ID: <21505688.DxWBmkEV5j@phil> (raw)
In-Reply-To: <5d47cf5f-9ac4-cff4-340b-a2518a508738@gmail.com>
Hi Johan,
Am Freitag, 28. Februar 2020, 13:50:11 CET schrieb Johan Jonker:
> On 2/28/20 1:35 PM, Robin Murphy wrote:
> > On 28/02/2020 6:14 am, Johan Jonker wrote:
> >> A test with the command below gives this error:
> >>
> >> arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible:
> >> ['rockchip,rk3036-kylin', 'rockchip,rk3036']
> >> is not valid under any of the given schemas
> >>
> >> Fix this error by changing 'rockchip,kylin-rk3036' to
> >> 'rockchip,rk3036-kylin' in rockchip.yaml.
> >
>
>
> > Although I can guess, it might be worth a note to explain why it's the
> > binding rather than the DTS that gets changed here.
>
> Hi Robin,
>
> My guess is that given a look at the other boards the processor name
> comes first and then the board name, so I changed it in rockchip.yaml.
> But maybe Heiko can better explain what the naming consensus in the past
> was.
I think what Robin meant was that there should be an explanation in the
commit message on why you change the binding and not the board.
Normally the dt-binding is the authoritative part, so boards should follow
the binding, but in the kylin-case the compatible from the .dts is used fr
years in the field now, so you're correct to fix the binding, as otherwise
we would break old users.
So just add a paragraph to the commit message with the above ;-)
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings
Date: Sun, 01 Mar 2020 00:55:19 +0100 [thread overview]
Message-ID: <21505688.DxWBmkEV5j@phil> (raw)
In-Reply-To: <5d47cf5f-9ac4-cff4-340b-a2518a508738-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Johan,
Am Freitag, 28. Februar 2020, 13:50:11 CET schrieb Johan Jonker:
> On 2/28/20 1:35 PM, Robin Murphy wrote:
> > On 28/02/2020 6:14 am, Johan Jonker wrote:
> >> A test with the command below gives this error:
> >>
> >> arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible:
> >> ['rockchip,rk3036-kylin', 'rockchip,rk3036']
> >> is not valid under any of the given schemas
> >>
> >> Fix this error by changing 'rockchip,kylin-rk3036' to
> >> 'rockchip,rk3036-kylin' in rockchip.yaml.
> >
>
>
> > Although I can guess, it might be worth a note to explain why it's the
> > binding rather than the DTS that gets changed here.
>
> Hi Robin,
>
> My guess is that given a look at the other boards the processor name
> comes first and then the board name, so I changed it in rockchip.yaml.
> But maybe Heiko can better explain what the naming consensus in the past
> was.
I think what Robin meant was that there should be an explanation in the
commit message on why you change the binding and not the board.
Normally the dt-binding is the authoritative part, so boards should follow
the binding, but in the kylin-case the compatible from the .dts is used fr
years in the field now, so you're correct to fix the binding, as otherwise
we would break old users.
So just add a paragraph to the commit message with the above ;-)
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings
Date: Sun, 01 Mar 2020 00:55:19 +0100 [thread overview]
Message-ID: <21505688.DxWBmkEV5j@phil> (raw)
In-Reply-To: <5d47cf5f-9ac4-cff4-340b-a2518a508738@gmail.com>
Hi Johan,
Am Freitag, 28. Februar 2020, 13:50:11 CET schrieb Johan Jonker:
> On 2/28/20 1:35 PM, Robin Murphy wrote:
> > On 28/02/2020 6:14 am, Johan Jonker wrote:
> >> A test with the command below gives this error:
> >>
> >> arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible:
> >> ['rockchip,rk3036-kylin', 'rockchip,rk3036']
> >> is not valid under any of the given schemas
> >>
> >> Fix this error by changing 'rockchip,kylin-rk3036' to
> >> 'rockchip,rk3036-kylin' in rockchip.yaml.
> >
>
>
> > Although I can guess, it might be worth a note to explain why it's the
> > binding rather than the DTS that gets changed here.
>
> Hi Robin,
>
> My guess is that given a look at the other boards the processor name
> comes first and then the board name, so I changed it in rockchip.yaml.
> But maybe Heiko can better explain what the naming consensus in the past
> was.
I think what Robin meant was that there should be an explanation in the
commit message on why you change the binding and not the board.
Normally the dt-binding is the authoritative part, so boards should follow
the binding, but in the kylin-case the compatible from the .dts is used fr
years in the field now, so you're correct to fix the binding, as otherwise
we would break old users.
So just add a paragraph to the commit message with the above ;-)
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-29 23:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 6:14 [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-02-28 6:14 ` [PATCH 2/4] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-02-28 6:14 ` [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-02-28 12:42 ` Robin Murphy
2020-02-28 12:42 ` Robin Murphy
2020-02-28 12:42 ` Robin Murphy
2020-02-28 13:28 ` Johan Jonker
2020-02-28 13:28 ` Johan Jonker
2020-03-01 0:02 ` Heiko Stuebner
2020-03-01 0:02 ` Heiko Stuebner
2020-02-28 6:14 ` [PATCH 4/4] arm64: dts: rockchip: fix compatible property for Radxa ROCK Pi N10 Johan Jonker
2020-02-28 6:14 ` Johan Jonker
2020-03-01 0:04 ` Heiko Stuebner
2020-03-01 0:04 ` Heiko Stuebner
2020-03-01 0:04 ` Heiko Stuebner
2020-02-28 12:35 ` [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Robin Murphy
2020-02-28 12:35 ` Robin Murphy
2020-02-28 12:35 ` Robin Murphy
2020-02-28 12:50 ` Johan Jonker
2020-02-28 12:50 ` Johan Jonker
2020-02-29 23:55 ` Heiko Stuebner [this message]
2020-02-29 23:55 ` Heiko Stuebner
2020-02-29 23:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21505688.DxWBmkEV5j@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.