From: Dave Airlie <airlied@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-fbdev@vger.kernel.org, Dave Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.sf.net
Subject: Re: [PATCH 2/2] vga_switcheroo: initial implementation (v8)
Date: Fri, 26 Feb 2010 18:50:04 +1000 [thread overview]
Message-ID: <21d7e9971002260050h37eff655k3b667528b9cca333@mail.gmail.com> (raw)
In-Reply-To: <b170af451002250119y52c7097er995e7592248128c0@mail.gmail.com>
Oh I should probably have dropped all the audio bits, I didn't even
see this reply
before I updated to v11.
The r600 audio code is a bit of disaster area hopefully we can clean it up, like
the timer was firing after the device was suspended.
I'll repost with all that r600 audio ripped out and you can fix the mess.
>
> Don't mess with r600_audio_* there. You call if for all chipsets which
> is not needed and break nice S&R layout, which is chipset specific.
>
> I guess you needed that because you didn't work on branch containing my patch:
> http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=38fd2c6ff526e6a59edfa8e08f6f0724646784c4
> (you commited it to drm-linus)
This patch is now based on Linus tree, but yeah the original version
predates your
patches.
>> -int radeon_audio = 1;
>> +int radeon_audio = 0;
>
> Why?! What for we disable this feature by default?! If you see some
> reason for that, explain it to others please. I can change my mind,
> but for now I don't like this. It makes audio an option from just
> working-out-of-box.
>
Oversights, the audio was just broken in the presence of suspend/resume when
I wrote it.
Dave.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-fbdev@vger.kernel.org, Dave Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.sf.net
Subject: Re: [PATCH 2/2] vga_switcheroo: initial implementation (v8)
Date: Fri, 26 Feb 2010 08:50:04 +0000 [thread overview]
Message-ID: <21d7e9971002260050h37eff655k3b667528b9cca333@mail.gmail.com> (raw)
In-Reply-To: <b170af451002250119y52c7097er995e7592248128c0@mail.gmail.com>
Oh I should probably have dropped all the audio bits, I didn't even
see this reply
before I updated to v11.
The r600 audio code is a bit of disaster area hopefully we can clean it up, like
the timer was firing after the device was suspended.
I'll repost with all that r600 audio ripped out and you can fix the mess.
>
> Don't mess with r600_audio_* there. You call if for all chipsets which
> is not needed and break nice S&R layout, which is chipset specific.
>
> I guess you needed that because you didn't work on branch containing my patch:
> http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h8fd2c6ff526e6a59edfa8e08f6f0724646784c4
> (you commited it to drm-linus)
This patch is now based on Linus tree, but yeah the original version
predates your
patches.
>> -int radeon_audio = 1;
>> +int radeon_audio = 0;
>
> Why?! What for we disable this feature by default?! If you see some
> reason for that, explain it to others please. I can change my mind,
> but for now I don't like this. It makes audio an option from just
> working-out-of-box.
>
Oversights, the audio was just broken in the presence of suspend/resume when
I wrote it.
Dave.
next prev parent reply other threads:[~2010-02-26 8:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 5:07 fb + vga switcher patches (THE CORRECT ONES) Dave Airlie
2010-02-25 5:07 ` Dave Airlie
2010-02-25 5:07 ` [PATCH 1/2] fb: for framebuffer handover don't exit the loop early Dave Airlie
2010-02-25 5:07 ` Dave Airlie
2010-02-25 5:07 ` [PATCH 2/2] vga_switcheroo: initial implementation (v8) Dave Airlie
2010-02-25 5:07 ` Dave Airlie
2010-02-25 5:07 ` Dave Airlie
2010-02-25 9:19 ` Rafał Miłecki
2010-02-25 9:19 ` Rafał Miłecki
2010-02-26 8:50 ` Dave Airlie [this message]
2010-02-26 8:50 ` Dave Airlie
2010-02-26 8:53 ` Rafał Miłecki
2010-02-26 8:53 ` Rafał Miłecki
2010-02-26 8:53 ` Rafał Miłecki
2010-02-26 8:50 ` Dave Airlie
2010-02-25 9:19 ` Rafał Miłecki
2010-02-25 5:07 ` [PATCH 1/2] fb: for framebuffer handover don't exit the loop early Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e9971002260050h37eff655k3b667528b9cca333@mail.gmail.com \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sf.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.