From: Lukasz Luba <lukasz.luba@arm.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Rafael Wysocki <rjw@rjwysocki.net>, Vincent Donnefort <vincent.donnefort@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] cpufreq: vexpress: Use auto-registration for energy model Date: Tue, 10 Aug 2021 11:11:31 +0100 [thread overview] Message-ID: <2210acb9-2666-7aa9-d36c-346480541f3c@arm.com> (raw) In-Reply-To: <20210810100652.h473q6hgtc5czfyk@vireshk-i7> On 8/10/21 11:06 AM, Viresh Kumar wrote: > On 10-08-21, 11:05, Lukasz Luba wrote: >> I can see that this driver calls explicitly the >> of_cpufreq_cooling_register() >> It does this in the cpufreq_driver->ready() callback >> implementation: ve_spc_cpufreq_ready() >> >> With that in mind, the new code in the patch 1/8, which >> registers the EM, should be called even earlier, above: >> ---------------------8<--------------------------------- >> /* Callback for handling stuff after policy is ready */ >> if (cpufreq_driver->ready) >> cpufreq_driver->ready(policy); >> ------------------->8---------------------------------- > > Thanks. I will look at this sequencing issue again. > >> This also triggered a question: >> If this new flag can be set in the cpufreq driver which hasn't set >> CPUFREQ_IS_COOLING_DEV >> ? > > Why not ? I thought someone could try to call cpufreq_cooling_register() from the cpufreq driver init function, but it's not possible. I have just checked that, so should be good with these two flags being independent and working fine. > >> I can only see one driver (this one in the patch) which has such >> configuration. >
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Rafael Wysocki <rjw@rjwysocki.net>, Vincent Donnefort <vincent.donnefort@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] cpufreq: vexpress: Use auto-registration for energy model Date: Tue, 10 Aug 2021 11:11:31 +0100 [thread overview] Message-ID: <2210acb9-2666-7aa9-d36c-346480541f3c@arm.com> (raw) In-Reply-To: <20210810100652.h473q6hgtc5czfyk@vireshk-i7> On 8/10/21 11:06 AM, Viresh Kumar wrote: > On 10-08-21, 11:05, Lukasz Luba wrote: >> I can see that this driver calls explicitly the >> of_cpufreq_cooling_register() >> It does this in the cpufreq_driver->ready() callback >> implementation: ve_spc_cpufreq_ready() >> >> With that in mind, the new code in the patch 1/8, which >> registers the EM, should be called even earlier, above: >> ---------------------8<--------------------------------- >> /* Callback for handling stuff after policy is ready */ >> if (cpufreq_driver->ready) >> cpufreq_driver->ready(policy); >> ------------------->8---------------------------------- > > Thanks. I will look at this sequencing issue again. > >> This also triggered a question: >> If this new flag can be set in the cpufreq driver which hasn't set >> CPUFREQ_IS_COOLING_DEV >> ? > > Why not ? I thought someone could try to call cpufreq_cooling_register() from the cpufreq driver init function, but it's not possible. I have just checked that, so should be good with these two flags being independent and working fine. > >> I can only see one driver (this one in the patch) which has such >> configuration. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-10 10:11 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-10 7:36 [PATCH 0/8] cpufreq: Auto-register with energy model Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` [PATCH 1/8] cpufreq: Auto-register with energy model if asked Viresh Kumar 2021-08-10 9:36 ` Lukasz Luba 2021-08-10 9:38 ` Viresh Kumar 2021-08-10 15:33 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 2/8] cpufreq: dt: Use auto-registration for energy model Viresh Kumar 2021-08-10 10:19 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 3/8] cpufreq: imx6q: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 4/8] cpufreq: mediatek: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 5/8] cpufreq: omap: " Viresh Kumar 2021-08-10 10:24 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 6/8] cpufreq: qcom-cpufreq-hw: " Viresh Kumar 2021-08-10 10:26 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 7/8] cpufreq: scpi: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:27 ` Lukasz Luba 2021-08-10 10:27 ` Lukasz Luba 2021-08-11 2:40 ` Sudeep Holla 2021-08-11 2:40 ` Sudeep Holla 2021-08-10 7:36 ` [PATCH 8/8] cpufreq: vexpress: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:05 ` Lukasz Luba 2021-08-10 10:05 ` Lukasz Luba 2021-08-10 10:06 ` Viresh Kumar 2021-08-10 10:06 ` Viresh Kumar 2021-08-10 10:11 ` Lukasz Luba [this message] 2021-08-10 10:11 ` Lukasz Luba 2021-08-10 10:12 ` Viresh Kumar 2021-08-10 10:12 ` Viresh Kumar 2021-08-10 10:30 ` Lukasz Luba 2021-08-10 10:30 ` Lukasz Luba 2021-08-11 2:40 ` Sudeep Holla 2021-08-11 2:40 ` Sudeep Holla 2021-08-10 9:17 ` [PATCH 0/8] cpufreq: Auto-register with " Lukasz Luba 2021-08-10 9:17 ` Lukasz Luba 2021-08-10 9:17 ` Lukasz Luba 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 12:35 ` Quentin Perret 2021-08-10 12:35 ` Quentin Perret 2021-08-10 12:35 ` Quentin Perret 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:53 ` Quentin Perret 2021-08-10 13:53 ` Quentin Perret 2021-08-10 13:53 ` Quentin Perret 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 8:37 ` Quentin Perret 2021-08-11 8:37 ` Quentin Perret 2021-08-11 8:37 ` Quentin Perret 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:36 ` Viresh Kumar 2021-08-11 9:36 ` Viresh Kumar 2021-08-11 9:36 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2210acb9-2666-7aa9-d36c-346480541f3c@arm.com \ --to=lukasz.luba@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=vincent.donnefort@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.