From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Cc: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>, Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>, DRI Development <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Linux-Renesas <linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Date: Mon, 15 Jan 2018 08:59:38 +0200 [thread overview] Message-ID: <2213619.LpHAiGQTjv@avalon> (raw) In-Reply-To: <20180115065528.cfelrll6dm6ggf4e-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Hi Simon, On Monday, 15 January 2018 08:55:29 EET Simon Horman wrote: > On Fri, Jan 12, 2018 at 03:29:48PM +0200, Laurent Pinchart wrote: > > On Friday, 12 January 2018 12:13:18 EET Geert Uytterhoeven wrote: > >> On Fri, Jan 12, 2018 at 1:58 AM, Laurent Pinchart wrote: > >>> The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > >>> corresponding device tree bindings. > >>> > >>> Signed-off-by: Laurent Pinchart > >>> <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> > >>> > >>> --- /dev/null > >>> +++ > >>> b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > >>> @@ -0,0 +1,54 @@ > >>> +Renesas R-Car LVDS Encoder > >>> +========================== > >>> + > >>> +These DT bindings describe the LVDS encoder embedded in the Renesas > >>> R-Car Gen2 +and Gen3 SoCs. > >>> + > >>> +Required properties: > >>> + > >>> +- compatible : Shall contain one of > >>> + - "renesas,lvds-r8a7743" for R8A7790 (R-Car RZ/G1M) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7790" for R8A7790 (R-Car H2) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7791" for R8A7791 (R-Car M2-W) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7793" for R8A7791 (R-Car M2-N) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS > >>> encoders > >> > >> As this is a new binding, please use "renesas,<soc>-lvds". > > > > I've recently been thinking that we made the wrong choice, <ip>-<soc> > > would be better in my opinion as it aligns with <ip>-<version>, but it's > > too late to change that, so I'll change the order here. > > My recollection is that in the beginning we had a bit of a mixture but > leaned towards <ip>-<soc>, which made sense in my opinion. However, after > some discussion it was agreed that the best-practice for upstream was to > use <soc>-<ip>. Unless that situation has changed lets stock with using > <soc>-<ip> for new bindings. Sure, that was my plan, and it seems I failed to explain it clearly. I too believe that <ip>-<soc> would be better, but as we have standardized on <soc>- <ip> and as there's no strong reason to reconsider that decision at the moment, the next version of this patch will use <soc>-<ip>. It was a mistake in v1, not an attempt to change what we had agreed on. > >> BTW, would it make sense to use "renesas,<soc>-du" for the new DU > >> binding, too? Or have you reserved that for the future version that will > >> have a one-to-one mapping between device nodes and DU channels? ;-) > > > > It's a good idea, let's reserve it for that evolution. If it ever happens > > ;-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Simon Horman <horms@verge.net.au> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, DRI Development <dri-devel@lists.freedesktop.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, devicetree@vger.kernel.org Subject: Re: [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Date: Mon, 15 Jan 2018 08:59:38 +0200 [thread overview] Message-ID: <2213619.LpHAiGQTjv@avalon> (raw) In-Reply-To: <20180115065528.cfelrll6dm6ggf4e@verge.net.au> Hi Simon, On Monday, 15 January 2018 08:55:29 EET Simon Horman wrote: > On Fri, Jan 12, 2018 at 03:29:48PM +0200, Laurent Pinchart wrote: > > On Friday, 12 January 2018 12:13:18 EET Geert Uytterhoeven wrote: > >> On Fri, Jan 12, 2018 at 1:58 AM, Laurent Pinchart wrote: > >>> The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > >>> corresponding device tree bindings. > >>> > >>> Signed-off-by: Laurent Pinchart > >>> <laurent.pinchart+renesas@ideasonboard.com> > >>> > >>> --- /dev/null > >>> +++ > >>> b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > >>> @@ -0,0 +1,54 @@ > >>> +Renesas R-Car LVDS Encoder > >>> +========================== > >>> + > >>> +These DT bindings describe the LVDS encoder embedded in the Renesas > >>> R-Car Gen2 +and Gen3 SoCs. > >>> + > >>> +Required properties: > >>> + > >>> +- compatible : Shall contain one of > >>> + - "renesas,lvds-r8a7743" for R8A7790 (R-Car RZ/G1M) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7790" for R8A7790 (R-Car H2) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7791" for R8A7791 (R-Car M2-W) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7793" for R8A7791 (R-Car M2-N) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS > >>> encoders > >>> + - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS > >>> encoders > >> > >> As this is a new binding, please use "renesas,<soc>-lvds". > > > > I've recently been thinking that we made the wrong choice, <ip>-<soc> > > would be better in my opinion as it aligns with <ip>-<version>, but it's > > too late to change that, so I'll change the order here. > > My recollection is that in the beginning we had a bit of a mixture but > leaned towards <ip>-<soc>, which made sense in my opinion. However, after > some discussion it was agreed that the best-practice for upstream was to > use <soc>-<ip>. Unless that situation has changed lets stock with using > <soc>-<ip> for new bindings. Sure, that was my plan, and it seems I failed to explain it clearly. I too believe that <ip>-<soc> would be better, but as we have standardized on <soc>- <ip> and as there's no strong reason to reconsider that decision at the moment, the next version of this patch will use <soc>-<ip>. It was a mistake in v1, not an attempt to change what we had agreed on. > >> BTW, would it make sense to use "renesas,<soc>-du" for the new DU > >> binding, too? Or have you reserved that for the future version that will > >> have a one-to-one mapping between device nodes and DU channels? ;-) > > > > It's a good idea, let's reserve it for that evolution. If it ever happens > > ;-) -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2018-01-15 6:59 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-12 0:58 [PATCH 00/10] R-Car DU: Convert LVDS code to bridge driver Laurent Pinchart 2018-01-12 0:58 ` [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Laurent Pinchart 2018-01-12 0:58 ` Laurent Pinchart 2018-01-12 9:45 ` Geert Uytterhoeven [not found] ` <CAMuHMdWMgst-1evod+0hZujU2xPtO3UmO9c2CPPrTg=gpHpTbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-01-12 13:36 ` Laurent Pinchart 2018-01-12 13:36 ` Laurent Pinchart 2018-01-12 10:13 ` Geert Uytterhoeven 2018-01-12 13:29 ` Laurent Pinchart 2018-01-15 6:55 ` Simon Horman 2018-01-15 6:55 ` Simon Horman [not found] ` <20180115065528.cfelrll6dm6ggf4e-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2018-01-15 6:59 ` Laurent Pinchart [this message] 2018-01-15 6:59 ` Laurent Pinchart 2018-01-15 7:57 ` Simon Horman 2018-01-15 8:05 ` Geert Uytterhoeven 2018-01-15 8:26 ` Laurent Pinchart [not found] ` <20180112005858.26472-2-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2018-01-12 12:59 ` Biju Das 2018-01-12 12:59 ` Biju Das 2018-01-12 13:26 ` Laurent Pinchart 2018-01-12 14:00 ` Fabrizio Castro 2018-01-12 14:25 ` Laurent Pinchart 2018-01-12 14:25 ` Laurent Pinchart 2018-01-12 15:13 ` Sergei Shtylyov [not found] ` <81a9462b-6aaa-52c7-f741-e504c14838e9-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2018-01-12 20:34 ` Laurent Pinchart 2018-01-12 20:34 ` Laurent Pinchart 2018-01-12 0:58 ` [PATCH 02/10] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings Laurent Pinchart 2018-01-12 9:49 ` Geert Uytterhoeven [not found] ` <CAMuHMdXYJmh8ssSRt8u75fTv5gyrpcoPKAuCT=BaF1Eu27CaiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-01-12 10:44 ` Laurent Pinchart 2018-01-12 10:44 ` Laurent Pinchart 2018-01-19 21:23 ` Rob Herring 2018-01-19 21:23 ` Rob Herring [not found] ` <20180112005858.26472-3-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2018-01-12 9:54 ` Vladimir Zapolskiy 2018-01-12 9:54 ` Vladimir Zapolskiy 2018-01-12 10:43 ` Laurent Pinchart 2018-01-12 14:52 ` Sergei Shtylyov 2018-01-12 14:52 ` Sergei Shtylyov 2018-01-12 15:14 ` Sergei Shtylyov 2018-01-12 15:14 ` Sergei Shtylyov 2018-01-12 16:46 ` Laurent Pinchart 2018-01-19 21:24 ` Rob Herring 2018-01-12 0:58 ` [PATCH 03/10] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Laurent Pinchart [not found] ` <20180112005858.26472-4-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2018-01-12 10:09 ` Geert Uytterhoeven 2018-01-12 10:09 ` Geert Uytterhoeven [not found] ` <CAMuHMdW5wDj5gyTnh+Xa3J10b_6For0MdhcTFgdU_+sgx=BYmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-01-12 13:53 ` Laurent Pinchart 2018-01-12 13:53 ` Laurent Pinchart 2018-01-12 0:58 ` [PATCH 04/10] drm: rcar-du: Convert LVDS encoder code to bridge driver Laurent Pinchart 2018-01-12 0:58 ` [PATCH 05/10] ARM: dts: porter: Fix HDMI output routing Laurent Pinchart 2018-01-15 7:56 ` Simon Horman 2018-01-15 8:25 ` Laurent Pinchart 2018-01-16 9:09 ` Simon Horman 2018-01-12 0:58 ` [PATCH 06/10] ARM: dts: r8a7790: Convert to new LVDS DT bindings Laurent Pinchart 2018-01-12 0:58 ` Laurent Pinchart 2018-01-12 0:58 ` [PATCH 07/10] ARM: dts: r8a7791: " Laurent Pinchart 2018-01-12 0:58 ` [PATCH 08/10] ARM: dts: r8a7793: " Laurent Pinchart 2018-01-12 0:58 ` [PATCH 09/10] arm64: dts: renesas: r8a7795: " Laurent Pinchart 2018-01-12 0:58 ` [PATCH 10/10] arm64: dts: renesas: r8a7796: " Laurent Pinchart 2018-01-12 9:47 ` [PATCH 00/10] R-Car DU: Convert LVDS code to bridge driver Geert Uytterhoeven 2018-01-12 13:48 ` Laurent Pinchart 2018-01-15 6:57 ` Simon Horman 2018-01-15 6:57 ` Simon Horman 2018-01-15 7:00 ` Laurent Pinchart 2018-01-15 7:58 ` Simon Horman [not found] ` <20180112005858.26472-1-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2018-01-15 6:59 ` Simon Horman 2018-01-15 6:59 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2213619.LpHAiGQTjv@avalon \ --to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \ --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \ --cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.