From: Michael Walle <michael@walle.cc>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [RFC PATCH 2/6] mtd: spi-nor: core: consolidate read op creation
Date: Thu, 08 Apr 2021 14:48:16 +0200 [thread overview]
Message-ID: <22d1042e061e355b0ddd122ef1228535@walle.cc> (raw)
In-Reply-To: <20210311191216.7363-3-p.yadav@ti.com>
Am 2021-03-11 20:12, schrieb Pratyush Yadav:
> Currently the spi_mem_op to read from the flash is used in two places:
> spi_nor_create_read_dirmap() and spi_nor_spimem_read_data(). In a later
> commit this number will increase to three. Instead of repeating the
> same
> code thrice, add a function that returns a template of the read op. The
> callers can then fill in the details like address, data length, data
> buffer location.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Michael Walle <michael@walle.cc>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [RFC PATCH 2/6] mtd: spi-nor: core: consolidate read op creation
Date: Thu, 08 Apr 2021 14:48:16 +0200 [thread overview]
Message-ID: <22d1042e061e355b0ddd122ef1228535@walle.cc> (raw)
In-Reply-To: <20210311191216.7363-3-p.yadav@ti.com>
Am 2021-03-11 20:12, schrieb Pratyush Yadav:
> Currently the spi_mem_op to read from the flash is used in two places:
> spi_nor_create_read_dirmap() and spi_nor_spimem_read_data(). In a later
> commit this number will increase to three. Instead of repeating the
> same
> code thrice, add a function that returns a template of the read op. The
> callers can then fill in the details like address, data length, data
> buffer location.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Michael Walle <michael@walle.cc>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [RFC PATCH 2/6] mtd: spi-nor: core: consolidate read op creation
Date: Thu, 08 Apr 2021 14:48:16 +0200 [thread overview]
Message-ID: <22d1042e061e355b0ddd122ef1228535@walle.cc> (raw)
In-Reply-To: <20210311191216.7363-3-p.yadav@ti.com>
Am 2021-03-11 20:12, schrieb Pratyush Yadav:
> Currently the spi_mem_op to read from the flash is used in two places:
> spi_nor_create_read_dirmap() and spi_nor_spimem_read_data(). In a later
> commit this number will increase to three. Instead of repeating the
> same
> code thrice, add a function that returns a template of the read op. The
> callers can then fill in the details like address, data length, data
> buffer location.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Michael Walle <michael@walle.cc>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-08 12:48 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 19:12 [RFC PATCH 0/6] spi: Add OSPI PHY calibration support for spi-cadence-quadspi Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` [RFC PATCH 1/6] spi: spi-mem: Tell controller when device is ready for calibration Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-23 23:07 ` Michael Walle
2021-03-23 23:07 ` Michael Walle
2021-03-23 23:07 ` Michael Walle
2021-03-24 8:08 ` Pratyush Yadav
2021-03-24 8:08 ` Pratyush Yadav
2021-03-24 8:08 ` Pratyush Yadav
2021-04-29 16:23 ` Michael Walle
2021-04-29 16:23 ` Michael Walle
2021-04-29 16:23 ` Michael Walle
2021-04-29 18:41 ` Pratyush Yadav
2021-04-29 18:41 ` Pratyush Yadav
2021-04-29 18:41 ` Pratyush Yadav
2021-04-29 22:46 ` Michael Walle
2021-04-29 22:46 ` Michael Walle
2021-04-29 22:46 ` Michael Walle
2021-03-11 19:12 ` [RFC PATCH 2/6] mtd: spi-nor: core: consolidate read op creation Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-23 23:17 ` Michael Walle
2021-03-23 23:17 ` Michael Walle
2021-03-23 23:17 ` Michael Walle
2021-03-24 8:04 ` Pratyush Yadav
2021-03-24 8:04 ` Pratyush Yadav
2021-03-24 8:04 ` Pratyush Yadav
2021-04-08 12:48 ` Michael Walle [this message]
2021-04-08 12:48 ` Michael Walle
2021-04-08 12:48 ` Michael Walle
2021-03-11 19:12 ` [RFC PATCH 3/6] mtd: spi-nor: core: run calibration when initialization is done Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2022-05-17 14:02 ` Miquel Raynal
2022-05-17 14:02 ` Miquel Raynal
2022-05-17 14:02 ` Miquel Raynal
2022-05-18 6:07 ` Pratyush Yadav
2022-05-18 6:07 ` Pratyush Yadav
2022-05-18 6:07 ` Pratyush Yadav
2022-05-18 7:19 ` Miquel Raynal
2022-05-18 7:19 ` Miquel Raynal
2022-05-18 7:19 ` Miquel Raynal
2022-05-18 7:56 ` Pratyush Yadav
2022-05-18 7:56 ` Pratyush Yadav
2022-05-18 7:56 ` Pratyush Yadav
2022-05-18 8:51 ` Cédric Le Goater
2022-05-18 8:51 ` Cédric Le Goater
2022-05-18 8:51 ` Cédric Le Goater
2022-06-27 9:14 ` Pratyush Yadav
2022-06-27 9:14 ` Pratyush Yadav
2022-06-27 9:14 ` Pratyush Yadav
2022-06-27 9:43 ` Cédric Le Goater
2022-06-27 9:43 ` Cédric Le Goater
2022-06-27 9:43 ` Cédric Le Goater
2022-06-27 10:35 ` Pratyush Yadav
2022-06-27 10:35 ` Pratyush Yadav
2022-06-27 10:35 ` Pratyush Yadav
2021-03-11 19:12 ` [RFC PATCH 4/6] spi: cadence-qspi: Use PHY for DAC reads if possible Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-12 9:13 ` Tudor.Ambarus
2021-03-12 9:13 ` Tudor.Ambarus
2021-03-12 9:13 ` Tudor.Ambarus
2021-03-12 10:17 ` Pratyush Yadav
2021-03-12 10:17 ` Pratyush Yadav
2021-03-12 10:17 ` Pratyush Yadav
2021-04-29 16:28 ` Michael Walle
2021-04-29 16:28 ` Michael Walle
2021-04-29 16:28 ` Michael Walle
2021-04-29 18:19 ` Pratyush Yadav
2021-04-29 18:19 ` Pratyush Yadav
2021-04-29 18:19 ` Pratyush Yadav
2021-04-29 22:20 ` Michael Walle
2021-04-29 22:20 ` Michael Walle
2021-04-29 22:20 ` Michael Walle
2021-05-10 11:39 ` Pratyush Yadav
2021-05-10 11:39 ` Pratyush Yadav
2021-05-10 11:39 ` Pratyush Yadav
2021-03-11 19:12 ` [RFC PATCH 5/6] spi: cadence-qspi: Tune PHY to allow running at higher frequencies Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-04-29 22:48 ` Michael Walle
2021-04-29 22:48 ` Michael Walle
2021-04-29 22:48 ` Michael Walle
2021-04-30 5:42 ` Pratyush Yadav
2021-04-30 5:42 ` Pratyush Yadav
2021-04-30 5:42 ` Pratyush Yadav
2021-03-11 19:12 ` [RFC PATCH 6/6] arm64: dts: ti: k3-j721e-som-p0: Enable PHY calibration Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-11 19:12 ` Pratyush Yadav
2021-03-12 9:09 ` [RFC PATCH 0/6] spi: Add OSPI PHY calibration support for spi-cadence-quadspi Tudor.Ambarus
2021-03-12 9:09 ` Tudor.Ambarus
2021-03-12 9:09 ` Tudor.Ambarus
2021-03-12 10:10 ` Pratyush Yadav
2021-03-12 10:10 ` Pratyush Yadav
2021-03-12 10:10 ` Pratyush Yadav
2021-03-12 10:20 ` Michael Walle
2021-03-12 10:20 ` Michael Walle
2021-03-12 10:20 ` Michael Walle
2021-03-12 11:07 ` Pratyush Yadav
2021-03-12 11:07 ` Pratyush Yadav
2021-03-12 11:07 ` Pratyush Yadav
2021-03-12 13:26 ` Michael Walle
2021-03-12 13:26 ` Michael Walle
2021-03-12 13:26 ` Michael Walle
2021-03-12 11:23 ` Tudor.Ambarus
2021-03-12 11:23 ` Tudor.Ambarus
2021-03-12 11:23 ` Tudor.Ambarus
2021-03-12 18:14 ` Pratyush Yadav
2021-03-12 18:14 ` Pratyush Yadav
2021-03-12 18:14 ` Pratyush Yadav
2021-03-12 13:32 ` Michael Walle
2021-03-12 13:32 ` Michael Walle
2021-03-12 13:32 ` Michael Walle
2021-03-12 14:59 ` Tudor.Ambarus
2021-03-12 14:59 ` Tudor.Ambarus
2021-03-12 14:59 ` Tudor.Ambarus
2021-03-12 17:00 ` Pratyush Yadav
2021-03-12 17:00 ` Pratyush Yadav
2021-03-12 17:00 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d1042e061e355b0ddd122ef1228535@walle.cc \
--to=michael@walle.cc \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.