From: Ezequiel Garcia <ezequiel@collabora.com>
To: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Enable backlight when trigger is activated
Date: Sun, 21 Jul 2019 20:00:44 -0300 [thread overview]
Message-ID: <22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com> (raw)
In-Reply-To: <20190718190849.GA11409@amd>
Hi Pavel,
The commit log is lacking the proper "leds: triggers: ".
Also...
On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote:
> Configuring backlight trigger from dts results in backlight off during
> boot. Machine looks dead upon boot, which is not good.
>
> Fix that by enabling LED on trigger activation.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c
> index 487577d..6e6bc78 100644
> --- a/drivers/leds/trigger/ledtrig-backlight.c
> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> n->old_status = UNBLANK;
> n->notifier.notifier_call = fb_notifier_callback;
>
> + led_set_brightness(led, LED_ON);
> +
This looks fishy.
Maybe you should use a default-state = "keep" instead? (and you'll have
to support it in the LED driver).
That'll give you proper "don't touch the LED if it was turned on" behavior,
which is what you seem to want.
Regards,
Eze
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Enable backlight when trigger is activated
Date: Sun, 21 Jul 2019 23:00:44 +0000 [thread overview]
Message-ID: <22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com> (raw)
In-Reply-To: <20190718190849.GA11409@amd>
Hi Pavel,
The commit log is lacking the proper "leds: triggers: ".
Also...
On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote:
> Configuring backlight trigger from dts results in backlight off during
> boot. Machine looks dead upon boot, which is not good.
>
> Fix that by enabling LED on trigger activation.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c
> index 487577d..6e6bc78 100644
> --- a/drivers/leds/trigger/ledtrig-backlight.c
> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> n->old_status = UNBLANK;
> n->notifier.notifier_call = fb_notifier_callback;
>
> + led_set_brightness(led, LED_ON);
> +
This looks fishy.
Maybe you should use a default-state = "keep" instead? (and you'll have
to support it in the LED driver).
That'll give you proper "don't touch the LED if it was turned on" behavior,
which is what you seem to want.
Regards,
Eze
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Enable backlight when trigger is activated
Date: Sun, 21 Jul 2019 20:00:44 -0300 [thread overview]
Message-ID: <22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com> (raw)
In-Reply-To: <20190718190849.GA11409@amd>
Hi Pavel,
The commit log is lacking the proper "leds: triggers: ".
Also...
On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote:
> Configuring backlight trigger from dts results in backlight off during
> boot. Machine looks dead upon boot, which is not good.
>
> Fix that by enabling LED on trigger activation.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c
> index 487577d..6e6bc78 100644
> --- a/drivers/leds/trigger/ledtrig-backlight.c
> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> n->old_status = UNBLANK;
> n->notifier.notifier_call = fb_notifier_callback;
>
> + led_set_brightness(led, LED_ON);
> +
This looks fishy.
Maybe you should use a default-state = "keep" instead? (and you'll have
to support it in the LED driver).
That'll give you proper "don't touch the LED if it was turned on" behavior,
which is what you seem to want.
Regards,
Eze
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Enable backlight when trigger is activated
Date: Sun, 21 Jul 2019 20:00:44 -0300 [thread overview]
Message-ID: <22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com> (raw)
In-Reply-To: <20190718190849.GA11409@amd>
Hi Pavel,
The commit log is lacking the proper "leds: triggers: ".
Also...
On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote:
> Configuring backlight trigger from dts results in backlight off during
> boot. Machine looks dead upon boot, which is not good.
>
> Fix that by enabling LED on trigger activation.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig-backlight.c
> index 487577d..6e6bc78 100644
> --- a/drivers/leds/trigger/ledtrig-backlight.c
> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> n->old_status = UNBLANK;
> n->notifier.notifier_call = fb_notifier_callback;
>
> + led_set_brightness(led, LED_ON);
> +
This looks fishy.
Maybe you should use a default-state = "keep" instead? (and you'll have
to support it in the LED driver).
That'll give you proper "don't touch the LED if it was turned on" behavior,
which is what you seem to want.
Regards,
Eze
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-21 23:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 19:08 [PATCH] Enable backlight when trigger is activated Pavel Machek
2019-07-18 19:08 ` Pavel Machek
2019-07-18 19:08 ` Pavel Machek
2019-07-21 23:00 ` Ezequiel Garcia [this message]
2019-07-21 23:00 ` Ezequiel Garcia
2019-07-21 23:00 ` Ezequiel Garcia
2019-07-21 23:00 ` Ezequiel Garcia
2019-07-22 7:50 ` Pavel Machek
2019-07-22 7:50 ` Pavel Machek
2019-07-22 7:50 ` Pavel Machek
2019-07-22 20:25 ` Jacek Anaszewski
2019-07-22 20:25 ` Jacek Anaszewski
2019-07-22 20:25 ` Jacek Anaszewski
2019-07-22 21:04 ` Pavel Machek
2019-07-22 21:04 ` Pavel Machek
2019-07-22 21:04 ` Pavel Machek
2019-07-22 21:04 ` Pavel Machek
2019-07-24 8:33 ` Pavel Machek
2019-07-24 8:33 ` Pavel Machek
2019-07-24 8:33 ` Pavel Machek
2019-07-24 21:16 ` Jacek Anaszewski
2019-07-24 21:16 ` Jacek Anaszewski
2019-07-24 21:16 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d7eca4ad8aa2e73933c4f83c92221ce6e0945a.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.