From: Frieder Schrempf <frieder.schrempf@kontron.de> To: Robin Gong <yibin.gong@nxp.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "broonie@kernel.org" <broonie@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "vkoul@kernel.org" <vkoul@kernel.org>, "will.deacon@arm.com" <will.deacon@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com> Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com> Subject: Re: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Date: Thu, 23 Jul 2020 13:51:44 +0200 [thread overview] Message-ID: <22e53878-42e2-78ed-c460-3fa339c306ad@kontron.de> (raw) In-Reply-To: <VE1PR04MB6638BEA5C2594FEBFDE9318589760@VE1PR04MB6638.eurprd04.prod.outlook.com> On 23.07.20 13:12, Robin Gong wrote: >> On 2020/07/23 17:04 Frieder Schrempf <frieder.schrempf@kontron.de> >> wrote: >>> Hi Robin, >>> >>> On 30.06.20 15:31, Robin Gong wrote: >>>> Add 'fw_loaded' and 'is_ram_script' to check if the script used by >>>> channel is ram script and it's loaded or not, so that could prevent >>>> meaningless following malloc dma descriptor and bd allocate in >>>> sdma_transfer_init(), otherwise memory may be consumed out >>>> potentially without free in case that spi fallback into pio while >>>> dma transfer failed by sdma firmware not ready(next ERR009165 patch >>>> depends on sdma >>> RAM scripts/firmware). >>>> >>>> Signed-off-by: Robin Gong <yibin.gong@nxp.com> >>>> Acked-By: Vinod Koul <vkoul@kernel.org> >>>> --- >>>> drivers/dma/imx-sdma.c | 13 +++++++++++++ >>>> 1 file changed, 13 insertions(+) >>>> >>>> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index >>>> 5411e01e..ce1c83e 100644 >>>> --- a/drivers/dma/imx-sdma.c >>>> +++ b/drivers/dma/imx-sdma.c >>>> @@ -379,6 +379,7 @@ struct sdma_channel { >>>> enum dma_status status; >>>> struct imx_dma_data data; >>>> struct work_struct terminate_worker; >>>> + bool is_ram_script; >>>> }; >>>> >>>> #define IMX_DMA_SG_LOOP BIT(0) >>>> @@ -443,6 +444,7 @@ struct sdma_engine { >>>> struct sdma_buffer_descriptor *bd0; >>>> /* clock ratio for AHB:SDMA core. 1:1 is 1, 2:1 is 0*/ >>>> bool clk_ratio; >>>> + bool fw_loaded; >>>> }; >>>> >>>> static int sdma_config_write(struct dma_chan *chan, @@ -929,6 >>>> +931,7 @@ static void sdma_get_pc(struct sdma_channel *sdmac, >>>> case IMX_DMATYPE_SSI_DUAL: >>>> per_2_emi = sdma->script_addrs->ssish_2_mcu_addr; >>>> emi_2_per = sdma->script_addrs->mcu_2_ssish_addr; >>>> + sdmac->is_ram_script = true; >>>> break; >>>> case IMX_DMATYPE_SSI_SP: >>>> case IMX_DMATYPE_MMC: >>>> @@ -943,6 +946,7 @@ static void sdma_get_pc(struct sdma_channel >>> *sdmac, >>>> per_2_emi = sdma->script_addrs->asrc_2_mcu_addr; >>>> emi_2_per = sdma->script_addrs->asrc_2_mcu_addr; >>>> per_2_per = sdma->script_addrs->per_2_per_addr; >>>> + sdmac->is_ram_script = true; >>>> break; >>>> case IMX_DMATYPE_ASRC_SP: >>>> per_2_emi = sdma->script_addrs->shp_2_mcu_addr; >>>> @@ -1339,6 +1343,11 @@ static struct sdma_desc >>> *sdma_transfer_init(struct sdma_channel *sdmac, >>>> { >>>> struct sdma_desc *desc; >>>> >>>> + if (!sdmac->sdma->fw_loaded && sdmac->is_ram_script) { >>>> + dev_err(sdmac->sdma->dev, "sdma firmware not ready!\n"); >>>> + goto err_out; >>>> + } >>> >>> I tried your v10 patches on next-20200722 with i.MX8MM and it mostly >>> seems to work fine. >>> >>> When I tried first, I had the imx-sdma driver compiled into the >>> kernel, so it didn't load the firmware and fell back to the ROM scripts. >>> With this, SPI transactions work just fine, but I got the above error >>> message printed continuously when sending data in SPI3 via spidev. >> That's caused by you didn't load ram firmware as this patch set described. >> Please follow below steps to load firmware manually if you don't want to use >> NXP official Yocto release package: >> >> 1. Get sdma firmware from below linux-firmware and copy it to your local >> rootfs /lib/firmware/imx/sdma. >> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-firmware.git%2Ft&data=02%7C01%7Cfrieder.schrempf%40kontron.de%7C08276b76f9a14dae1f8408d82ef94da1%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C637310995564511410&sdata=YA1455ILoNgRDHAOy1H2051J9cu5VsHk39xtQive8mo%3D&reserved=0 >> ree/imx/sdma >> 2. Load firmware manually: >> echo 1 > /sys/$DEVPATH/loading >> cat $MY_FW_DIR/$FIRMWARE > /sys/$DEVPATH/data >> echo 0 > /sys/$DEVPATH/loading >> Please refer to Documentation/driver-api/firmware/fallback-mechanisms.rst >> and load the firmware in 60s (firmware fallback loading timeout) from kernel >> boot up. >> >>> >>> When I build imx-sdma as a module, the firmware is loaded correctly >>> and everything works as expected. >> I guess that's not related with sdma building as module. If sdma build as >> module, spi will fall to pio mode at spi-imx driver probe phase so that the >> above warning log never to be walked. Would you please add some debug >> info to double confirm? > Hi Frider, > Please ignore this comment, since there is -EPROBE_DEFER checking > , so you load sdma firmware by building sdma driver as module instead of > the above comment I mentioned? Yes, correct. > The warning log comes out during spi > transfer start and sdma firmware loading done, but if sdma driver building as > module could ensure firmware loading done in sdma_driver_probe_phase-> > spi_imx_probe_phase, which means sdma firmware loading has been ready > before spi transfer start, hence no such warning message. > > But I am not sure if all client drivers except spi are in good shape to support > ' CONFIG_IMX_SDMA=m '. I'm pretty sure that CONFIG_IMX_SDMA=m is supported and common. Otherwise it wouldn't be an option in Kconfig. > Besides, do you think 'dev_err_once ' instead of 'dev_err' is okay for you? I can't really judge if this is a proper fix as I haven't looked at the code in detail, but if you want to use dev_err_once(), that would be ok for me, maybe even better dev_warn_once(). As chances are that even without firmware transfers will work a warning instead of an error makes more sense to me.
WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder.schrempf@kontron.de> To: Robin Gong <yibin.gong@nxp.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "broonie@kernel.org" <broonie@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "vkoul@kernel.org" <vkoul@kernel.org>, "will.deacon@arm.com" <will.deacon@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Date: Thu, 23 Jul 2020 13:51:44 +0200 [thread overview] Message-ID: <22e53878-42e2-78ed-c460-3fa339c306ad@kontron.de> (raw) In-Reply-To: <VE1PR04MB6638BEA5C2594FEBFDE9318589760@VE1PR04MB6638.eurprd04.prod.outlook.com> On 23.07.20 13:12, Robin Gong wrote: >> On 2020/07/23 17:04 Frieder Schrempf <frieder.schrempf@kontron.de> >> wrote: >>> Hi Robin, >>> >>> On 30.06.20 15:31, Robin Gong wrote: >>>> Add 'fw_loaded' and 'is_ram_script' to check if the script used by >>>> channel is ram script and it's loaded or not, so that could prevent >>>> meaningless following malloc dma descriptor and bd allocate in >>>> sdma_transfer_init(), otherwise memory may be consumed out >>>> potentially without free in case that spi fallback into pio while >>>> dma transfer failed by sdma firmware not ready(next ERR009165 patch >>>> depends on sdma >>> RAM scripts/firmware). >>>> >>>> Signed-off-by: Robin Gong <yibin.gong@nxp.com> >>>> Acked-By: Vinod Koul <vkoul@kernel.org> >>>> --- >>>> drivers/dma/imx-sdma.c | 13 +++++++++++++ >>>> 1 file changed, 13 insertions(+) >>>> >>>> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index >>>> 5411e01e..ce1c83e 100644 >>>> --- a/drivers/dma/imx-sdma.c >>>> +++ b/drivers/dma/imx-sdma.c >>>> @@ -379,6 +379,7 @@ struct sdma_channel { >>>> enum dma_status status; >>>> struct imx_dma_data data; >>>> struct work_struct terminate_worker; >>>> + bool is_ram_script; >>>> }; >>>> >>>> #define IMX_DMA_SG_LOOP BIT(0) >>>> @@ -443,6 +444,7 @@ struct sdma_engine { >>>> struct sdma_buffer_descriptor *bd0; >>>> /* clock ratio for AHB:SDMA core. 1:1 is 1, 2:1 is 0*/ >>>> bool clk_ratio; >>>> + bool fw_loaded; >>>> }; >>>> >>>> static int sdma_config_write(struct dma_chan *chan, @@ -929,6 >>>> +931,7 @@ static void sdma_get_pc(struct sdma_channel *sdmac, >>>> case IMX_DMATYPE_SSI_DUAL: >>>> per_2_emi = sdma->script_addrs->ssish_2_mcu_addr; >>>> emi_2_per = sdma->script_addrs->mcu_2_ssish_addr; >>>> + sdmac->is_ram_script = true; >>>> break; >>>> case IMX_DMATYPE_SSI_SP: >>>> case IMX_DMATYPE_MMC: >>>> @@ -943,6 +946,7 @@ static void sdma_get_pc(struct sdma_channel >>> *sdmac, >>>> per_2_emi = sdma->script_addrs->asrc_2_mcu_addr; >>>> emi_2_per = sdma->script_addrs->asrc_2_mcu_addr; >>>> per_2_per = sdma->script_addrs->per_2_per_addr; >>>> + sdmac->is_ram_script = true; >>>> break; >>>> case IMX_DMATYPE_ASRC_SP: >>>> per_2_emi = sdma->script_addrs->shp_2_mcu_addr; >>>> @@ -1339,6 +1343,11 @@ static struct sdma_desc >>> *sdma_transfer_init(struct sdma_channel *sdmac, >>>> { >>>> struct sdma_desc *desc; >>>> >>>> + if (!sdmac->sdma->fw_loaded && sdmac->is_ram_script) { >>>> + dev_err(sdmac->sdma->dev, "sdma firmware not ready!\n"); >>>> + goto err_out; >>>> + } >>> >>> I tried your v10 patches on next-20200722 with i.MX8MM and it mostly >>> seems to work fine. >>> >>> When I tried first, I had the imx-sdma driver compiled into the >>> kernel, so it didn't load the firmware and fell back to the ROM scripts. >>> With this, SPI transactions work just fine, but I got the above error >>> message printed continuously when sending data in SPI3 via spidev. >> That's caused by you didn't load ram firmware as this patch set described. >> Please follow below steps to load firmware manually if you don't want to use >> NXP official Yocto release package: >> >> 1. Get sdma firmware from below linux-firmware and copy it to your local >> rootfs /lib/firmware/imx/sdma. >> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-firmware.git%2Ft&data=02%7C01%7Cfrieder.schrempf%40kontron.de%7C08276b76f9a14dae1f8408d82ef94da1%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C637310995564511410&sdata=YA1455ILoNgRDHAOy1H2051J9cu5VsHk39xtQive8mo%3D&reserved=0 >> ree/imx/sdma >> 2. Load firmware manually: >> echo 1 > /sys/$DEVPATH/loading >> cat $MY_FW_DIR/$FIRMWARE > /sys/$DEVPATH/data >> echo 0 > /sys/$DEVPATH/loading >> Please refer to Documentation/driver-api/firmware/fallback-mechanisms.rst >> and load the firmware in 60s (firmware fallback loading timeout) from kernel >> boot up. >> >>> >>> When I build imx-sdma as a module, the firmware is loaded correctly >>> and everything works as expected. >> I guess that's not related with sdma building as module. If sdma build as >> module, spi will fall to pio mode at spi-imx driver probe phase so that the >> above warning log never to be walked. Would you please add some debug >> info to double confirm? > Hi Frider, > Please ignore this comment, since there is -EPROBE_DEFER checking > , so you load sdma firmware by building sdma driver as module instead of > the above comment I mentioned? Yes, correct. > The warning log comes out during spi > transfer start and sdma firmware loading done, but if sdma driver building as > module could ensure firmware loading done in sdma_driver_probe_phase-> > spi_imx_probe_phase, which means sdma firmware loading has been ready > before spi transfer start, hence no such warning message. > > But I am not sure if all client drivers except spi are in good shape to support > ' CONFIG_IMX_SDMA=m '. I'm pretty sure that CONFIG_IMX_SDMA=m is supported and common. Otherwise it wouldn't be an option in Kconfig. > Besides, do you think 'dev_err_once ' instead of 'dev_err' is okay for you? I can't really judge if this is a proper fix as I haven't looked at the code in detail, but if you want to use dev_err_once(), that would be ok for me, maybe even better dev_warn_once(). As chances are that even without firmware transfers will work a warning instead of an error makes more sense to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 11:51 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-30 13:31 [PATCH v10 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-07-15 5:57 ` Vinod Koul 2020-07-15 5:57 ` Vinod Koul 2020-07-23 9:03 ` Frieder Schrempf 2020-07-23 9:03 ` Frieder Schrempf 2020-07-23 10:24 ` Robin Gong 2020-07-23 10:24 ` Robin Gong 2020-07-23 11:12 ` Robin Gong 2020-07-23 11:12 ` Robin Gong 2020-07-23 11:51 ` Frieder Schrempf [this message] 2020-07-23 11:51 ` Frieder Schrempf 2020-07-23 14:11 ` Robin Gong 2020-07-23 14:11 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 07/12] spi: imx: fix ERR009165 Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 09/12] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 11/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong 2020-06-30 13:31 ` Robin Gong 2020-06-30 13:31 ` [PATCH v10 12/12] dmaengine: imx-sdma: add uart rom script Robin Gong 2020-06-30 13:31 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=22e53878-42e2-78ed-c460-3fa339c306ad@kontron.de \ --to=frieder.schrempf@kontron.de \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=martin.fuzzey@flowbird.group \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vkoul@kernel.org \ --cc=will.deacon@arm.com \ --cc=yibin.gong@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.