From: Ian Jackson <ian.jackson@eu.citrix.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: qemu-devel@nongnu.org, Ross Lagerwall <ross.lagerwall@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org Subject: Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore Date: Fri, 27 Oct 2017 11:12:48 +0100 [thread overview] Message-ID: <23027.1696.620560.710955@mariner.uk.xensource.com> (raw) In-Reply-To: <alpine.DEB.2.10.1710261539420.3086@sstabellini-ThinkPad-X260> Stefano Stabellini writes ("Re: [PATCH v5.1 1/8] xen: link against xentoolcore"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > > then > > - xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > + xen_stable_libs="-lxendevicemodel $xen_stable_libs -lxentoolcore" > > Is it on purpose that -lxentoolcore is at the end of this string rather > than before $xen_stable_libs? Yes. xentoolcore is required by the other libraries, and this is therefore the correct ordering for situations where the link order matters. > In any case > > Acked-by: Stefano Stabellini <sstabellini@kernel.org> Thanks, Ian.
WARNING: multiple messages have this Message-ID (diff)
From: Ian Jackson <ian.jackson@eu.citrix.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony PERARD <anthony.perard@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, Juergen Gross <jgross@suse.com> Subject: Re: [PATCH v5.1 1/8] xen: link against xentoolcore Date: Fri, 27 Oct 2017 11:12:48 +0100 [thread overview] Message-ID: <23027.1696.620560.710955@mariner.uk.xensource.com> (raw) In-Reply-To: <alpine.DEB.2.10.1710261539420.3086@sstabellini-ThinkPad-X260> Stefano Stabellini writes ("Re: [PATCH v5.1 1/8] xen: link against xentoolcore"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > > then > > - xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > + xen_stable_libs="-lxendevicemodel $xen_stable_libs -lxentoolcore" > > Is it on purpose that -lxentoolcore is at the end of this string rather > than before $xen_stable_libs? Yes. xentoolcore is required by the other libraries, and this is therefore the correct ordering for situations where the link order matters. > In any case > > Acked-by: Stefano Stabellini <sstabellini@kernel.org> Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-27 10:12 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-19 16:51 [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runas <uid>.<gid> facility Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 16:51 ` [Qemu-devel] [PATCH 8/8] configure: do_compiler: Dump some extra info under bash Ian Jackson 2017-10-19 16:51 ` Ian Jackson 2017-10-19 18:56 ` [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements no-reply 2017-10-19 18:56 ` no-reply 2017-10-20 10:32 ` Ian Jackson 2017-10-20 10:32 ` Ian Jackson 2017-10-20 13:30 ` Anthony PERARD 2017-10-20 13:30 ` Anthony PERARD 2017-10-20 13:37 ` [Qemu-devel] " Ian Jackson 2017-10-20 13:37 ` Ian Jackson 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-26 21:35 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 21:35 ` Stefano Stabellini 2017-10-27 10:30 ` [Qemu-devel] " Ian Jackson 2017-10-27 10:30 ` Ian Jackson 2017-10-27 17:20 ` [Qemu-devel] " Stefano Stabellini 2017-10-27 17:20 ` Stefano Stabellini 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 3/8] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-26 21:37 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 21:37 ` Stefano Stabellini 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-26 21:38 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 21:38 ` Stefano Stabellini 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-26 22:55 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 22:55 ` Stefano Stabellini 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-26 22:26 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 22:26 ` Stefano Stabellini 2017-10-27 10:16 ` [Qemu-devel] " Ian Jackson 2017-10-27 10:16 ` Ian Jackson 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson 2017-10-20 13:38 ` Ian Jackson 2017-10-24 17:29 ` [Qemu-devel] " Anthony PERARD 2017-10-24 17:29 ` Anthony PERARD 2017-10-24 18:19 ` [Qemu-devel] " Ian Jackson 2017-10-24 18:19 ` Ian Jackson 2017-10-26 22:29 ` [Qemu-devel] " Stefano Stabellini 2017-10-26 22:29 ` Stefano Stabellini 2017-10-27 10:33 ` [Qemu-devel] " Ian Jackson 2017-10-27 10:33 ` Ian Jackson 2017-10-20 13:38 ` [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash Ian Jackson 2017-10-20 13:38 ` Ian Jackson [not found] ` <1508528463.474221335@apps.rackspace.com> 2017-10-23 11:17 ` [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash [and 1 more messages] Ian Jackson 2017-10-23 11:17 ` Ian Jackson 2017-10-26 22:27 ` [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash Stefano Stabellini 2017-10-26 22:27 ` Stefano Stabellini 2017-10-27 10:40 ` [Qemu-devel] " Ian Jackson 2017-10-27 10:40 ` Ian Jackson 2017-10-26 22:41 ` [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore Stefano Stabellini 2017-10-26 22:41 ` Stefano Stabellini 2017-10-27 10:12 ` Ian Jackson [this message] 2017-10-27 10:12 ` Ian Jackson 2018-01-24 11:03 ` [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements Ross Lagerwall 2018-01-24 11:03 ` Ross Lagerwall 2018-01-24 11:31 ` [Qemu-devel] " Ian Jackson 2018-01-24 11:31 ` Ian Jackson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=23027.1696.620560.710955@mariner.uk.xensource.com \ --to=ian.jackson@eu.citrix.com \ --cc=anthony.perard@citrix.com \ --cc=jgross@suse.com \ --cc=qemu-devel@nongnu.org \ --cc=ross.lagerwall@citrix.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.