From: Heiko Stuebner <heiko@sntech.de>
To: Thomas McKahan <tmckahan@singleboardsolutions.com>
Cc: Markus Reichl <m.reichl@fivetechno.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
narmstrong@baylibre.com
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Enable PD for USB-C-Port on rk3399-roc-pc.
Date: Sat, 21 Dec 2019 13:57:37 +0100 [thread overview]
Message-ID: <2330032.fiRFtybceW@phil> (raw)
In-Reply-To: <84920a36-230f-42a6-a960-a71e685be99f@singleboardsolutions.com>
Hi Thomas,
Am Donnerstag, 12. Dezember 2019, 16:46:09 CET schrieb Thomas McKahan:
> Hello Markus,
>
> I have been working with this as well, came across it on Armbian. I was also trying to eliminate the warning concerning the lack of port with limited success. I also missed the interrupt pin definition I see. I will test this later today.
Where you successful in your testing? My type-c exposure is somewhat
limited so it would be nice to get another opinion ;-)
> I've added Neil Armstrong for information in case any boards on the Amlogic side are similarly configured, I think a few other Rockchip ones at least are missing connector nodes, it appears to be a consistent issue presumably due to driver changes.
The whole type-c topic is a somewhat undiscovered country on rk3399, due to
the cross-ec hooking rk3399's type-c components. (see the cros-ec-pd extcon
going to the rockchip type-c phy etc).
This is presently worked on so that also everything can at some point use the
kernel-internal type-c framework.
But of course this doesn't hinder configuring the power-develivery in the
fusb302 ICs already :-D .
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Thomas McKahan <tmckahan@singleboardsolutions.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, narmstrong@baylibre.com,
linux-kernel@vger.kernel.org,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Enable PD for USB-C-Port on rk3399-roc-pc.
Date: Sat, 21 Dec 2019 13:57:37 +0100 [thread overview]
Message-ID: <2330032.fiRFtybceW@phil> (raw)
In-Reply-To: <84920a36-230f-42a6-a960-a71e685be99f@singleboardsolutions.com>
Hi Thomas,
Am Donnerstag, 12. Dezember 2019, 16:46:09 CET schrieb Thomas McKahan:
> Hello Markus,
>
> I have been working with this as well, came across it on Armbian. I was also trying to eliminate the warning concerning the lack of port with limited success. I also missed the interrupt pin definition I see. I will test this later today.
Where you successful in your testing? My type-c exposure is somewhat
limited so it would be nice to get another opinion ;-)
> I've added Neil Armstrong for information in case any boards on the Amlogic side are similarly configured, I think a few other Rockchip ones at least are missing connector nodes, it appears to be a consistent issue presumably due to driver changes.
The whole type-c topic is a somewhat undiscovered country on rk3399, due to
the cross-ec hooking rk3399's type-c components. (see the cros-ec-pd extcon
going to the rockchip type-c phy etc).
This is presently worked on so that also everything can at some point use the
kernel-internal type-c framework.
But of course this doesn't hinder configuring the power-develivery in the
fusb302 ICs already :-D .
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Thomas McKahan <tmckahan@singleboardsolutions.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, narmstrong@baylibre.com,
linux-kernel@vger.kernel.org,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Enable PD for USB-C-Port on rk3399-roc-pc.
Date: Sat, 21 Dec 2019 13:57:37 +0100 [thread overview]
Message-ID: <2330032.fiRFtybceW@phil> (raw)
In-Reply-To: <84920a36-230f-42a6-a960-a71e685be99f@singleboardsolutions.com>
Hi Thomas,
Am Donnerstag, 12. Dezember 2019, 16:46:09 CET schrieb Thomas McKahan:
> Hello Markus,
>
> I have been working with this as well, came across it on Armbian. I was also trying to eliminate the warning concerning the lack of port with limited success. I also missed the interrupt pin definition I see. I will test this later today.
Where you successful in your testing? My type-c exposure is somewhat
limited so it would be nice to get another opinion ;-)
> I've added Neil Armstrong for information in case any boards on the Amlogic side are similarly configured, I think a few other Rockchip ones at least are missing connector nodes, it appears to be a consistent issue presumably due to driver changes.
The whole type-c topic is a somewhat undiscovered country on rk3399, due to
the cross-ec hooking rk3399's type-c components. (see the cros-ec-pd extcon
going to the rockchip type-c phy etc).
This is presently worked on so that also everything can at some point use the
kernel-internal type-c framework.
But of course this doesn't hinder configuring the power-develivery in the
fusb302 ICs already :-D .
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-21 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 12:45 [PATCH 2/3] arm64: dts: rockchip: Enable PD for USB-C-Port on rk3399-roc-pc Markus Reichl
2019-12-10 12:45 ` Markus Reichl
2019-12-12 15:46 ` Thomas McKahan
2019-12-12 15:46 ` Thomas McKahan
2019-12-12 15:46 ` Thomas McKahan
2019-12-21 12:57 ` Heiko Stuebner [this message]
2019-12-21 12:57 ` Heiko Stuebner
2019-12-21 12:57 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2330032.fiRFtybceW@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tmckahan@singleboardsolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.