From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, icenowy@aosc.io,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 00/27] Improve DE2 support
Date: Tue, 05 Dec 2017 16:52:57 +0100 [thread overview]
Message-ID: <23633465.uxSxGdCvtg@jernej-laptop> (raw)
In-Reply-To: <20171205103618.ps64m57xemsbo44r@flea.lan>
Hi Maxime,
Dne torek, 05. december 2017 ob 11:36:18 CET je Maxime Ripard napisal(a):
> Hi,
>
> On Fri, Dec 01, 2017 at 07:05:23AM +0100, Jernej Skrabec wrote:
> > Current DE2 driver is very basic and uses a lot of magic constants since
> > there is no documentation and knowledge about it was limited at the time.
> >
> > With studying BSP source code, deeper knowledge was gained which allows
> > to improve mainline driver considerably.
> >
> > At the beginning of this series, some code refactoring is done as well
> > as adding some checks (patches 1-15).
> >
> > Further patches add multi-plane support with HW scaling and all possible
> > RGB formats (patches 16-21).
> >
> > At last, support for YUV formats is added (patches 22-26).
> >
> > At the end, I included patch which puts lowest plane before second lowest.
> > This should help testing VI planes when mixer has configuration 1 VI plane
> > and 1 or more UI planes (most SoCs except V3s).
> >
> > This code was developed on H3, but it should work on every SoC if correct
> > configuration structure is provided.
> >
> > H3 code can be found here:
> > https://github.com/jernejsk/linux-1/commits/de2_impr_for_next
>
> Thanks a lot for that huge rework.
>
> I've applied the patches 1 to 26, and will push them to drm-misc once
> the compilations are done.
>
> In the future, if you happen to do such a huge rework again (which
> hopefully won't be needed :)), please use the -M option of
> format-patch. It will reduce a lot the verbosity of files renaming and
> will help the review.
Noted.
I think I missed initialization of min_scaler and max_scaler in
sun8i_vi_layer_atomic_check() in sun8i_vi_layer.c when I was reworking
patches.
Will you fix patch with those two lines
min_scale = DRM_PLANE_HELPER_NO_SCALING;
max_scale = DRM_PLANE_HELPER_NO_SCALING;
or should I send new patch which fixes that or should I send new version of
original patch?
Best regards,
Jernej
WARNING: multiple messages have this Message-ID (diff)
From: jernej.skrabec@siol.net (Jernej Škrabec)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/27] Improve DE2 support
Date: Tue, 05 Dec 2017 16:52:57 +0100 [thread overview]
Message-ID: <23633465.uxSxGdCvtg@jernej-laptop> (raw)
In-Reply-To: <20171205103618.ps64m57xemsbo44r@flea.lan>
Hi Maxime,
Dne torek, 05. december 2017 ob 11:36:18 CET je Maxime Ripard napisal(a):
> Hi,
>
> On Fri, Dec 01, 2017 at 07:05:23AM +0100, Jernej Skrabec wrote:
> > Current DE2 driver is very basic and uses a lot of magic constants since
> > there is no documentation and knowledge about it was limited at the time.
> >
> > With studying BSP source code, deeper knowledge was gained which allows
> > to improve mainline driver considerably.
> >
> > At the beginning of this series, some code refactoring is done as well
> > as adding some checks (patches 1-15).
> >
> > Further patches add multi-plane support with HW scaling and all possible
> > RGB formats (patches 16-21).
> >
> > At last, support for YUV formats is added (patches 22-26).
> >
> > At the end, I included patch which puts lowest plane before second lowest.
> > This should help testing VI planes when mixer has configuration 1 VI plane
> > and 1 or more UI planes (most SoCs except V3s).
> >
> > This code was developed on H3, but it should work on every SoC if correct
> > configuration structure is provided.
> >
> > H3 code can be found here:
> > https://github.com/jernejsk/linux-1/commits/de2_impr_for_next
>
> Thanks a lot for that huge rework.
>
> I've applied the patches 1 to 26, and will push them to drm-misc once
> the compilations are done.
>
> In the future, if you happen to do such a huge rework again (which
> hopefully won't be needed :)), please use the -M option of
> format-patch. It will reduce a lot the verbosity of files renaming and
> will help the review.
Noted.
I think I missed initialization of min_scaler and max_scaler in
sun8i_vi_layer_atomic_check() in sun8i_vi_layer.c when I was reworking
patches.
Will you fix patch with those two lines
min_scale = DRM_PLANE_HELPER_NO_SCALING;
max_scale = DRM_PLANE_HELPER_NO_SCALING;
or should I send new patch which fixes that or should I send new version of
original patch?
Best regards,
Jernej
next prev parent reply other threads:[~2017-12-05 15:53 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 6:05 [PATCH v2 00/27] Improve DE2 support Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 01/27] drm/sun4i: Fix format mask in DE2 driver Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 02/27] drm/sun4i: Rename DE2 RGB format macros Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 03/27] drm/sun4i: Remove setting alpha mode in DE2 driver Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 04/27] drm/sun4i: Fix debug message in DE2 Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 05/27] drm/sun4i: Remove setting default values in DE2 driver Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 06/27] drm/sun4i: Explain color macro " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 07/27] drm/sun4i: Set blending mode for all channels (DE2) Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 08/27] drm/sun4i: Rename some macros in DE2 driver Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 09/27] drm/sun4i: Rework enabling plane " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 10/27] drm/sun4i: Start using layer id " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 11/27] drm/sun4i: Add constraints checking to " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 12/27] drm/sun4i: Use values calculated by atomic check Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 13/27] drm/sun4i: Move line width setting in DE2 Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 14/27] drm/sun4i: Move channel size related code " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 15/27] drm/sun4i: Move interlace " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 16/27] drm/sun4i: Add multi plane support to DE2 driver Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 17/27] drm/sun4i: Add support for all HW supported DE2 RGB formats Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 18/27] drm/sun4i: Reorganize UI layer code in DE2 Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 19/27] drm/sun4i: Add support for DE2 VI planes Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 20/27] drm/sun4i: Add scaler configuration to DE2 mixers Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 21/27] drm/sun4i: Add support for HW scaling to DE2 Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 22/27] drm/sun4i: Add CCSC property to DE2 configuration Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 23/27] drm/sun4i: Add DE2 CSC library Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 24/27] drm/sun4i: Add DE2 definitions for YUV formats Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 25/27] drm/sun4i: Expand DE2 scaler lib with YUV support Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 26/27] drm/sun4i: Wire in DE2 " Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` [PATCH v2 27/27] [DO NOT MERGE]drm/sun4i: Change zpos of bottom VI plane Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-01 6:05 ` Jernej Skrabec
2017-12-05 10:36 ` [PATCH v2 00/27] Improve DE2 support Maxime Ripard
2017-12-05 10:36 ` Maxime Ripard
2017-12-05 10:36 ` Maxime Ripard
2017-12-05 15:52 ` Jernej Škrabec [this message]
2017-12-05 15:52 ` Jernej Škrabec
2017-12-05 19:23 ` Maxime Ripard
2017-12-05 19:23 ` Maxime Ripard
2017-12-05 19:23 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23633465.uxSxGdCvtg@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.