From: Anthony Krowiak <akrowiak@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, jjherne@linux.ibm.com,
alex.williamson@redhat.com, borntraeger@linux.ibm.com,
kwankhede@nvidia.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset
Date: Tue, 9 Jan 2024 12:02:23 -0500 [thread overview]
Message-ID: <24039c50-9079-4ca5-b7b0-867c64d70630@linux.ibm.com> (raw)
In-Reply-To: <20231204230529.07bf7b79.pasic@linux.ibm.com>
On 12/4/23 5:05 PM, Halil Pasic wrote:
> On Mon, 4 Dec 2023 12:51:49 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>>> s/if\/when/at latest before/
>>>
>>> I would argue that some of the cleanups need to happen before even 01 is
>>> reflected...
>> To what cleanups are you referring?
> Event notification and interruption disablement for starters. Otherwise
> OS has no way to figure out when is GISA and NIB safe to deallocate.
> Those actions are part of the reset process. I.e. some of the reset stuff
> can be deferred at most until the queue is made accessible again, some
> not so much.
How do you propose we disable interrupts if the PQAP(AQIC) will likely
fail with response code 01 which is the subject of this patch? Do you
think we should not free up the AQIC resources as we do in this patch?
>
>
> Regards,
> Halil
prev parent reply other threads:[~2024-01-09 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:35 [PATCH] s390/vfio-ap: handle response code 01 on queue reset Tony Krowiak
2023-11-29 17:12 ` Christian Borntraeger
2023-12-04 14:53 ` Tony Krowiak
2023-12-04 15:16 ` Christian Borntraeger
2023-12-04 16:15 ` Halil Pasic
2023-12-04 17:05 ` Tony Krowiak
2023-12-05 8:04 ` Harald Freudenberger
2023-12-06 17:17 ` Halil Pasic
2023-12-07 15:31 ` Anthony Krowiak
2023-12-04 12:10 ` Halil Pasic
2023-12-04 17:51 ` Tony Krowiak
2023-12-04 22:05 ` Halil Pasic
2024-01-09 17:02 ` Anthony Krowiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24039c50-9079-4ca5-b7b0-867c64d70630@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.