From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, jjherne@linux.ibm.com,
alex.williamson@redhat.com, borntraeger@linux.ibm.com,
kwankhede@nvidia.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset
Date: Mon, 4 Dec 2023 12:51:49 -0500 [thread overview]
Message-ID: <7c0d0ad2-b814-47b1-80e9-28ad62af6476@linux.ibm.com> (raw)
In-Reply-To: <20231204131045.217586a3.pasic@linux.ibm.com>
On 12/4/23 07:10, Halil Pasic wrote:
> On Wed, 29 Nov 2023 09:35:24 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> In the current implementation, response code 01 (AP queue number not valid)
>> is handled as a default case along with other response codes returned from
>> a queue reset operation that are not handled specifically. Barring a bug,
>> response code 01 will occur only when a queue has been externally removed
>> from the host's AP configuration; nn this case, the queue must
>> be reset by the machine in order to avoid leaking crypto data if/when the
>> queue is returned to the host's configuration.
>
> s/if\/when/at latest before/
>
> I would argue that some of the cleanups need to happen before even 01 is
> reflected...
To what cleanups are you referring?
>
> The code comments may also require a similar rewording. With that fixed:
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
>
> Regards,
> Halil
>
>> The response code 01 case
>> will be handled specifically by logging a WARN message followed by cleaning
>> up the IRQ resources.
>>
>> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
next prev parent reply other threads:[~2023-12-04 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:35 [PATCH] s390/vfio-ap: handle response code 01 on queue reset Tony Krowiak
2023-11-29 17:12 ` Christian Borntraeger
2023-12-04 14:53 ` Tony Krowiak
2023-12-04 15:16 ` Christian Borntraeger
2023-12-04 16:15 ` Halil Pasic
2023-12-04 17:05 ` Tony Krowiak
2023-12-05 8:04 ` Harald Freudenberger
2023-12-06 17:17 ` Halil Pasic
2023-12-07 15:31 ` Anthony Krowiak
2023-12-04 12:10 ` Halil Pasic
2023-12-04 17:51 ` Tony Krowiak [this message]
2023-12-04 22:05 ` Halil Pasic
2024-01-09 17:02 ` Anthony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c0d0ad2-b814-47b1-80e9-28ad62af6476@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.