From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties
Date: Thu, 14 Jan 2021 12:31:40 +0000 [thread overview]
Message-ID: <240f974b-f546-f51d-2499-514680a82c35@opensource.cirrus.com> (raw)
In-Reply-To: <20210114111422.GA4854@sirena.org.uk>
On 14/01/2021 11:14, Mark Brown wrote:
> On Thu, Jan 14, 2021 at 10:31:10AM +0000, Richard Fitzgerald wrote:
>> On 13/01/2021 15:22, Rob Herring wrote:
>
>>> This appears to all be configuration of clocks within the codec, so
>>> these properties belong in the codec or cpu nodes.
>
>> audio-graph-card doesn't have codec or cpu nodes. Those were in
>> simple-card but are replaced in audio-graph-card by a simple phandle
>> array forming a graph.
>
>> I could assume that all clock settings apply to the codec and that there
>> is only ever one codec in an audio-graph-card configuration.
>
> The suggestion here is to put properties in the node for the relevant
> device rather than the card.
>
That's seems bad to me - putting the properties for one driver in the
node of another driver. It's also potentially misleading as an example.
As in something like:
wm5102: wm5102 {
compatible = "wlf,wm5102";
sysclks = <&some_clock>;
plls = <&some_other_clock>;
...
};
To me that seems to imply that these are properties of the wm5102 driver
and it is going to setup its own sysclk and pll settings from those
properties. But actually it's the machine driver that does it, and these
properties are specific to audio-graph-card.
next prev parent reply other threads:[~2021-01-14 12:32 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 16:04 [PATCH v4 0/6] Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15 Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 1/6] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-13 15:22 ` Rob Herring
2021-01-13 15:22 ` Rob Herring
2021-01-13 15:22 ` Rob Herring
2021-01-13 16:09 ` Mark Brown
2021-01-13 16:09 ` Mark Brown
2021-01-13 16:09 ` Mark Brown
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 13:11 ` Mark Brown
2021-01-15 13:11 ` Mark Brown
2021-01-15 13:11 ` Mark Brown
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 15:20 ` Mark Brown
2021-01-15 15:20 ` Mark Brown
2021-01-15 15:20 ` Mark Brown
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 18:35 ` Mark Brown
2021-01-15 18:35 ` Mark Brown
2021-01-15 18:35 ` Mark Brown
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 11:14 ` Mark Brown
2021-01-14 11:14 ` Mark Brown
2021-01-14 11:14 ` Mark Brown
2021-01-14 12:31 ` Richard Fitzgerald [this message]
2021-01-08 16:04 ` [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 15:51 ` Mark Brown
2021-01-13 15:51 ` Mark Brown
2021-01-13 15:51 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 4/6] ASoC: madera: Allow codecs to be selected from kernel config Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 5/6] ASoC: madera: Export clock config defines to dt-bindings Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15 Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=240f974b-f546-f51d-2499-514680a82c35@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.