From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Rob Herring <robh@kernel.org>,
kuninori.morimoto.gx@renesas.com, nsaenzjulienne@suse.de,
f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties
Date: Fri, 15 Jan 2021 13:11:42 +0000 [thread overview]
Message-ID: <20210115131142.GA4384@sirena.org.uk> (raw)
In-Reply-To: <ee3d0b75-dc2f-9994-19a4-a3c3f21a2c65@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
On Fri, Jan 15, 2021 at 10:35:23AM +0000, Richard Fitzgerald wrote:
> On 13/01/2021 16:09, Mark Brown wrote:
> > On Wed, Jan 13, 2021 at 09:22:25AM -0600, Rob Herring wrote:
> some_codec {
> pll: pll {
> compatible = "fixed-clock";
> clocks = <&audio_mclk>;
> clock-frequency = <98304000>;
> }
A PLL is not a fixed clock, why would you define a fixed clock here?
Are you confusing the selection of rates on existing clocks with the use
of the assigned-* properties that the clock binding provides?
> For this to work the clock binding must be a real clock object (so needs
> a valid compatible=). But I need to somehow specify the PLL ID and
That seems like a *very* surprising requirement - why would the clock
binding have that requirement? It would seem to create issues for a
single device providing multiple clocks which should be a pretty common
coase.
> > > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > > > + description: |
> > > > + A list of clock names giving the source clock for each setting
> > > > + in the sysclks property.
> > > > +
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
alsa-devel@alsa-project.org, f.fainelli@gmail.com,
kuninori.morimoto.gx@renesas.com, devicetree@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de
Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties
Date: Fri, 15 Jan 2021 13:11:42 +0000 [thread overview]
Message-ID: <20210115131142.GA4384@sirena.org.uk> (raw)
In-Reply-To: <ee3d0b75-dc2f-9994-19a4-a3c3f21a2c65@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
On Fri, Jan 15, 2021 at 10:35:23AM +0000, Richard Fitzgerald wrote:
> On 13/01/2021 16:09, Mark Brown wrote:
> > On Wed, Jan 13, 2021 at 09:22:25AM -0600, Rob Herring wrote:
> some_codec {
> pll: pll {
> compatible = "fixed-clock";
> clocks = <&audio_mclk>;
> clock-frequency = <98304000>;
> }
A PLL is not a fixed clock, why would you define a fixed clock here?
Are you confusing the selection of rates on existing clocks with the use
of the assigned-* properties that the clock binding provides?
> For this to work the clock binding must be a real clock object (so needs
> a valid compatible=). But I need to somehow specify the PLL ID and
That seems like a *very* surprising requirement - why would the clock
binding have that requirement? It would seem to create issues for a
single device providing multiple clocks which should be a pretty common
coase.
> > > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > > > + description: |
> > > > + A list of clock names giving the source clock for each setting
> > > > + in the sysclks property.
> > > > +
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, f.fainelli@gmail.com,
kuninori.morimoto.gx@renesas.com, devicetree@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de
Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties
Date: Fri, 15 Jan 2021 13:11:42 +0000 [thread overview]
Message-ID: <20210115131142.GA4384@sirena.org.uk> (raw)
In-Reply-To: <ee3d0b75-dc2f-9994-19a4-a3c3f21a2c65@opensource.cirrus.com>
[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]
On Fri, Jan 15, 2021 at 10:35:23AM +0000, Richard Fitzgerald wrote:
> On 13/01/2021 16:09, Mark Brown wrote:
> > On Wed, Jan 13, 2021 at 09:22:25AM -0600, Rob Herring wrote:
> some_codec {
> pll: pll {
> compatible = "fixed-clock";
> clocks = <&audio_mclk>;
> clock-frequency = <98304000>;
> }
A PLL is not a fixed clock, why would you define a fixed clock here?
Are you confusing the selection of rates on existing clocks with the use
of the assigned-* properties that the clock binding provides?
> For this to work the clock binding must be a real clock object (so needs
> a valid compatible=). But I need to somehow specify the PLL ID and
That seems like a *very* surprising requirement - why would the clock
binding have that requirement? It would seem to create issues for a
single device providing multiple clocks which should be a pretty common
coase.
> > > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > > > + description: |
> > > > + A list of clock names giving the source clock for each setting
> > > > + in the sysclks property.
> > > > +
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-15 13:13 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 16:04 [PATCH v4 0/6] Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15 Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 1/6] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-13 15:22 ` Rob Herring
2021-01-13 15:22 ` Rob Herring
2021-01-13 15:22 ` Rob Herring
2021-01-13 16:09 ` Mark Brown
2021-01-13 16:09 ` Mark Brown
2021-01-13 16:09 ` Mark Brown
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 13:11 ` Mark Brown [this message]
2021-01-15 13:11 ` Mark Brown
2021-01-15 13:11 ` Mark Brown
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 15:20 ` Mark Brown
2021-01-15 15:20 ` Mark Brown
2021-01-15 15:20 ` Mark Brown
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 18:35 ` Mark Brown
2021-01-15 18:35 ` Mark Brown
2021-01-15 18:35 ` Mark Brown
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 11:14 ` Mark Brown
2021-01-14 11:14 ` Mark Brown
2021-01-14 11:14 ` Mark Brown
2021-01-14 12:31 ` Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 15:51 ` Mark Brown
2021-01-13 15:51 ` Mark Brown
2021-01-13 15:51 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 4/6] ASoC: madera: Allow codecs to be selected from kernel config Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:04 ` Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 5/6] ASoC: madera: Export clock config defines to dt-bindings Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15 Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
2021-01-08 16:05 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115131142.GA4384@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.