From: Arnd Bergmann <arnd@arndb.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency
Date: Wed, 25 Feb 2015 16:44:15 +0100 [thread overview]
Message-ID: <2482424.WOd0SW5Oav@wuerfel> (raw)
In-Reply-To: <54EDEAE3.6080605@ti.com>
On Wednesday 25 February 2015 17:31:47 Peter Ujfalusi wrote:
> Would it be better to have this changed to:
> select COMMON_CLK_PALMAS if MFD_PALMAS
> instead of removing.
>
> All OMAP5 boards uses Palmas as PMIC and the boards where twl6040 audio is in
> use the 32K clock for the codec is coming from Palmas.
> Without this clock the twl6040 will not boot up causing errors during probe time.
It's possible to build a kernel with omap5 support and this driver but
no palmas support, which makes the dependency it a bit strange, but I'll
let Mark decide.
Unfortunately, I've sent the changed v2 patch without fixing up the commit
message. Instead of sending another v3 right away, I'll wait for Mark
to comment.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency
Date: Wed, 25 Feb 2015 16:44:15 +0100 [thread overview]
Message-ID: <2482424.WOd0SW5Oav@wuerfel> (raw)
In-Reply-To: <54EDEAE3.6080605@ti.com>
On Wednesday 25 February 2015 17:31:47 Peter Ujfalusi wrote:
> Would it be better to have this changed to:
> select COMMON_CLK_PALMAS if MFD_PALMAS
> instead of removing.
>
> All OMAP5 boards uses Palmas as PMIC and the boards where twl6040 audio is in
> use the 32K clock for the codec is coming from Palmas.
> Without this clock the twl6040 will not boot up causing errors during probe time.
It's possible to build a kernel with omap5 support and this driver but
no palmas support, which makes the dependency it a bit strange, but I'll
let Mark decide.
Unfortunately, I've sent the changed v2 patch without fixing up the commit
message. Instead of sending another v3 right away, I'll wait for Mark
to comment.
Arnd
next prev parent reply other threads:[~2015-02-25 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:05 [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency Arnd Bergmann
2015-02-25 15:05 ` Arnd Bergmann
2015-02-25 15:31 ` Peter Ujfalusi
2015-02-25 15:31 ` Peter Ujfalusi
2015-02-25 15:42 ` [PATCH v2] " Arnd Bergmann
2015-02-25 15:42 ` Arnd Bergmann
2015-02-26 15:08 ` Peter Ujfalusi
2015-02-26 15:08 ` Peter Ujfalusi
2015-03-06 19:50 ` Mark Brown
2015-03-06 19:50 ` Mark Brown
2015-02-25 15:44 ` Arnd Bergmann [this message]
2015-02-25 15:44 ` [PATCH] " Arnd Bergmann
2015-02-26 2:02 ` Mark Brown
2015-02-26 2:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2482424.WOd0SW5Oav@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.