From: Philipp Zabel <p.zabel@pengutronix.de>
To: Joel Stanley <joel@jms.id.au>, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Brad Bishop <bradleyb@fuzziesquirrel.com>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
Date: Mon, 02 Dec 2019 13:53:37 +0100 [thread overview]
Message-ID: <2498da189d5e21ae70fb6884df6fc16ecfee2087.camel@pengutronix.de> (raw)
In-Reply-To: <20191129000827.650566-3-joel@jms.id.au>
On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
> From: Brad Bishop <bradleyb@fuzziesquirrel.com>
>
> The AST2600 SoC contains the same LPC register set as the AST2500.
If the LPC register set is exactly the same, shouldn't AST2600 reuse the
AST2500 compatible, i.e.:
compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
?
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/reset/reset-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> index 067e7e7b34f1..795c9063fe7b 100644
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
> .data = &reset_simple_active_low },
> { .compatible = "aspeed,ast2400-lpc-reset" },
> { .compatible = "aspeed,ast2500-lpc-reset" },
> + { .compatible = "aspeed,ast2600-lpc-reset" },
> { .compatible = "bitmain,bm1880-reset",
> .data = &reset_simple_active_low },
> { .compatible = "snps,dw-high-reset" },
regards
Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Joel Stanley <joel@jms.id.au>, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org,
Brad Bishop <bradleyb@fuzziesquirrel.com>,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
Date: Mon, 02 Dec 2019 13:53:37 +0100 [thread overview]
Message-ID: <2498da189d5e21ae70fb6884df6fc16ecfee2087.camel@pengutronix.de> (raw)
In-Reply-To: <20191129000827.650566-3-joel@jms.id.au>
On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
> From: Brad Bishop <bradleyb@fuzziesquirrel.com>
>
> The AST2600 SoC contains the same LPC register set as the AST2500.
If the LPC register set is exactly the same, shouldn't AST2600 reuse the
AST2500 compatible, i.e.:
compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
?
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/reset/reset-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> index 067e7e7b34f1..795c9063fe7b 100644
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -125,6 +125,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
> .data = &reset_simple_active_low },
> { .compatible = "aspeed,ast2400-lpc-reset" },
> { .compatible = "aspeed,ast2500-lpc-reset" },
> + { .compatible = "aspeed,ast2600-lpc-reset" },
> { .compatible = "bitmain,bm1880-reset",
> .data = &reset_simple_active_low },
> { .compatible = "snps,dw-high-reset" },
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-02 12:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring
2019-12-13 21:42 ` Rob Herring
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-12-02 12:53 ` Philipp Zabel [this message]
2019-12-02 12:53 ` Philipp Zabel
2019-12-12 14:51 ` Brad Bishop
2019-12-12 14:51 ` Brad Bishop
2019-12-12 15:17 ` Philipp Zabel
2019-12-12 15:17 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2498da189d5e21ae70fb6884df6fc16ecfee2087.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.